public inbox for gcc-prs@sourceware.org help / color / mirror / Atom feed
From: john.carter@tait.co.nz To: gcc-gnats@gcc.gnu.org Subject: libobjc/9751: malloc of strlen, not strlen+1 Date: Wed, 19 Feb 2003 03:46:00 -0000 [thread overview] Message-ID: <20030219034349.3771.qmail@sources.redhat.com> (raw) >Number: 9751 >Category: libobjc >Synopsis: malloc of strlen, not strlen+1 >Confidential: no >Severity: non-critical >Priority: low >Responsible: unassigned >State: open >Class: sw-bug >Submitter-Id: net >Arrival-Date: Wed Feb 19 03:46:00 UTC 2003 >Closed-Date: >Last-Modified: >Originator: john.carter@tait.co.nz >Release: gcc-3.2.2 >Organization: >Environment: all >Description: In file /gcc-3.2.1/libobjc/gc.c line 415 there is the following (possibly buggy?) code... /* The variable is gc_invisible and we have to reverse it */ new_type = objc_atomic_malloc (strlen (ivar->ivar_type)); strncpy (new_type, ivar->ivar_type, (size_t)(type - ivar->ivar_type)); strcat (new_type, type + 1); ivar->ivar_type = new_type; Probably that should be malloc(strlen()+1) for the null. Also strncpy is an fugly beast that almost always doesn't do what you want. ie. Will there always be a null termination in the right place for the following strcat()? >How-To-Repeat: Found using my collection of perl regex's for finding standard "gotcha's" >Fix: >Release-Note: >Audit-Trail: >Unformatted:
next reply other threads:[~2003-02-19 3:46 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2003-02-19 3:46 john.carter [this message] 2003-05-12 8:56 Richard Frith-Macdonald 2003-05-12 22:06 John Carter 2003-05-13 5:06 Richard Frith-Macdonald
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20030219034349.3771.qmail@sources.redhat.com \ --to=john.carter@tait.co.nz \ --cc=gcc-gnats@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).