public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
From: Richard Frith-Macdonald <richard@brainstorm.co.uk>
To: nobody@gcc.gnu.org
Cc: gcc-prs@gcc.gnu.org,
Subject: Re: libobjc/9751: malloc of strlen, not strlen+1
Date: Mon, 12 May 2003 08:56:00 -0000	[thread overview]
Message-ID: <20030512085603.28135.qmail@sources.redhat.com> (raw)

The following reply was made to PR libobjc/9751; it has been noted by GNATS.

From: Richard Frith-Macdonald <richard@brainstorm.co.uk>
To: gcc-prs@gcc.gnu.org, john.carter@tait.co.nz, gcc-bugs@gcc.gnu.org,
   gcc-gnats@gcc.gnu.org, nobody@gcc.gnu.org
Cc:  
Subject: Re: libobjc/9751: malloc of strlen, not strlen+1
Date: Mon, 12 May 2003 09:51:54 +0100

 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=9751
 
 I was just looking at this ... and I don't think this is a bug.
 If I understand the code correctly, it is removing a single byte (the 
 garbage collecting invisibility marker) from the type string.  So the 
 length of the new string is one byte less than that of the original.
 So allocating strlen(ivar->ivar_type) bytes is correct.
 It might perhaps be worth adding a comment to thiks effect in the source 
 though.
 


             reply	other threads:[~2003-05-12  8:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-12  8:56 Richard Frith-Macdonald [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-05-13  5:06 Richard Frith-Macdonald
2003-05-12 22:06 John Carter
2003-02-19  3:46 john.carter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030512085603.28135.qmail@sources.redhat.com \
    --to=richard@brainstorm.co.uk \
    --cc=gcc-prs@gcc.gnu.org \
    --cc=nobody@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).