public inbox for gcc-prs@sourceware.org help / color / mirror / Atom feed
From: DJ Delorie <dj@redhat.com> To: nobody@gcc.gnu.org Cc: gcc-prs@gcc.gnu.org, Subject: Re: c++/5390: Libiberty fails to demangle multi-digit template parameters. Date: Fri, 07 Mar 2003 17:26:00 -0000 [thread overview] Message-ID: <20030307172601.29735.qmail@sources.redhat.com> (raw) The following reply was made to PR c++/5390; it has been noted by GNATS. From: DJ Delorie <dj@redhat.com> To: carlo@alinoe.com Cc: bangerth@dealii.org, gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org, nobody@gcc.gnu.org, gcc-gnats@gcc.gnu.org Subject: Re: c++/5390: Libiberty fails to demangle multi-digit template parameters. Date: Fri, 7 Mar 2003 12:18:18 -0500 Vlad reported a core dump. Nick fixed it with a small patch. You also wrote a significantly larger patch also claiming to fix it. You were asked if you tested on older gcc's to ensure backward compatibility. You said you didn't. The issue of backward compatibility was never resolved to my satisfaction, so I didn't approve it. I also noted that the demanglers are normally maintained by the C++ folks, but apparently you didn't convince them either. However, if you look in libiberty's ChangeLog, you'll see that your patch was eventually applied, over a year ago. So, I'm not sure what you're complaining about. 2002-02-18 Carlo Wood <carlo@gnu.org> PR c++/5390 * cplus-dem.c (demangle_integral_value): Accept multi-digit numbers that do not start with an underscore; This is needed for integer template parameters. This doesn't break anything because multi-digit numbers are never followed by a digit. * testsuite/demangle-expected: Corrected all mangled test cases with multi-digit template parameters: g++ 2.95.x does not generate underscores around these parameters.
next reply other threads:[~2003-03-07 17:26 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2003-03-07 17:26 DJ Delorie [this message] -- strict thread matches above, loose matches on Subject: below -- 2003-03-11 20:06 Wolfgang Bangerth 2003-03-11 20:06 DJ Delorie 2003-03-11 2:26 Carlo Wood 2003-03-10 21:06 Wolfgang Bangerth 2003-03-07 23:16 Carlo Wood 2003-03-07 16:06 Wolfgang Bangerth 2003-03-07 12:36 Carlo Wood 2003-03-07 2:26 bangerth
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20030307172601.29735.qmail@sources.redhat.com \ --to=dj@redhat.com \ --cc=gcc-prs@gcc.gnu.org \ --cc=nobody@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).