Re: libobjc/8562: minor bugs in runtime installed header files

Re: libobjc/8562: minor bugs in runtime installed header files

[ljrittle]

Synopsis: minor bugs in runtime installed header files

Responsible-Changed-From-To: unassigned->ljrittle
Responsible-Changed-By: ljrittle
Responsible-Changed-When: Wed Mar 26 07:59:42 2003
Responsible-Changed-Why:
    Mine (only because it had FreeBSD in it).
State-Changed-From-To: open->closed
State-Changed-By: ljrittle
State-Changed-When: Wed Mar 26 07:59:42 2003
State-Changed-Why:
    This patch looks fine to me David.  I will post it to gcc-patches@gcc.gnu.org (CC'ing you) in the proper form for review by the [lib]objc maintainers.  Here is a test case (we normally like them in addition to patches and I will include it):
    #include <objc/hash.h>
    #include <objc/objc-list.h>
    Add this flag to see the problem when installed from FSF tree: -Wsystem-headers
    FYI, I'm closing this PR before commit since strictly speaking this
    problem only appears to affect non-FSF installs.  I will include
    some commentary with the patch.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=8562

libobjc/8562: minor bugs in runtime installed header files

[davidc]

>Number:         8562
>Category:       libobjc
>Synopsis:       minor bugs in runtime installed header files
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Nov 13 10:46:04 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Chad David
>Release:        gcc version 3.2.1 [FreeBSD] 20021009 (prerelease)
>Organization:
>Environment:
FreeBSD 5.0-CURRENT FreeBSD 5.0-CURRENT #5: Fri Nov  1
i386
>Description:
objc/hash.h, objc/objc-list.h contain code that is not strictly correct.

hash.h - discards const on line 177 and 178
hash.h - uses subtraction with void * on line 190

objc-list.h - uses parameter name (index) that shadows index(3) from
                    strings.h (POSIX.1) on line 67.
>How-To-Repeat:
Compile any ObjC program that includes objc/hash.h or objc/objc-list.h
with the following warning options:

-Wpointer-arith -Wcast-qual -Wstrict-prototypes -Wshadow
>Fix:
Apply the attached patch.
>Release-Note:
>Audit-Trail:
>Unformatted:
----gnatsweb-attachment----
Content-Type: application/octet-stream; name="objc_r.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="objc_r.patch"

SW5kZXg6IGhhc2guaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3Zzcm9vdC9nY2MvZ2NjL2xpYm9i
amMvb2JqYy9oYXNoLmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNApkaWZmIC11IC1kIC1yMS40
IGhhc2guaAotLS0gaGFzaC5oCTIgSnVsIDIwMDIgMTk6NDM6MDIgLTAwMDAJMS40CisrKyBoYXNo
LmgJMTMgTm92IDIwMDIgMTg6NDE6MDAgLTAwMDAKQEAgLTE3NCw4ICsxNzQsOCBAQAogICB1bnNp
Z25lZCBpbnQgY3RyID0gMDsKICAgICAgICAgCiAgICAgICAgIAotICB3aGlsZSAoKihjaGFyICop
IGtleSkgewotICAgIHJldCBePSAqKGNoYXIgKikga2V5KysgPDwgY3RyOworICB3aGlsZSAoKihj
b25zdCBjaGFyICopIGtleSkgeworICAgIHJldCBePSAqKChjb25zdCBjaGFyICopIGtleSkrKyA8
PCBjdHI7CiAgICAgY3RyID0gKGN0ciArIDEpICUgc2l6ZW9mICh2b2lkICopOwogICB9CiAKQEAg
LTE4Nyw3ICsxODcsNyBAQAogc3RhdGljIGlubGluZSBpbnQgCiBjb21wYXJlX3B0cnMgKGNvbnN0
IHZvaWQgKmsxLCBjb25zdCB2b2lkICprMikKIHsKLSAgcmV0dXJuICEgKGsxIC0gazIpOworICBy
ZXR1cm4gKGsxID09IGsyKTsKIH0KIAogCkluZGV4OiBvYmpjLWxpc3QuaAo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD
UyBmaWxlOiAvY3Zzcm9vdC9nY2MvZ2NjL2xpYm9iamMvb2JqYy9vYmpjLWxpc3QuaCx2CnJldHJp
ZXZpbmcgcmV2aXNpb24gMS4zCmRpZmYgLXUgLWQgLXIxLjMgb2JqYy1saXN0LmgKLS0tIG9iamMt
bGlzdC5oCTI5IE1hciAyMDAwIDIwOjE5OjA2IC0wMDAwCTEuMworKysgb2JqYy1saXN0LmgJMTMg
Tm92IDIwMDIgMTg6NDE6MDAgLTAwMDAKQEAgLTY0LDkgKzY0LDkgQEAKICAgIGxhcmdlciB0aGFu
IHRoZSBsaXN0IGxlbmd0aCwgTlVMTCBpcyByZXR1cm5lZCAgKi8KIAogc3RhdGljIGlubGluZSB2
b2lkKgotbGlzdF9udGgoaW50IGluZGV4LCBzdHJ1Y3Qgb2JqY19saXN0KiBsaXN0KQorbGlzdF9u
dGgoaW50IGluZHgsIHN0cnVjdCBvYmpjX2xpc3QqIGxpc3QpCiB7Ci0gIHdoaWxlKGluZGV4LS0g
IT0gMCkKKyAgd2hpbGUoaW5keC0tICE9IDApCiAgICAgewogICAgICAgaWYobGlzdC0+dGFpbCkK
IAlsaXN0ID0gbGlzdC0+dGFpbDsK