public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
* Re: preprocessor/8505: cross cpp0 use PREFIX_INCLUDE_DIR=$prefix/include
@ 2003-04-07 16:07 zack
0 siblings, 0 replies; 6+ messages in thread
From: zack @ 2003-04-07 16:07 UTC (permalink / raw)
To: benoit.poulot-cazajou, gcc-bugs, gcc-prs, stephane.carbillet, zack
Synopsis: cross cpp0 use PREFIX_INCLUDE_DIR=$prefix/include
State-Changed-From-To: open->closed
State-Changed-By: zack
State-Changed-When: Mon Apr 7 16:07:13 2003
State-Changed-Why:
Requested change has been made already in 3.4.
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=8505
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: preprocessor/8505: cross cpp0 use PREFIX_INCLUDE_DIR=$prefix/include
@ 2003-04-07 16:16 Zack Weinberg
0 siblings, 0 replies; 6+ messages in thread
From: Zack Weinberg @ 2003-04-07 16:16 UTC (permalink / raw)
To: zack; +Cc: gcc-prs
The following reply was made to PR preprocessor/8505; it has been noted by GNATS.
From: Zack Weinberg <zack@codesourcery.com>
To: benoit.poulot-cazajou@jaluna.com
Cc: stephane.carbillet@jaluna.com, gcc-gnats@gcc.gnu.org,
gcc-bugs@gcc.gnu.org
Subject: Re: preprocessor/8505: cross cpp0 use
PREFIX_INCLUDE_DIR=$prefix/include
Date: Mon, 07 Apr 2003 09:05:55 -0700
Daniel Jacobowitz <drow@mvista.com> writes:
>>
>> I would appreciate opinions. Dan, I'm cc:ing you because you've had
>> your fingers in this area recently.
>
> If you look at 3.4, you'll see the test has changed:
> if test x$with_sysroot = x && test x$host = x$target \
> && test "$prefix" != "/usr" && test "x$prefix" != "x$local_prefix" ; then
> AC_DEFINE_UNQUOTED(PREFIX_INCLUDE_DIR, "$prefix/include")
> fi
>
> i.e. cross compilers no longer search $prefix/include/. I'm sre it'll
> break someone's setup somewhere; however, it also just makes more sense
> this way.
Ah, ok, I will close the PR then.
zw
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: preprocessor/8505: cross cpp0 use PREFIX_INCLUDE_DIR=$prefix/include
@ 2003-04-07 13:16 Daniel Jacobowitz
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Jacobowitz @ 2003-04-07 13:16 UTC (permalink / raw)
To: zack; +Cc: gcc-prs
The following reply was made to PR preprocessor/8505; it has been noted by GNATS.
From: Daniel Jacobowitz <drow@mvista.com>
To: Zack Weinberg <zack@codesourcery.com>
Cc: benoit.poulot-cazajou@jaluna.com, stephane.carbillet@jaluna.com,
gcc-gnats@gcc.gnu.org, gcc-bugs@gcc.gnu.org
Subject: Re: preprocessor/8505: cross cpp0 use PREFIX_INCLUDE_DIR=$prefix/include
Date: Mon, 7 Apr 2003 09:09:51 -0400
On Thu, Apr 03, 2003 at 05:05:20PM -0800, Zack Weinberg wrote:
>
> [http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=8505]
>
> My apologies for letting this go for so long.
>
> I am not expert in the domain of cross compilers, and I can think of
> plausible reasons both to have the PREFIX_INCLUDE_DIR searched and
> not to have it searched. It would be consistent with what is done
> for other directories, like LOCAL_INCLUDE_DIR, not to search it;
> however, it appears that this directory has been searched in cross
> compilers since forever, so people might be depending on the existing
> behavior.
>
> I would appreciate opinions. Dan, I'm cc:ing you because you've had
> your fingers in this area recently.
If you look at 3.4, you'll see the test has changed:
if test x$with_sysroot = x && test x$host = x$target \
&& test "$prefix" != "/usr" && test "x$prefix" != "x$local_prefix" ; then
AC_DEFINE_UNQUOTED(PREFIX_INCLUDE_DIR, "$prefix/include")
fi
i.e. cross compilers no longer search $prefix/include/. I'm sre it'll
break someone's setup somewhere; however, it also just makes more sense
this way.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: preprocessor/8505: cross cpp0 use PREFIX_INCLUDE_DIR=$prefix/include
@ 2003-04-04 1:06 Zack Weinberg
0 siblings, 0 replies; 6+ messages in thread
From: Zack Weinberg @ 2003-04-04 1:06 UTC (permalink / raw)
To: zack; +Cc: gcc-prs
The following reply was made to PR preprocessor/8505; it has been noted by GNATS.
From: Zack Weinberg <zack@codesourcery.com>
To: benoit.poulot-cazajou@jaluna.com, stephane.carbillet@jaluna.com,
drow@mvista.com
Cc: gcc-gnats@gcc.gnu.org, gcc-bugs@gcc.gnu.org
Subject: Re: preprocessor/8505: cross cpp0 use
PREFIX_INCLUDE_DIR=$prefix/include
Date: Thu, 03 Apr 2003 17:05:20 -0800
[http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=8505]
My apologies for letting this go for so long.
I am not expert in the domain of cross compilers, and I can think of
plausible reasons both to have the PREFIX_INCLUDE_DIR searched and
not to have it searched. It would be consistent with what is done
for other directories, like LOCAL_INCLUDE_DIR, not to search it;
however, it appears that this directory has been searched in cross
compilers since forever, so people might be depending on the existing
behavior.
I would appreciate opinions. Dan, I'm cc:ing you because you've had
your fingers in this area recently.
zw
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: preprocessor/8505: cross cpp0 use PREFIX_INCLUDE_DIR=$prefix/include
@ 2002-11-08 15:29 neil
0 siblings, 0 replies; 6+ messages in thread
From: neil @ 2002-11-08 15:29 UTC (permalink / raw)
To: benoit.poulot-cazajou, gcc-bugs, gcc-prs, nobody,
stephane.carbillet, zack
Synopsis: cross cpp0 use PREFIX_INCLUDE_DIR=$prefix/include
Responsible-Changed-From-To: unassigned->zack
Responsible-Changed-By: neil
Responsible-Changed-When: Fri Nov 8 15:29:04 2002
Responsible-Changed-Why:
Zack, I trust your judgement on this more than mine. D'you mind taking a look?
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=8505
^ permalink raw reply [flat|nested] 6+ messages in thread
* preprocessor/8505: cross cpp0 use PREFIX_INCLUDE_DIR=$prefix/include
@ 2002-11-08 6:46 stephane.carbillet
0 siblings, 0 replies; 6+ messages in thread
From: stephane.carbillet @ 2002-11-08 6:46 UTC (permalink / raw)
To: gcc-gnats; +Cc: benoit.poulot-cazajou
>Number: 8505
>Category: preprocessor
>Synopsis: cross cpp0 use PREFIX_INCLUDE_DIR=$prefix/include
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: unassigned
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri Nov 08 06:46:03 PST 2002
>Closed-Date:
>Last-Modified:
>Originator: stephane.carbillet@jaluna.com
>Release: gcc3.2
>Organization:
>Environment:
redhat 7.3
>Description:
I first build a native gcc with prefix :
/home/scarbill/buildLDS/build-LDS/Dist
Then I build a cross gcc with command :
/home/scarbill/buildLDS/build-LDS/Src/GCC/configure --host=i686-pc-linux-gnu
--prefix=/home/scarbill/buildLDS/build-LDS/Dist --target=powerpc-linux --with-he
aders=/home/scarbill/buildLDS/build-LDS/Cross/glibc/powerpc-linux/include --with
-libs=/home/scarbill/buildLDS/build-LDS/Cross/glibc/powerpc-linux/lib --enable-l
anguages=c,c++
The build fails with message :
/home/scarbill/buildLDS/build-LDS/Build/GCC-phaseB-powerpc-linux/gcc/xgcc
-B/home/scarbill/buildLDS/build-LDS/Build/GCC-phaseB-powerpc-linux/gcc/
-B/home/scarbill/buildLDS/build-LDS/Dist/powerpc-linux/bin/
-B/home/scarbill/buildLDS/build-LDS/Dist/powerpc-linux/lib/ -isystem
/home/scarbill/buildLDS/build-LDS/Dist/powerpc-linux/include -c
-DHAVE_CONFIG_H -g -O2 -I.
-I/home/scarbill/buildLDS/build-LDS/Src/GCC/libiberty/../include -W
-Wall -Wtraditional -pedantic
/home/scarbill/buildLDS/build-LDS/Src/GCC/libiberty/floatformat.c
/home/scarbill/buildLDS/build-LDS/Src/GCC/libiberty/floatformat.c: In
function `floatformat_to_double':
/home/scarbill/buildLDS/build-LDS/Dist/include/bits/mathinline.h:524:
inconsistent operand constraints in an `asm'
..........
The file "/home/scarbill/buildLDS/build-LDS/Dist/include/bits/mathinline.h" is intel specific.
>How-To-Repeat:
Make a native gcc and after a cross gcc with the same prefix.
>Fix:
diff -ru gcc-3.2-old/gcc/configure GCC/gcc/configure
--- gcc-3.2-old/gcc/configure Sat Jun 29 02:20:11 2002
+++ GCC/gcc/configure Thu Nov 7 19:29:09 2002
@@ -7892,7 +7892,7 @@
fi
-if test "$prefix" != "/usr" && test "$prefix" != "/usr/local" ; then
+if test "$prefix" != "/usr" && test "$prefix" != "/usr/local" && test "$cross_compiling" = yes ; then
cat >> confdefs.h <<EOF
#define PREFIX_INCLUDE_DIR "$prefix/include"
EOF
>Release-Note:
>Audit-Trail:
>Unformatted:
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-04-07 16:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-07 16:07 preprocessor/8505: cross cpp0 use PREFIX_INCLUDE_DIR=$prefix/include zack
-- strict thread matches above, loose matches on Subject: below --
2003-04-07 16:16 Zack Weinberg
2003-04-07 13:16 Daniel Jacobowitz
2003-04-04 1:06 Zack Weinberg
2002-11-08 15:29 neil
2002-11-08 6:46 stephane.carbillet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).