public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
* Re: other/9274: [pch] cannot create libstdc++-v3 pch
@ 2003-04-15 15:46 Benjamin Kosnik
0 siblings, 0 replies; 11+ messages in thread
From: Benjamin Kosnik @ 2003-04-15 15:46 UTC (permalink / raw)
To: geoffk; +Cc: gcc-prs
The following reply was made to PR other/9274; it has been noted by GNATS.
From: Benjamin Kosnik <bkoz@redhat.com>
To: Geoff Keating <geoffk@geoffk.org>
Cc: bkoz@gcc.gnu.org, gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org,
geoffk@gcc.gnu.org, geoffk@geoffk.org, jason@redhat.com, pcarlini@unitus.it,
gcc-gnats@gcc.gnu.org
Subject: Re: other/9274: [pch] cannot create libstdc++-v3 pch
Date: Tue, 15 Apr 2003 10:39:48 -0500
>The original reported bug does work on Darwin, as does running
>make-check-target-libstdc++-v3 after running make
>stamp-stdc++-precompile. Of course, Darwin doesn't use DWARF2.
With this patch, things now work on linux. Thanks for your help.
>This patch might help. Try it and see what happens.
Indeed, it does. Can you check it in please?
>===File ~/patches/apple/gcc-pchdecluid.patch================
>*** tree.c.~1.295.~ Fri Apr 11 19:01:38 2003
>--- tree.c Mon Apr 14 14:56:53 2003
>***************
>*** 92,100 ****
> #endif /* GATHER_STATISTICS */
>
> /* Unique id for next decl created. */
>! static int next_decl_uid;
> /* Unique id for next type created. */
>! static int next_type_uid = 1;
>
> /* Since we cannot rehash a type after it is in the table, we have to
> keep the hash code. */
>--- 92,100 ----
> #endif /* GATHER_STATISTICS */
>
> /* Unique id for next decl created. */
>! static GTY(()) int next_decl_uid;
> /* Unique id for next type created. */
>! static GTY(()) int next_type_uid = 1;
>
> /* Since we cannot rehash a type after it is in the table, we have to
> keep the hash code. */
>============================================================
-benjamin
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: other/9274: [pch] cannot create libstdc++-v3 pch
@ 2003-04-16 0:30 geoffk
0 siblings, 0 replies; 11+ messages in thread
From: geoffk @ 2003-04-16 0:30 UTC (permalink / raw)
To: bkoz, gcc-bugs, gcc-prs, geoffk, geoffk, jason, pcarlini
Synopsis: [pch] cannot create libstdc++-v3 pch
State-Changed-From-To: open->closed
State-Changed-By: geoffk
State-Changed-When: Wed Apr 16 00:30:03 2003
State-Changed-Why:
Fixed.
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=9274
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: other/9274: [pch] cannot create libstdc++-v3 pch
@ 2003-04-15 22:56 Paolo Carlini
0 siblings, 0 replies; 11+ messages in thread
From: Paolo Carlini @ 2003-04-15 22:56 UTC (permalink / raw)
To: geoffk; +Cc: gcc-prs
The following reply was made to PR other/9274; it has been noted by GNATS.
From: Paolo Carlini <pcarlini@unitus.it>
To: Benjamin Kosnik <bkoz@redhat.com>
Cc: Geoff Keating <geoffk@geoffk.org>, bkoz@gcc.gnu.org,
gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org, jason@redhat.com,
gcc-gnats@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: other/9274: [pch] cannot create libstdc++-v3 pch
Date: Wed, 16 Apr 2003 00:48:42 +0200
Benjamin Kosnik wrote:
>Great. Shall I close this PR?
>
Why not?
Paolo.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: other/9274: [pch] cannot create libstdc++-v3 pch
@ 2003-04-15 22:46 Benjamin Kosnik
0 siblings, 0 replies; 11+ messages in thread
From: Benjamin Kosnik @ 2003-04-15 22:46 UTC (permalink / raw)
To: geoffk; +Cc: gcc-prs
The following reply was made to PR other/9274; it has been noted by GNATS.
From: Benjamin Kosnik <bkoz@redhat.com>
To: Geoff Keating <geoffk@geoffk.org>
Cc: bkoz@gcc.gnu.org, gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org,
jason@redhat.com, pcarlini@unitus.it, gcc-gnats@gcc.gnu.org,
gcc-patches@gcc.gnu.org
Subject: Re: other/9274: [pch] cannot create libstdc++-v3 pch
Date: Tue, 15 Apr 2003 17:39:18 -0500
Great. Shall I close this PR?
-benjamin
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: other/9274: [pch] cannot create libstdc++-v3 pch
@ 2003-04-15 20:56 Geoff Keating
0 siblings, 0 replies; 11+ messages in thread
From: Geoff Keating @ 2003-04-15 20:56 UTC (permalink / raw)
To: geoffk; +Cc: gcc-prs
The following reply was made to PR other/9274; it has been noted by GNATS.
From: Geoff Keating <geoffk@geoffk.org>
To: bkoz@redhat.com
Cc: bkoz@gcc.gnu.org, gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org,
jason@redhat.com, pcarlini@unitus.it, gcc-gnats@gcc.gnu.org,
gcc-patches@gcc.gnu.org
Subject: Re: other/9274: [pch] cannot create libstdc++-v3 pch
Date: Tue, 15 Apr 2003 13:46:48 -0700
> Date: Tue, 15 Apr 2003 10:39:48 -0500
> From: Benjamin Kosnik <bkoz@redhat.com>
> >The original reported bug does work on Darwin, as does running
> >make-check-target-libstdc++-v3 after running make
> >stamp-stdc++-precompile. Of course, Darwin doesn't use DWARF2.
>
> With this patch, things now work on linux. Thanks for your help.
>
> >This patch might help. Try it and see what happens.
>
> Indeed, it does. Can you check it in please?
Done, with this ChangeLog:
2003-04-15 Geoffrey Keating <geoffk@apple.com>
* tree.c (next_decl_uid): Mark with GTY.
(next_type_uid): Likewise.
> >===File ~/patches/apple/gcc-pchdecluid.patch================
> >*** tree.c.~1.295.~ Fri Apr 11 19:01:38 2003
> >--- tree.c Mon Apr 14 14:56:53 2003
> >***************
> >*** 92,100 ****
> > #endif /* GATHER_STATISTICS */
> >
> > /* Unique id for next decl created. */
> >! static int next_decl_uid;
> > /* Unique id for next type created. */
> >! static int next_type_uid = 1;
> >
> > /* Since we cannot rehash a type after it is in the table, we have to
> > keep the hash code. */
> >--- 92,100 ----
> > #endif /* GATHER_STATISTICS */
> >
> > /* Unique id for next decl created. */
> >! static GTY(()) int next_decl_uid;
> > /* Unique id for next type created. */
> >! static GTY(()) int next_type_uid = 1;
> >
> > /* Since we cannot rehash a type after it is in the table, we have to
> > keep the hash code. */
> >============================================================
--
- Geoffrey Keating <geoffk@geoffk.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: other/9274: [pch] cannot create libstdc++-v3 pch
@ 2003-04-14 22:06 Geoff Keating
0 siblings, 0 replies; 11+ messages in thread
From: Geoff Keating @ 2003-04-14 22:06 UTC (permalink / raw)
To: geoffk; +Cc: gcc-prs
The following reply was made to PR other/9274; it has been noted by GNATS.
From: Geoff Keating <geoffk@geoffk.org>
To: bkoz@gcc.gnu.org, bkoz@redhat.com, gcc-bugs@gcc.gnu.org,
gcc-prs@gcc.gnu.org, geoffk@gcc.gnu.org, geoffk@geoffk.org,
jason@redhat.com, pcarlini@unitus.it, gcc-gnats@gcc.gnu.org
Cc: bkoz@redhat.com, gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org,
geoffk@geoffk.org, jason@redhat.com, pcarlini@unitus.it
Subject: Re: other/9274: [pch] cannot create libstdc++-v3 pch
Date: Mon, 14 Apr 2003 15:02:15 -0700
The original reported bug does work on Darwin, as does running
make-check-target-libstdc++-v3 after running make
stamp-stdc++-precompile. Of course, Darwin doesn't use DWARF2.
This patch might help. Try it and see what happens.
--
- Geoffrey Keating <geoffk@geoffk.org>
===File ~/patches/apple/gcc-pchdecluid.patch================
*** tree.c.~1.295.~ Fri Apr 11 19:01:38 2003
--- tree.c Mon Apr 14 14:56:53 2003
***************
*** 92,100 ****
#endif /* GATHER_STATISTICS */
/* Unique id for next decl created. */
! static int next_decl_uid;
/* Unique id for next type created. */
! static int next_type_uid = 1;
/* Since we cannot rehash a type after it is in the table, we have to
keep the hash code. */
--- 92,100 ----
#endif /* GATHER_STATISTICS */
/* Unique id for next decl created. */
! static GTY(()) int next_decl_uid;
/* Unique id for next type created. */
! static GTY(()) int next_type_uid = 1;
/* Since we cannot rehash a type after it is in the table, we have to
keep the hash code. */
============================================================
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: other/9274: [pch] cannot create libstdc++-v3 pch
@ 2003-04-14 19:16 bkoz
0 siblings, 0 replies; 11+ messages in thread
From: bkoz @ 2003-04-14 19:16 UTC (permalink / raw)
To: bkoz, gcc-bugs, gcc-prs, geoffk, geoffk, jason, pcarlini
Synopsis: [pch] cannot create libstdc++-v3 pch
State-Changed-From-To: analyzed->open
State-Changed-By: bkoz
State-Changed-When: Mon Apr 14 19:16:24 2003
State-Changed-Why:
I've re-tested this with:
xgcc (GCC) 3.4 20030413 (experimental)
And am still seeing the failure reported previously.
/mnt/hd/src/gcc/libstdc++-v3/testsuite/22_locale/money_get/get/char/wrapped_env.cc:71: internal compiler error: in gen_subprogram_die, at dwarf2out.c:10899
Please submit a full bug report,
with preprocessed source if appropriate
So. I've attached the precompiled includes with this email, but I'm not quite sure if this still is useful, with PCH on.
-benjamin
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=9274
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: other/9274: [pch] cannot create libstdc++-v3 pch
@ 2003-04-10 21:51 bkoz
0 siblings, 0 replies; 11+ messages in thread
From: bkoz @ 2003-04-10 21:51 UTC (permalink / raw)
To: bkoz, gcc-bugs, gcc-prs, geoffk, geoffk, jason, pcarlini
Synopsis: [pch] cannot create libstdc++-v3 pch
State-Changed-From-To: open->analyzed
State-Changed-By: bkoz
State-Changed-When: Thu Apr 10 21:51:14 2003
State-Changed-Why:
This still isn't fixed, contrary to current check ins.
On x86-linux, with pch enabled, on gcc-2003-04-10 I get:
=== libstdc++-v3 Summary ===
# of expected passes 1650
# of unexpected failures 52
# of unexpected successes 1
# of expected failures 1
where the fails looks like this:
Executing on host: /mnt/hd/bld/gcc/gcc/g++ -shared-libgcc -B/mnt/hd/bld/gcc/gcc/ -nostdinc++ -L/mnt/hd/bld/gcc/i686-pc-linux-gnu/libstdc++-v3/src -L/mnt/hd/bld/gcc/i686-pc-linux-gnu/libstdc++-v3/src/.libs -B/mnt/hd/bld/H-x86-gcc/i686-pc-linux-gnu/bin/ -B/mnt/hd/bld/H-x86-gcc/i686-pc-linux-gnu/lib/ -isystem /mnt/hd/bld/H-x86-gcc/i686-pc-linux-gnu/include -isystem /mnt/hd/bld/H-x86-gcc/i686-pc-linux-gnu/sys-include -Winvalid-pch -include /mnt/hd/bld/gcc/i686-pc-linux-gnu/libstdc++-v3/include/stdc++.h -g -O2 -ffunction-sections -fdata-sections -fmessage-length=0 -DLOCALEDIR="/mnt/hd/bld/gcc/i686-pc-linux-gnu/libstdc++-v3/po/share/locale" -nostdinc++ -I/mnt/hd/bld/gcc/i686-pc-linux-gnu/libstdc++-v3/include/i686-pc-linux-gnu -I/mnt/hd/bld/gcc/i686-pc-linux-gnu/libstdc++-v3/include -I/mnt/hd/src/gcc/libstdc++-v3/libsupc++ -I/mnt/hd/src/gcc/libstdc++-v3/libio -I/mnt/hd/src/gcc/libstdc++-v3/include/backward -I/mnt/hd/src/gcc/libstdc++-v3/testsuite /mnt/hd/src/gcc/libstdc++-v3/testsuite/22_locale/money_get/get/char/wrapped_env.cc -DDEBUG_ASSERT -L/mnt/hd/bld/gcc/i686-pc-linux-gnu//libstdc++-v3/testsuite -lv3test -lm -o ./wrapped_env.exe (timeout = 300)
/mnt/hd/src/gcc/libstdc++-v3/testsuite/22_locale/money_get/get/char/wrapped_env.cc: In member function `void std::_STL_mutex_lock::_M_release_lock()':
/mnt/hd/src/gcc/libstdc++-v3/testsuite/22_locale/money_get/get/char/wrapped_env.cc:71: internal compiler error: in gen_subprogram_die, at dwarf2out.c:10899
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.
compiler exited with status 1
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=9274
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: other/9274: [pch] cannot create libstdc++-v3 pch
@ 2003-03-25 18:06 bkoz
0 siblings, 0 replies; 11+ messages in thread
From: bkoz @ 2003-03-25 18:06 UTC (permalink / raw)
To: bkoz, gcc-bugs, gcc-prs, geoffk, geoffk, jason, pcarlini
Synopsis: [pch] cannot create libstdc++-v3 pch
State-Changed-From-To: analyzed->open
State-Changed-By: bkoz
State-Changed-When: Tue Mar 25 17:27:22 2003
State-Changed-Why:
Ping. This is still an issue with gcc-20030325. Jason, have you had a chance to look at this? Again, here's the patch to mainline to auto-gen the pch and use it in the testsuite run.
2003-03-27 Benjamin Kosnik <bkoz@redhat.com>
* include/Makefile.am (allstamps): Add stamp-stdc++-precompile.
(stamp-std-precompile): Generate stdc++.h.gch
(install-data-local): Install generated file.
* include/Makefile.in: Regenerate.
* testsuite_flags.in (--cxxflags): Put -g -O2 here.
Index: testsuite_flags.in
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/testsuite_flags.in,v
retrieving revision 1.14
diff -c -p -r1.14 testsuite_flags.in
*** testsuite_flags.in 14 Mar 2003 22:17:26 -0000 1.14
--- testsuite_flags.in 18 Mar 2003 02:51:57 -0000
*************** case ${query} in
*** 44,50 ****
;;
--build-cxx)
PCHFLAGS="-Winvalid-pch -include ${BUILD_DIR}/include/stdc++.h"
! CC_build="@glibcpp_CXX@"
CXX=`echo $CC_build | sed 's/xgcc/g++/g'`
echo ${CXX}
;;
--- 44,50 ----
;;
--build-cxx)
PCHFLAGS="-Winvalid-pch -include ${BUILD_DIR}/include/stdc++.h"
! CC_build="@glibcpp_CXX@ ${PCHFLAGS}"
CXX=`echo $CC_build | sed 's/xgcc/g++/g'`
echo ${CXX}
;;
Index: include/Makefile.am
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/include/Makefile.am,v
retrieving revision 1.54
diff -c -p -r1.54 Makefile.am
*** include/Makefile.am 14 Mar 2003 22:16:05 -0000 1.54
--- include/Makefile.am 18 Mar 2003 02:51:59 -0000
*************** pch_source = ${glibcpp_srcdir}/include/$
*** 348,354 ****
# CLEANFILES and all-local are kept up-to-date.
allstamps = \
stamp-std stamp-bits stamp-c_base stamp-c_compatibility \
! stamp-backward stamp-ext stamp-target
# Here are the rules for building the headers
all-local: ${target_builddir}/c++config.h ${thread_target_headers} ${allstamps}
--- 348,354 ----
# CLEANFILES and all-local are kept up-to-date.
allstamps = \
stamp-std stamp-bits stamp-c_base stamp-c_compatibility \
! stamp-backward stamp-ext stamp-target stamp-stdc++-precompile
# Here are the rules for building the headers
all-local: ${target_builddir}/c++config.h ${thread_target_headers} ${allstamps}
*************** install-data-local:
*** 524,529 ****
--- 524,530 ----
$(mkinstalldirs) $(DESTDIR)${gxx_include_dir}/${std_builddir}
for file in ${std_headers_rename}; do \
$(INSTALL_DATA) ${std_builddir}/$${file} $(DESTDIR)${gxx_include_dir}/${std_builddir}; done
+ $(INSTALL_DATA) ${std_builddir}/${pch_output} $(DESTDIR)${gxx_include_dir}/${std_builddir}
$(mkinstalldirs) $(DESTDIR)${gxx_include_dir}/${target_builddir}
for file in ${target_headers} ${target_headers_extra} \
${thread_target_headers}; do \
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=9274
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: other/9274: [pch] cannot create libstdc++-v3 pch
@ 2003-02-22 0:46 Geoffrey Keating
0 siblings, 0 replies; 11+ messages in thread
From: Geoffrey Keating @ 2003-02-22 0:46 UTC (permalink / raw)
To: geoffk; +Cc: gcc-prs
The following reply was made to PR other/9274; it has been noted by GNATS.
From: Geoffrey Keating <geoffk@apple.com>
To: bkoz@redhat.com, gcc-gnats@gcc.gnu.org, geoffk@geoffk.org,
geoffk@gcc.gnu.org, gcc-bugs@gcc.gnu.org, pcarlini@unitus.it
Cc:
Subject: Re: other/9274: [pch] cannot create libstdc++-v3 pch
Date: Fri, 21 Feb 2003 16:42:01 -0800
I've confirmed that this problem still exists, at least partly. On
Darwin, test1.cc prints:
ld: Undefined symbols:
std::basic_ostream<char, std::char_traits<char>
>::operator<<(std::basic_ostream<char, std::char_traits<char> >&
(*)(std::basic_ostream<char, std::char_traits<char> >&))
and test2.cc prints:
ld: Undefined symbols:
std::basic_string<char, std::char_traits<char>, std::allocator<char>
>::basic_string[in-charge](char const*, std::allocator<char> const&)
std::basic_string<char, std::char_traits<char>, std::allocator<char>
>::~basic_string [in-charge]()
std::allocator<char>::allocator[in-charge]()
std::allocator<char>::~allocator [in-charge]()
std::basic_ostream<char, std::char_traits<char> >& std::operator<<
<char, std::char_traits<char>, std::allocator<char>
>(std::basic_ostream<char, std::char_traits<char> >&,
std::basic_string<char, std::char_traits<char>, std::allocator<char> >
const&)
This is an improvement, but it's not quite working yet.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: other/9274: [pch] cannot create libstdc++-v3 pch
@ 2003-02-06 21:25 bkoz
0 siblings, 0 replies; 11+ messages in thread
From: bkoz @ 2003-02-06 21:25 UTC (permalink / raw)
To: bkoz, gcc-bugs, gcc-prs, geoffk, geoffk, nobody, pcarlini
Old Synopsis: [pch] inline template functions do not work with pch [pch + libstdc++-v3]
New Synopsis: [pch] cannot create libstdc++-v3 pch
Responsible-Changed-From-To: unassigned->geoffk
Responsible-Changed-By: bkoz
Responsible-Changed-When: Thu Feb 6 21:25:23 2003
Responsible-Changed-Why:
Yours.
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=9274
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2003-04-16 0:30 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-15 15:46 other/9274: [pch] cannot create libstdc++-v3 pch Benjamin Kosnik
-- strict thread matches above, loose matches on Subject: below --
2003-04-16 0:30 geoffk
2003-04-15 22:56 Paolo Carlini
2003-04-15 22:46 Benjamin Kosnik
2003-04-15 20:56 Geoff Keating
2003-04-14 22:06 Geoff Keating
2003-04-14 19:16 bkoz
2003-04-10 21:51 bkoz
2003-03-25 18:06 bkoz
2003-02-22 0:46 Geoffrey Keating
2003-02-06 21:25 bkoz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).