c/10604

c/10604

[zack]

The following reply was made to PR c/10604; it has been noted by GNATS.

From: zack@gcc.gnu.org
To: gcc-gnats@gcc.gnu.org
Cc:  
Subject: c/10604
Date: 3 May 2003 00:18:53 -0000

 CVSROOT:	/cvs/gcc
 Module name:	gcc
 Branch: 	gcc-3_3-branch
 Changes by:	zack@gcc.gnu.org	2003-05-03 00:18:53
 
 Modified files:
 	gcc            : ChangeLog c-opts.c 
 	gcc/doc        : invoke.texi 
 	gcc/testsuite  : ChangeLog 
 Added files:
 	gcc/testsuite/g++.dg/warn: compare1.C 
 	gcc/testsuite/gcc.dg: compare7.c 
 
 Log message:
 	PR c/10604
 	* c-opts.c (c_common_decode_option <OPT_Wall>): Set
 	warn_sign_compare for C++ only.
 	* doc/invoke.texi: Clarify documentation of -Wsign-compare.
 	* gcc.dg/compare7.c, g++.dg/warn/compare1.C: New testcases.
 
 Patches:
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.16114.2.503&r2=1.16114.2.504
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-opts.c.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.24.6.1&r2=1.24.6.2
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/invoke.texi.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.209.2.27&r2=1.209.2.28
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.2261.2.164&r2=1.2261.2.165
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/warn/compare1.C.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=NONE&r2=1.1.2.1
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/compare7.c.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=NONE&r2=1.1.2.1
 

c/10604

[zack]

The following reply was made to PR c/10604; it has been noted by GNATS.

From: zack@gcc.gnu.org
To: gcc-gnats@gcc.gnu.org
Cc:  
Subject: c/10604
Date: 3 May 2003 21:44:31 -0000

 CVSROOT:	/cvs/gcc
 Module name:	gcc
 Changes by:	zack@gcc.gnu.org	2003-05-03 21:44:31
 
 Modified files:
 	gcc            : ChangeLog Makefile.in c-common.c c-opts.c 
 	                 c-typeck.c function.c stmt.c toplev.c 
 	gcc/cp         : ChangeLog typeck.c 
 	gcc/testsuite  : ChangeLog 
 Added files:
 	gcc/testsuite/g++.dg/warn: compare1.C 
 	gcc/testsuite/gcc.dg: compare7.c 
 
 Log message:
 	PR c/10604
 	
 	* c-common.c (warn_sign_compare): Initialize to -1.
 	* c-opts.c (c_common_init_options): Don't set warn_sign_compare here.
 	(c_common_decode_option <OPT_Wall>): Set warn_sign_compare
 	for C++ only.
 	(c_common_post_options): Set warn_sign_compare from extra_warnings
 	if it's still -1 at this point.
 	
 	* toplev.c (maybe_warn_unused_parameter): New static variable.
 	(set_Wextra): New static function.
 	(W_options): Remove "extra".
 	(decode_W_option): Call set_Wextra.
 	(independent_decode_option): Likewise.
 	(set_Wunused): Cooperate with set_Wextra in setting
 	warn_unused_parameter.
 	(rest_of_compilation): No need to check extra_warnings as
 	well as warn_uninitialized.
 	
 	* c-typeck.c (build_binary_op, build_conditional_expr):
 	No need to check extra_warnings as well as warn_sign_compare.
 	(internal_build_compound_expr): No need to check extra_warnings
 	as well as warn_unused_value.
 	* function.c (expand_function_end): No need to check extra_warnings
 	as well as warn_unused_parameter.
 	* stmt.c (expand_expr_stmt_value): No need to check extra_warnings
 	as well as warn_unused_value.
 	* cp/typeck.c (build_x_compound_expr): No need to check
 	extra_warnings as well as warn_unused_value.
 	
 	* doc/invoke.texi: Clarify documentation of -Wsign-compare.
 	* gcc.dg/compare7.c, g++.dg/warn/compare1.C: New testcases.
 	
 	* Makefile.in: Disable -Werror for gengtype-lex.o.
 
 Patches:
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=1.17678&r2=1.17679
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/Makefile.in.diff?cvsroot=gcc&r1=1.1046&r2=1.1047
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-common.c.diff?cvsroot=gcc&r1=1.413&r2=1.414
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-opts.c.diff?cvsroot=gcc&r1=1.41&r2=1.42
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-typeck.c.diff?cvsroot=gcc&r1=1.235&r2=1.236
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/function.c.diff?cvsroot=gcc&r1=1.423&r2=1.424
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/stmt.c.diff?cvsroot=gcc&r1=1.299&r2=1.300
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/toplev.c.diff?cvsroot=gcc&r1=1.750&r2=1.751
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.3361&r2=1.3362
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/typeck.c.diff?cvsroot=gcc&r1=1.457&r2=1.458
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.2646&r2=1.2647
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/warn/compare1.C.diff?cvsroot=gcc&r1=1.1&r2=1.2
 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/compare7.c.diff?cvsroot=gcc&r1=1.1&r2=1.2