Re: bootstrap/7087: sub-make FLAG propagation fails if flag ends with '='

Re: bootstrap/7087: sub-make FLAG propagation fails if flag ends with '='

[giovannibajo]

Synopsis: sub-make FLAG propagation fails if flag ends with '='

State-Changed-From-To: open->analyzed
State-Changed-By: bajo
State-Changed-When: Wed May 14 10:55:02 2003
State-Changed-Why:
    Confirmed in 3.3 and properly analyzed

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=7087

Re: bootstrap/7087: sub-make FLAG propagation fails if flag ends with '='

[scott douglass]

The following reply was made to PR bootstrap/7087; it has been noted by GNATS.

From: scott douglass <sdouglass@arm.com>
To: Dara Hazeghi <dhazeghi@yahoo.com>
Cc: gcc-gnats@gcc.gnu.org, nobody@gcc.gnu.org
Subject: Re: bootstrap/7087: sub-make FLAG propagation fails if flag ends
 with '='
Date: Wed, 14 May 2003 10:32:45 +0100

 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=7087
 
 Dara Hazeghi wrote:
 > could the submitter please determine if this problem occurs with  
 > current gcc sources? Thanks,
 
 I have examined the top-level Makefile.in of the 3.2.3 distribution of gcc.  The problem is still there.
 

Re: bootstrap/7087: sub-make FLAG propagation fails if flag ends with '='

[Dara Hazeghi]

The following reply was made to PR bootstrap/7087; it has been noted by GNATS.

From: Dara Hazeghi <dhazeghi@yahoo.com>
To: sdouglass@arm.com, gcc-gnats@gcc.gnu.org, nobody@gcc.gnu.org
Cc:  
Subject: Re: bootstrap/7087: sub-make FLAG propagation fails if flag ends with '='
Date: Wed, 14 May 2003 02:01:20 -0700

 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit- 
 trail&database=gcc&pr=7087
 
 Hello,
 
 could the submitter please determine if this problem occurs with  
 current gcc sources? Thanks,
 
 Dara
 

bootstrap/7087: sub-make FLAG propagation fails if flag ends with '='

[sdouglass]

>Number:         7087
>Category:       bootstrap
>Synopsis:       sub-make FLAG propagation fails if flag ends with '='
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jun 20 07:26:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     sdouglass@arm.com
>Release:        3.1
>Organization:
>Environment:
all
>Description:
The top-level Makefile.in (and others?) propagates some flags to sub-make by saying, e.g.
    "`echo 'STAGE1_CFLAGS=$(STAGE1_CFLAGS)' | sed -e s/.*=$$/XFOO=/`"

This fails to propagate the value if I've done, e.g.
    make STAGE1_CFLAGS="-O2 -Dinline=' bootstrap-lean
>How-To-Repeat:
make STAGE1_CFLAGS="-O2 -Dinline=' bootstrap-lean
>Fix:
The fix is to change the sed commands to
    sed -e s'/[^=][^=]*=$$/XFOO=/'

I've also added single quotes to protect the '*' (and now '[]'s from being interpreted by the shell.  Although it's pretty unlikely there would be a directory named 's/.[BAR=$/XFOO=' lying around, imagine the confusion that would ensue when using the unquoted form.

Try it for fun:
    mkdir -p s'/.[BAR=$/'XFOO=
    make bootstrap-lean
>Release-Note:
>Audit-Trail:
>Unformatted: