java/1339: PR gcj/310

java/1339: PR gcj/310

[Tom Tromey]

>Number:         1339
>Category:       java
>Synopsis:       PR gcj/310
>Confidential:   yes
>Severity:       serious
>Priority:       medium
>Responsible:    green
>State:          closed
>Class:          sw-bug
>Submitter-Id:   unknown
>Arrival-Date:   Wed Dec 20 12:19:12 PST 2000
>Closed-Date:    Mon Sep 04 09:03:55 PDT 2000
>Last-Modified:  Mon Sep  4 09:16:00 PDT 2000
>Originator:     
>Release:        
>Organization:
>Environment:

>Description:
 This patch fixes the Java PR gcj/310.
 Ok to commit?
 
 2000-08-09  Tom Tromey  <tromey@cygnus.com>
 
 	* parse.y (patch_switch_statement): Disallow boolean and long in
 	switch expressions.  Fixes PR gcj/310.
 
 Tom
 
 Index: parse.y
 ===================================================================
 RCS file: /cvs/gcc/egcs/gcc/java/parse.y,v
 retrieving revision 1.199
 diff -u -r1.199 parse.y
 --- parse.y	2000/08/08 03:33:36	1.199
 +++ parse.y	2000/08/10 01:05:00
 @@ -14379,6 +14379,16 @@
        TREE_OPERAND (node, 0) = error_mark_node;
        return error_mark_node;
      }
 +  else if (se_type == boolean_type_node || se_type == long_type_node)
 +    {
 +      EXPR_WFL_LINECOL (wfl_operator) = EXPR_WFL_LINECOL (node);
 +      parse_error_context (wfl_operator,
 +	  "Invalid type `%s' for `switch'.  Must be `char', `byte', `short', or `int'",
 +			   lang_printable_name (se_type, 0));
 +      /* This is what java_complete_tree will check */
 +      TREE_OPERAND (node, 0) = error_mark_node;
 +      return error_mark_node;
 +    }
  
    TREE_OPERAND (node, 1) = java_complete_tree (TREE_OPERAND (node, 1));
  
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:

Formerly PR gcj/314

State-Changed-From-To: open->closed
State-Changed-By: green
State-Changed-When: Mon Sep  4 09:03:55 2000
State-Changed-Why:
    This is clearly bogus - some kind of gnats usage error.

From: green@cygnus.com
To: green@cygnus.com, java-gnats@sourceware.cygnus.com, tromey@cygnus.com
Cc:  
Subject: Re: gcj/314
Date: 4 Sep 2000 16:03:55 -0000

 Synopsis: PR gcj/310
 
 State-Changed-From-To: open->closed
 State-Changed-By: green
 State-Changed-When: Mon Sep  4 09:03:55 2000
 State-Changed-Why:
     This is clearly bogus - some kind of gnats usage error.
 
 http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view&pr=314&database=java
>Unformatted:

java/1340: Re: PR gcj/310

[Alexandre Petit-Bianco]

>Number:         1340
>Category:       java
>Synopsis:       Re: PR gcj/310
>Confidential:   yes
>Severity:       serious
>Priority:       medium
>Responsible:    green
>State:          closed
>Class:          sw-bug
>Submitter-Id:   unknown
>Arrival-Date:   Wed Dec 20 12:19:12 PST 2000
>Closed-Date:    Mon Sep 04 09:03:27 PDT 2000
>Last-Modified:  Mon Sep  4 09:16:00 PDT 2000
>Originator:     
>Release:        
>Organization:
>Environment:

>Description:
 Tom Tromey writes:
 
 > +  else if (se_type == boolean_type_node || se_type == long_type_node)
 
 `boolean_type_node' is already covered by JINTEGRAL_TYPE_P used right
 above your patch -- have you witnessed some improper behaviors with
 booleans?
 
 ./A
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:

Formerly PR gcj/315

State-Changed-From-To: open->closed
State-Changed-By: green
State-Changed-When: Mon Sep  4 09:03:26 2000
State-Changed-Why:
    This is clearly bogus - some kind of gnats usage error.

From: green@cygnus.com
To: apbianco@redhat.com, green@cygnus.com, java-gnats@sourceware.cygnus.com
Cc:  
Subject: Re: gcj/315
Date: 4 Sep 2000 16:03:27 -0000

 Synopsis: Re: PR gcj/310
 
 State-Changed-From-To: open->closed
 State-Changed-By: green
 State-Changed-When: Mon Sep  4 09:03:26 2000
 State-Changed-Why:
     This is clearly bogus - some kind of gnats usage error.
 
 http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view&pr=315&database=java
>Unformatted: