Re: [TCWG CI] Regression caused by gcc: c: Fix ICE on deferred pragma in unknown attribute arguments [PR103587]

Re: [TCWG CI] Regression caused by gcc: c: Fix ICE on deferred pragma in unknown attribute arguments [PR103587]

[Maxim Kuvyrkov]

Hi Jakub,

This was sent out due to a bug in our CI.  Sorry for the noise.

Regards,

--
Maxim Kuvyrkov
https://www.linaro.org

> On 17 Dec 2021, at 19:03, ci_notify@linaro.org wrote:
> 
> [TCWG CI] Regression caused by gcc: c: Fix ICE on deferred pragma in unknown attribute arguments [PR103587]:
> commit e163dbbc4433e598cad7e6011b255d1d6ad93a3b
> Author: Jakub Jelinek <jakub@redhat.com>
> 
>    c: Fix ICE on deferred pragma in unknown attribute arguments [PR103587]
> 
> Results regressed to
> # reset_artifacts:
> -10
> # build_abe binutils:
> -9
> # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
> -8
> # build_abe newlib:
> -6
> # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
> -5
> # benchmark -- -O3_mthumb artifacts/build-e163dbbc4433e598cad7e6011b255d1d6ad93a3b/results_id:
> 1
> 
> from
> # reset_artifacts:
> -10
> # build_abe binutils:
> -9
> # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
> -8
> # build_abe newlib:
> -6
> # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
> -5
> # benchmark -- -O3_mthumb artifacts/build-baseline/results_id:
> 1
> 
> THIS IS THE END OF INTERESTING STUFF.  BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
> 
> This commit has regressed these CI configurations:
> - tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-O3
> 
> First_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/10/artifact/artifacts/build-e163dbbc4433e598cad7e6011b255d1d6ad93a3b/
> Last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/10/artifact/artifacts/build-228d64af4e244faabab5c47506920a1bde85d74e/
> Baseline build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/10/artifact/artifacts/build-baseline/
> Even more details: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/10/artifact/artifacts/
> 
> Reproduce builds:
> <cut>
> mkdir investigate-gcc-e163dbbc4433e598cad7e6011b255d1d6ad93a3b
> cd investigate-gcc-e163dbbc4433e598cad7e6011b255d1d6ad93a3b
> 
> # Fetch scripts
> git clone https://git.linaro.org/toolchain/jenkins-scripts
> 
> # Fetch manifests and test.sh script
> mkdir -p artifacts/manifests
> curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/10/artifact/artifacts/manifests/build-baseline.sh --fail
> curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/10/artifact/artifacts/manifests/build-parameters.sh --fail
> curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/10/artifact/artifacts/test.sh --fail
> chmod +x artifacts/test.sh
> 
> # Reproduce the baseline build (build all pre-requisites)
> ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh
> 
> # Save baseline build state (which is then restored in artifacts/test.sh)
> mkdir -p ./bisect
> rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /gcc/ ./ ./bisect/baseline/
> 
> cd gcc
> 
> # Reproduce first_bad build
> git checkout --detach e163dbbc4433e598cad7e6011b255d1d6ad93a3b
> ../artifacts/test.sh
> 
> # Reproduce last_good build
> git checkout --detach 228d64af4e244faabab5c47506920a1bde85d74e
> ../artifacts/test.sh
> 
> cd ..
> </cut>
> 
> Full commit (up to 1000 lines):
> <cut>
> commit e163dbbc4433e598cad7e6011b255d1d6ad93a3b
> Author: Jakub Jelinek <jakub@redhat.com>
> Date:   Tue Dec 14 12:02:55 2021 +0100
> 
>    c: Fix ICE on deferred pragma in unknown attribute arguments [PR103587]
> 
>    We ICE on the following testcase, because c_parser_balanced_token_sequence
>    when encountering a deferred pragma will just use c_parser_consume_token
>    which the FE doesn't allow for CPP_PRAGMA tokens (and if that wasn't
>    the case, it could ICE on CPP_PRAGMA_EOL similarly).
>    We don't know in what exact context the pragma appears when we don't
>    know what those arguments semantically mean, so I think we should just
>    skip over them, like e.g. the C++ FE does.  And, I think (/[/{ vs. )/]/}
>    from outside of the pragma shouldn't be paired with those inside of
>    the pragma and it doesn't seem to be necessary to check that inside of
>    the pragma line itself all the paren kinds are balanced.
> 
>    2021-12-14  Jakub Jelinek  <jakub@redhat.com>
> 
>            PR c/103587
>            * c-parser.c (c_parser_balanced_token_sequence): For CPP_PRAGMA,
>            consume the pragma and silently skip to the pragma eol.
> 
>            * gcc.dg/pr103587.c: New test.
> ---
> gcc/c/c-parser.c                | 5 +++++
> gcc/testsuite/gcc.dg/pr103587.c | 7 +++++++
> 2 files changed, 12 insertions(+)
> 
> diff --git a/gcc/c/c-parser.c b/gcc/c/c-parser.c
> index e25df4f26d6..d7e5f051ac0 100644
> --- a/gcc/c/c-parser.c
> +++ b/gcc/c/c-parser.c
> @@ -4846,6 +4846,11 @@ c_parser_balanced_token_sequence (c_parser *parser)
> 	case CPP_EOF:
> 	  return;
> 
> +	case CPP_PRAGMA:
> +	  c_parser_consume_pragma (parser);
> +	  c_parser_skip_to_pragma_eol (parser, false);
> +	  break;
> +
> 	default:
> 	  c_parser_consume_token (parser);
> 	  break;
> diff --git a/gcc/testsuite/gcc.dg/pr103587.c b/gcc/testsuite/gcc.dg/pr103587.c
> new file mode 100644
> index 00000000000..1cbc4d52d9d
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/pr103587.c
> @@ -0,0 +1,7 @@
> +/* PR c/103587 */
> +/* { dg-do compile } */
> +/* { dg-options "" } */
> +
> +[[foo::bar(
> +#pragma GCC ivdep
> +)]];	/* { dg-warning "attribute ignored" } */
> </cut>