[TCWG CI] Regression caused by binutils: Error on ld output file name matching input file name

[TCWG CI] Regression caused by binutils: Error on ld output file name matching input file name

[ci_notify]

[TCWG CI] Regression caused by binutils: Error on ld output file name matching input file name:
commit 43908c16539f486d0b1afc43329bf59d1c3cdd20
Author: Alan Modra <amodra@gmail.com>

    Error on ld output file name matching input file name

Results regressed to
# reset_artifacts:
-10
# true:
0
# build_abe binutils:
1
# First few build errors in logs:
# 00:06:28 make[3]: [Makefile:1774: armv8l-unknown-linux-gnueabihf/bits/largefile-config.h] Error 1 (ignored)
# 00:28:57 make[3]: [Makefile:1774: armv8l-unknown-linux-gnueabihf/bits/largefile-config.h] Error 1 (ignored)
# 00:38:09 make[3]: [Makefile:1774: armv8l-unknown-linux-gnueabihf/bits/largefile-config.h] Error 1 (ignored)
# 06:59:41 collect2: error: ld returned 1 exit status
# 06:59:41 make[3]: *** [Makefile:3111: gcov] Error 1
# 06:59:41 make[2]: *** [Makefile:5078: all-stageprofile-gcc] Error 2
# 06:59:41 make[1]: *** [Makefile:26233: stageprofile-bubble] Error 2
# 06:59:41 make: *** [Makefile:26503: profiledbootstrap] Error 2

from
# reset_artifacts:
-10
# true:
0
# build_abe binutils:
1
# build_abe bootstrap_profiled:
2

THIS IS THE END OF INTERESTING STUFF.  BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.

This commit has regressed these CI configurations:
 - tcwg_gcc_bootstrap/master-arm-bootstrap_profiled

First_bad build: https://ci.linaro.org/job/tcwg_gcc_bootstrap-bisect-master-arm-bootstrap_profiled/6/artifact/artifacts/build-43908c16539f486d0b1afc43329bf59d1c3cdd20/
Last_good build: https://ci.linaro.org/job/tcwg_gcc_bootstrap-bisect-master-arm-bootstrap_profiled/6/artifact/artifacts/build-21ce5fa063563cb254e0560beb98bd4245b99fb1/
Baseline build: https://ci.linaro.org/job/tcwg_gcc_bootstrap-bisect-master-arm-bootstrap_profiled/6/artifact/artifacts/build-baseline/
Even more details: https://ci.linaro.org/job/tcwg_gcc_bootstrap-bisect-master-arm-bootstrap_profiled/6/artifact/artifacts/

Reproduce builds:
<cut>
mkdir investigate-binutils-43908c16539f486d0b1afc43329bf59d1c3cdd20
cd investigate-binutils-43908c16539f486d0b1afc43329bf59d1c3cdd20

# Fetch scripts
git clone https://git.linaro.org/toolchain/jenkins-scripts

# Fetch manifests and test.sh script
mkdir -p artifacts/manifests
curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_gcc_bootstrap-bisect-master-arm-bootstrap_profiled/6/artifact/artifacts/manifests/build-baseline.sh --fail
curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_gcc_bootstrap-bisect-master-arm-bootstrap_profiled/6/artifact/artifacts/manifests/build-parameters.sh --fail
curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_gcc_bootstrap-bisect-master-arm-bootstrap_profiled/6/artifact/artifacts/test.sh --fail
chmod +x artifacts/test.sh

# Reproduce the baseline build (build all pre-requisites)
./jenkins-scripts/tcwg_gnu-build.sh @@ artifacts/manifests/build-baseline.sh

# Save baseline build state (which is then restored in artifacts/test.sh)
mkdir -p ./bisect
rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /binutils/ ./ ./bisect/baseline/

cd binutils

# Reproduce first_bad build
git checkout --detach 43908c16539f486d0b1afc43329bf59d1c3cdd20
../artifacts/test.sh

# Reproduce last_good build
git checkout --detach 21ce5fa063563cb254e0560beb98bd4245b99fb1
../artifacts/test.sh

cd ..
</cut>

Full commit (up to 1000 lines):
<cut>
commit 43908c16539f486d0b1afc43329bf59d1c3cdd20
Author: Alan Modra <amodra@gmail.com>
Date:   Tue Dec 7 12:26:55 2021 +1030

    Error on ld output file name matching input file name
    
    It's not foolproof, for example we don't catch output to a linker
    script, to a library specified with -l, or to an element of a thin
    archive.
    
            * ldlang.c (open_output): Exit with error on output file matching
            an input file.
            * testsuite/ld-misc/just-symbols.exp: Adjust ld -r test to suit.
---
 ld/ldlang.c                           | 16 ++++++++++++++++
 ld/testsuite/ld-misc/just-symbols.exp |  2 +-
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/ld/ldlang.c b/ld/ldlang.c
index acd90fa8f42..64a8f602093 100644
--- a/ld/ldlang.c
+++ b/ld/ldlang.c
@@ -3392,6 +3392,22 @@ lang_get_output_target (void)
 static void
 open_output (const char *name)
 {
+  lang_input_statement_type *f;
+  char *out = lrealpath (name);
+
+  for (f = (void *) input_file_chain.head;
+       f != NULL;
+       f = f->next_real_file)
+    if (f->flags.real)
+      {
+	char *in = lrealpath (f->filename);
+	if (filename_cmp (in, out) == 0)
+	  einfo (_("%F%P: input file '%s' is the same as output file\n"),
+		 f->filename);
+	free (in);
+      }
+  free (out);
+
   output_target = lang_get_output_target ();
 
   /* Has the user requested a particular endianness on the command
diff --git a/ld/testsuite/ld-misc/just-symbols.exp b/ld/testsuite/ld-misc/just-symbols.exp
index 510291473ca..6cfbd34eda9 100644
--- a/ld/testsuite/ld-misc/just-symbols.exp
+++ b/ld/testsuite/ld-misc/just-symbols.exp
@@ -44,7 +44,7 @@ run_ld_link_tests [list \
      "" \
      {just-symbols-0.s} \
      {} \
-     "just-symbols-0.o"] \
+     "just-symbols-r"] \
     [list "Executable for --just-symbols test" \
      "$LDFLAGS -e 0 -T just-symbols.ld" "" \
      "" \
</cut>
>From hjl@sc.intel.com  Fri Dec 10 09:09:23 2021
Return-Path: <hjl@sc.intel.com>
X-Original-To: gcc-regression@gcc.gnu.org
Delivered-To: gcc-regression@gcc.gnu.org
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by sourceware.org (Postfix) with ESMTPS id 8F5363858014
 for <gcc-regression@gcc.gnu.org>; Fri, 10 Dec 2021 09:09:21 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8F5363858014
X-IronPort-AV: E=McAfee;i="6200,9189,10193"; a="235824583"
X-IronPort-AV: E=Sophos;i="5.88,195,1635231600"; d="scan'208";a="235824583"
Received: from orsmga006.jf.intel.com ([10.7.209.51])
 by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 10 Dec 2021 01:09:20 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,195,1635231600"; d="scan'208";a="463604993"
Received: from scymds01.sc.intel.com ([10.148.94.138])
 by orsmga006.jf.intel.com with ESMTP; 10 Dec 2021 01:09:19 -0800
Received: from gnu-snb-1.sc.intel.com (gnu-snb-1.sc.intel.com [172.25.33.219])
 by scymds01.sc.intel.com with ESMTP id 1BA99JAR007440;
 Fri, 10 Dec 2021 01:09:19 -0800
Received: by gnu-snb-1.sc.intel.com (Postfix, from userid 1000)
 id B701D1804D6; Fri, 10 Dec 2021 01:09:19 -0800 (PST)
Date: Fri, 10 Dec 2021 01:09:19 -0800
To: skpgkp2@gmail.com, hjl.tools@gmail.com, gcc-regression@gcc.gnu.org
Subject: Regressions on master at commit r12-5887 vs commit r12-5853 on
 Linux/i686
User-Agent: Heirloom mailx 12.5 7/5/10
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <20211210090919.B701D1804D6@gnu-snb-1.sc.intel.com>
From: "H.J. Lu" <hjl@sc.intel.com>
X-Spam-Status: No, score=-3467.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_LAZY_DOMAIN_SECURITY, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-regression@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-regression mailing list <gcc-regression.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-regression>,
 <mailto:gcc-regression-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-regression/>
List-Post: <mailto:gcc-regression@gcc.gnu.org>
List-Help: <mailto:gcc-regression-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-regression>,
 <mailto:gcc-regression-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Dec 2021 09:09:23 -0000

New failures:
FAIL: compiler driver --help=param option(s): "^ +-.*[^:.]$" absent from output: "  --param=max-inline-functions-called-once-loop-depth= Maximum loop depth of a call which is considered for inlining functions called once"
FAIL: compiler driver --help=params option(s): "[^.]$" absent from output: "e"
FAIL: g++.dg/warn/string1.C    (test for warnings, line 17)

New passes:
FAIL: libgomp.c++/target-lambda-1.C execution test
FAIL: libgomp.c++/target-this-3.C execution test
FAIL: libgomp.c++/target-this-4.C execution test