Re: [TCWG CI] Regression caused by gcc: For -foffload= suggest also 'disable' and 'default' [PR103644]

[Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>]

Hi Tobias,

This was sent out due to a bug in our CI.  Sorry for the noise.

Regards,

--
Maxim Kuvyrkov
https://www.linaro.org

> On 20 Dec 2021, at 11:33, ci_notify@linaro.org wrote:
> 
> [TCWG CI] Regression caused by gcc: For -foffload= suggest also 'disable' and 'default' [PR103644]:
> commit 2c1ac0bf3d44e4ca6e32533d8b498c7d1dbd2425
> Author: Tobias Burnus <tobias@codesourcery.com>
> 
>    For -foffload= suggest also 'disable' and 'default' [PR103644]
> 
> Results regressed to
> # reset_artifacts:
> -10
> # build_abe binutils:
> -9
> # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
> -8
> # build_abe newlib:
> -6
> # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
> -5
> # benchmark -- -O2_mthumb artifacts/build-2c1ac0bf3d44e4ca6e32533d8b498c7d1dbd2425/results_id:
> 1
> 
> from
> # reset_artifacts:
> -10
> # build_abe binutils:
> -9
> # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
> -8
> # build_abe newlib:
> -6
> # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
> -5
> # benchmark -- -O2_mthumb artifacts/build-baseline/results_id:
> 1
> 
> THIS IS THE END OF INTERESTING STUFF.  BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
> 
> This commit has regressed these CI configurations:
> - tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-O2
> 
> First_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2/7/artifact/artifacts/build-2c1ac0bf3d44e4ca6e32533d8b498c7d1dbd2425/
> Last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2/7/artifact/artifacts/build-ab18659afc054434cef4d4757a3519f1100adc52/
> Baseline build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2/7/artifact/artifacts/build-baseline/
> Even more details: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2/7/artifact/artifacts/
> 
> Reproduce builds:
> <cut>
> mkdir investigate-gcc-2c1ac0bf3d44e4ca6e32533d8b498c7d1dbd2425
> cd investigate-gcc-2c1ac0bf3d44e4ca6e32533d8b498c7d1dbd2425
> 
> # Fetch scripts
> git clone https://git.linaro.org/toolchain/jenkins-scripts
> 
> # Fetch manifests and test.sh script
> mkdir -p artifacts/manifests
> curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2/7/artifact/artifacts/manifests/build-baseline.sh --fail
> curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2/7/artifact/artifacts/manifests/build-parameters.sh --fail
> curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2/7/artifact/artifacts/test.sh --fail
> chmod +x artifacts/test.sh
> 
> # Reproduce the baseline build (build all pre-requisites)
> ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh
> 
> # Save baseline build state (which is then restored in artifacts/test.sh)
> mkdir -p ./bisect
> rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /gcc/ ./ ./bisect/baseline/
> 
> cd gcc
> 
> # Reproduce first_bad build
> git checkout --detach 2c1ac0bf3d44e4ca6e32533d8b498c7d1dbd2425
> ../artifacts/test.sh
> 
> # Reproduce last_good build
> git checkout --detach ab18659afc054434cef4d4757a3519f1100adc52
> ../artifacts/test.sh
> 
> cd ..
> </cut>
> 
> Full commit (up to 1000 lines):
> <cut>
> commit 2c1ac0bf3d44e4ca6e32533d8b498c7d1dbd2425
> Author: Tobias Burnus <tobias@codesourcery.com>
> Date:   Thu Dec 16 11:19:37 2021 +0100
> 
>    For -foffload= suggest also 'disable' and 'default' [PR103644]
> 
>    gcc/ChangeLog:
> 
>            PR driver/103644
>            * gcc.c (check_offload_target_name): Add 'default' and 'disable'
>            to the candidate list.
> ---
> gcc/gcc.c | 25 ++++++++++++-------------
> 1 file changed, 12 insertions(+), 13 deletions(-)
> 
> diff --git a/gcc/gcc.c b/gcc/gcc.c
> index 694c2573109..b75b50b87b2 100644
> --- a/gcc/gcc.c
> +++ b/gcc/gcc.c
> @@ -4017,26 +4017,25 @@ check_offload_target_name (const char *target, ptrdiff_t len)
>       memcpy (cand, OFFLOAD_TARGETS, olen);
>       for (c = strtok (cand, ","); c; c = strtok (NULL, ","))
> 	candidates.safe_push (c);
> +      candidates.safe_push ("default");
> +      candidates.safe_push ("disable");
> 
>       char *target2 = XALLOCAVEC (char, len + 1);
>       memcpy (target2, target, len);
>       target2[len] = '\0';
> 
> -      error ("GCC is not configured to support %qs as offload target", target2);
> +      error ("GCC is not configured to support %qs as %<-foffload=%> argument",
> +	     target2);
> 
> -      if (candidates.is_empty ())
> -	inform (UNKNOWN_LOCATION, "no offloading targets configured");
> +      char *s;
> +      const char *hint = candidates_list_and_hint (target2, s, candidates);
> +      if (hint)
> +	inform (UNKNOWN_LOCATION,
> +		"valid %<-foffload=%> arguments are: %s; "
> +		"did you mean %qs?", s, hint);
>       else
> -	{
> -	  char *s;
> -	  const char *hint = candidates_list_and_hint (target2, s, candidates);
> -	  if (hint)
> -	    inform (UNKNOWN_LOCATION,
> -		    "valid offload targets are: %s; did you mean %qs?", s, hint);
> -	  else
> -	    inform (UNKNOWN_LOCATION, "valid offload targets are: %s", s);
> -	  XDELETEVEC (s);
> -	}
> +	inform (UNKNOWN_LOCATION, "valid %<-foffload=%> arguments are: %s", s);
> +      XDELETEVEC (s);
>       return false;
>     }
>   return true;
> </cut>