Re: [TCWG CI] Regression caused by gcc: Adjust 'gfortran.dg/goacc/privatization-1-*' [PR103576, PR103697]

[Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>]

Hi Thomas,

This was sent out due to a bug in our CI.  Sorry for the noise.

Regards,

--
Maxim Kuvyrkov
https://www.linaro.org

> On 18 Dec 2021, at 04:16, ci_notify@linaro.org wrote:
> 
> [TCWG CI] Regression caused by gcc: Adjust 'gfortran.dg/goacc/privatization-1-*' [PR103576, PR103697]:
> commit 228d64af4e244faabab5c47506920a1bde85d74e
> Author: Thomas Schwinge <thomas@codesourcery.com>
> 
>    Adjust 'gfortran.dg/goacc/privatization-1-*' [PR103576, PR103697]
> 
> Results regressed to
> # reset_artifacts:
> -10
> # build_abe binutils:
> -9
> # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
> -8
> # build_abe newlib:
> -6
> # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
> -5
> # benchmark -- -O3_LTO_mthumb artifacts/build-228d64af4e244faabab5c47506920a1bde85d74e/results_id:
> 1
> 
> from
> # reset_artifacts:
> -10
> # build_abe binutils:
> -9
> # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
> -8
> # build_abe newlib:
> -6
> # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
> -5
> # benchmark -- -O3_LTO_mthumb artifacts/build-baseline/results_id:
> 1
> 
> THIS IS THE END OF INTERESTING STUFF.  BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
> 
> This commit has regressed these CI configurations:
> - tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-O3_LTO
> 
> First_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/build-228d64af4e244faabab5c47506920a1bde85d74e/
> Last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/build-7f1239cb43fad3293cf5bcd3678d1cba128d04c6/
> Baseline build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/build-baseline/
> Even more details: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/
> 
> Reproduce builds:
> <cut>
> mkdir investigate-gcc-228d64af4e244faabab5c47506920a1bde85d74e
> cd investigate-gcc-228d64af4e244faabab5c47506920a1bde85d74e
> 
> # Fetch scripts
> git clone https://git.linaro.org/toolchain/jenkins-scripts
> 
> # Fetch manifests and test.sh script
> mkdir -p artifacts/manifests
> curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/manifests/build-baseline.sh --fail
> curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/manifests/build-parameters.sh --fail
> curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/test.sh --fail
> chmod +x artifacts/test.sh
> 
> # Reproduce the baseline build (build all pre-requisites)
> ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh
> 
> # Save baseline build state (which is then restored in artifacts/test.sh)
> mkdir -p ./bisect
> rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /gcc/ ./ ./bisect/baseline/
> 
> cd gcc
> 
> # Reproduce first_bad build
> git checkout --detach 228d64af4e244faabab5c47506920a1bde85d74e
> ../artifacts/test.sh
> 
> # Reproduce last_good build
> git checkout --detach 7f1239cb43fad3293cf5bcd3678d1cba128d04c6
> ../artifacts/test.sh
> 
> cd ..
> </cut>
> 
> Full commit (up to 1000 lines):
> <cut>
> commit 228d64af4e244faabab5c47506920a1bde85d74e
> Author: Thomas Schwinge <thomas@codesourcery.com>
> Date:   Tue Dec 14 07:03:52 2021 +0100
> 
>    Adjust 'gfortran.dg/goacc/privatization-1-*' [PR103576, PR103697]
> 
>    ... for the recent commit 494ebfa7c9aacaeb6ec1fccc47a0e49f31eb2bb8
>    "Fortran: Handle compare in OpenMP atomic", which changes the GIMPLE IR
>    such that a temporary is no longer used; 'original' dump:
> 
>                 x = *a;
>        -        {
>        -          integer(kind=4) D.4237;
>        -
>        -          D.4237 = *a;
>                   #pragma omp atomic relaxed
>        -            &y = D.4237;
>        -        }
>        +          &y = *a;
>               }
> 
>    (I'm not familiar to comment whether that's correct; but it appears that the
>    difference again disappears in later compiler passes.)
> 
>    These OpenACC test cases verify behavior re OpenACC privatization levels, and
>    have to be adjusted accordingly.
> 
>            gcc/testsuite/
>            PR fortran/103576
>            PR testsuite/103697
>            * gfortran.dg/goacc/privatization-1-compute-loop.f90: Adjust.
>            * gfortran.dg/goacc/privatization-1-compute.f90: Likewise.
>            * gfortran.dg/goacc/privatization-1-routine_gang-loop.f90:
>            Likewise.
>            * gfortran.dg/goacc/privatization-1-routine_gang.f90: Likewise.
> ---
> gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90      | 1 -
> gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90           | 1 -
> gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.f90 | 1 -
> gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90      | 1 -
> 4 files changed, 4 deletions(-)
> 
> diff --git a/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90 b/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90
> index bcd7159ae5b..47ba5baf439 100644
> --- a/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90
> +++ b/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90
> @@ -50,7 +50,6 @@ contains
>     ! { dg-note {variable 'x' in 'private' clause isn't candidate for adjusting OpenACC privatization level: not addressable} "" { target *-*-* } l_loop$c_loop }
>     ! { dg-note {variable 'y' in 'private' clause is candidate for adjusting OpenACC privatization level} "" { target *-*-* } l_loop$c_loop }
>     ! { dg-note {variable 'C\.[0-9]+' declared in block potentially has improper OpenACC privatization level: 'const_decl'} "TODO" { target *-*-* } l_loop$c_loop }
> -    ! { dg-note {variable 'D\.[0-9]+' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable} "" { target *-*-* } l_loop$c_loop }
>     ! { dg-note {variable 'y' ought to be adjusted for OpenACC privatization level: 'vector'} "" { target *-*-* } l_loop$c_loop }
>     !$acc end parallel
>   end subroutine f
> diff --git a/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90 b/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90
> index 31f998dfc92..4813e44a233 100644
> --- a/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90
> +++ b/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90
> @@ -43,6 +43,5 @@ contains
>     ! { dg-note {variable 'j' in 'private' clause potentially has improper OpenACC privatization level: 'parm_decl'} "TODO3" { xfail *-*-* } l_compute$c_compute }
>     ! { dg-note {variable 'a' in 'private' clause potentially has improper OpenACC privatization level: 'parm_decl'} "TODO4" { xfail *-*-* } l_compute$c_compute }
>     ! { dg-note {variable 'C\.[0-9]+' declared in block potentially has improper OpenACC privatization level: 'const_decl'} "TODO" { target *-*-* } l_compute$c_compute }
> -    ! { dg-note {variable 'D\.[0-9]+' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable} "" { target *-*-* } l_compute$c_compute }
>   end subroutine f
> end module m
> diff --git a/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.f90 b/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.f90
> index db6d8226ed0..36f2a886e47 100644
> --- a/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.f90
> +++ b/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.f90
> @@ -50,7 +50,6 @@ contains
>     ! { dg-note {variable 'x' in 'private' clause isn't candidate for adjusting OpenACC privatization level: not addressable} "" { target *-*-* } l_loop$c_loop }
>     ! { dg-note {variable 'y' in 'private' clause is candidate for adjusting OpenACC privatization level} "" { target *-*-* } l_loop$c_loop }
>     ! { dg-note {variable 'C\.[0-9]+' declared in block potentially has improper OpenACC privatization level: 'const_decl'} "TODO" { target *-*-* } l_loop$c_loop }
> -    ! { dg-note {variable 'D\.[0-9]+' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable} "" { target *-*-* } l_loop$c_loop }
>     ! { dg-note {variable 'y' ought to be adjusted for OpenACC privatization level: 'vector'} "" { target *-*-* } l_loop$c_loop }
>   end subroutine f
> end module m
> diff --git a/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90 b/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90
> index 725bd5e2ebe..0615a445e44 100644
> --- a/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90
> +++ b/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90
> @@ -43,5 +43,4 @@ contains
>     ! { dg-note {variable 'j' in 'private' clause potentially has improper OpenACC privatization level: 'parm_decl'} "TODO" { xfail *-*-* } l_routine$c_routine }
>     ! { dg-note {variable 'a' in 'private' clause potentially has improper OpenACC privatization level: 'parm_decl'} "TODO" { xfail *-*-* } l_routine$c_routine }
>     ! { dg-note {variable 'C\.[0-9]+' declared in block potentially has improper OpenACC privatization level: 'const_decl'} "TODO" { xfail *-*-* } l_routine$c_routine }
> -    ! { dg-note {variable 'D\.[0-9]+' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable} "TODO" { xfail *-*-* } l_routine$c_routine }
> end module m
> </cut>