Re: [TCWG CI] Failure after basepoints/gcc-13-3596-ge7310e24b1c: Make ranger vrp1 default.

[Andrew MacLeod <amacleod@redhat.com>]

This problem should be resolved with:

commit 6fd485d15c1a2c427c39bcd45e03bed8cde689e6
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Wed Nov 2 21:37:49 2022 -0400

     Update range query cache when a statement is updated.

On 11/1/22 17:39, ci_notify@linaro.org wrote:
> Failure after basepoints/gcc-13-3596-ge7310e24b1c: Make ranger vrp1 default.:
>
> Results changed to
> -10
> # true:
> 0
> # build_abe binutils:
> 1
> # build_abe gcc:
> 2
> # build_abe linux:
> 4
> # build_abe glibc:
> # FAILED
> # First few build errors in logs:
> # 00:00:12       pthread_create.c:50:1: error: alias must point to a defined variable or function
> # 00:02:24 /home/tcwg-buildslave/workspace/tcwg_gnu_2/glibc/csu/../csu/libc-tls.c:202: undefined reference to `_startup_fatal_not_constant'
> # 00:02:24 collect2: error: ld returned 1 exit status
> # 00:02:24 make[2]: *** [../Rules:293: /home/tcwg-buildslave/workspace/tcwg_gnu_2/abe/builds/armv8l-unknown-linux-gnueabihf/armv8l-unknown-linux-gnueabihf/glibc-glibc.git~master/support/test-run-command] Error 1
> # 00:02:24 make[1]: *** [Makefile:484: support/others] Error 2
> # 00:02:24 make: *** [Makefile:9: all] Error 2
>
> from
> -10
> # true:
> 0
> # build_abe binutils:
> 1
> # build_abe gcc:
> 2
> # build_abe linux:
> 4
> # build_abe glibc:
> 5
> # build_abe gdb:
> 6
>
> THIS IS THE END OF INTERESTING STUFF.  BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
>
> For latest status see comments in https://linaro.atlassian.net/browse/GNU-692 .
> Status of basepoints/gcc-13-3596-ge7310e24b1c commit for tcwg_gnu_native_build:
> commit e7310e24b1c0ca67b1bb507c1330b2bf39e59e32
> Author: Andrew MacLeod <amacleod@redhat.com>
> Date:   Tue Oct 25 16:42:41 2022 -0400
>
>      Make ranger vrp1 default.
>      
>      Turn on ranger as the default vrp1 pass and adjust testcases.
>      
>              gcc/
>              * params.opt (param_vrp1_mode): Make ranger default.
>      
>              gcc/testsuite/
>              * gcc.dg/pr68217.c: Test [-INF, -INF][0, 0] instead of [-INF, 0].
>              * gcc.dg/tree-ssa/vrp-unreachable.c: New.  Test unreachable removal.
> * master-arm
> ** Failure after basepoints/gcc-13-3596-ge7310e24b1c: Make ranger vrp1 default.:
> ** https://ci.linaro.org/job/tcwg_gnu_native_build-build-master-arm/505/
>
> Bad  build: https://ci.linaro.org/job/tcwg_gnu_native_build-build-master-arm/505/artifact/artifacts
> Good build: https://ci.linaro.org/job/tcwg_gnu_native_build-build-master-arm/504/artifact/artifacts
>
> Reproduce current build:
> <cut>
> mkdir -p investigate-gcc-e7310e24b1c0ca67b1bb507c1330b2bf39e59e32
> cd investigate-gcc-e7310e24b1c0ca67b1bb507c1330b2bf39e59e32
>
> # Fetch scripts
> git clone https://git.linaro.org/toolchain/jenkins-scripts
>
> # Fetch manifests for bad and good builds
> mkdir -p bad/artifacts good/artifacts
> curl -o bad/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_gnu_native_build-build-master-arm/505/artifact/artifacts/manifest.sh --fail
> curl -o good/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_gnu_native_build-build-master-arm/504/artifact/artifacts/manifest.sh --fail
>
> # Reproduce bad build
> (cd bad; ../jenkins-scripts/tcwg_gnu-build.sh ^^ true %%rr[top_artifacts] artifacts)
> # Reproduce good build
> (cd good; ../jenkins-scripts/tcwg_gnu-build.sh ^^ true %%rr[top_artifacts] artifacts)
> </cut>
>
> Full commit (up to 1000 lines):
> <cut>
> commit e7310e24b1c0ca67b1bb507c1330b2bf39e59e32
> Author: Andrew MacLeod <amacleod@redhat.com>
> Date:   Tue Oct 25 16:42:41 2022 -0400
>
>      Make ranger vrp1 default.
>      
>      Turn on ranger as the default vrp1 pass and adjust testcases.
>      
>              gcc/
>              * params.opt (param_vrp1_mode): Make ranger default.
>      
>              gcc/testsuite/
>              * gcc.dg/pr68217.c: Test [-INF, -INF][0, 0] instead of [-INF, 0].
>              * gcc.dg/tree-ssa/vrp-unreachable.c: New.  Test unreachable removal.
> ---
>   gcc/params.opt                                  |  2 +-
>   gcc/testsuite/gcc.dg/pr68217.c                  |  2 +-
>   gcc/testsuite/gcc.dg/tree-ssa/vrp-unreachable.c | 42 +++++++++++++++++++++++++
>   3 files changed, 44 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/params.opt b/gcc/params.opt
> index 3001566e641..a34fee193fc 100644
> --- a/gcc/params.opt
> +++ b/gcc/params.opt
> @@ -1166,7 +1166,7 @@ Common Joined UInteger Var(param_vect_induction_float) Init(1) IntegerRage(0, 1)
>   Enable loop vectorization of floating point inductions.
>   
>   -param=vrp1-mode=
> -Common Joined Var(param_vrp1_mode) Enum(vrp_mode) Init(VRP_MODE_VRP) Param Optimization
> +Common Joined Var(param_vrp1_mode) Enum(vrp_mode) Init(VRP_MODE_RANGER) Param Optimization
>   --param=vrp1-mode=[vrp|ranger] Specifies the mode VRP1 should operate in.
>   
>   -param=vrp2-mode=
> diff --git a/gcc/testsuite/gcc.dg/pr68217.c b/gcc/testsuite/gcc.dg/pr68217.c
> index eb4f15e048f..60c80106760 100644
> --- a/gcc/testsuite/gcc.dg/pr68217.c
> +++ b/gcc/testsuite/gcc.dg/pr68217.c
> @@ -10,4 +10,4 @@ int foo (void)
>       return 0;
>   }
>   
> -/* { dg-final { scan-tree-dump "\\\[-INF, 0\\\]" "vrp1" } } */
> +/* { dg-final { scan-tree-dump "\\\[-INF, -INF\\\]\\\[0, 0\\\]" "vrp1" } } */
> diff --git a/gcc/testsuite/gcc.dg/tree-ssa/vrp-unreachable.c b/gcc/testsuite/gcc.dg/tree-ssa/vrp-unreachable.c
> new file mode 100644
> index 00000000000..cdc57403c6e
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/tree-ssa/vrp-unreachable.c
> @@ -0,0 +1,42 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -fdump-tree-vrp1-alias -fdump-tree-vrp2-alias" } */
> +
> +void dead (unsigned n);
> +void alive (unsigned n);
> +
> +void func (unsigned n, unsigned m)
> +{
> +  if (n == 0)
> +    __builtin_unreachable();
> +  if (n == 1)
> +    __builtin_unreachable();
> +  if (n & 0x1)
> +    __builtin_unreachable();
> +  if (n == 2)
> +    __builtin_unreachable();
> +  if (n == 3)
> +    __builtin_unreachable();
> +  if (n & 0x2)
> +    __builtin_unreachable();
> +  if (n == 4)
> +    __builtin_unreachable();
> +  if (n == 5)
> +    __builtin_unreachable();
> +  if (n & 0x4)
> +    __builtin_unreachable();
> +  if (n == 6)
> +    __builtin_unreachable();
> +  if (n == 7)
> +    __builtin_unreachable();
> + if (n <8)
> +   dead (n);
> + if (n != m)
> +    __builtin_unreachable();
> + alive (n);
> + alive (m);
> +}
> +
> +/* { dg-final { scan-tree-dump-not "dead" "vrp1" } } */
> +/* { dg-final { scan-tree-dump-times "builtin_unreachable" 1 "vrp1" } } */
> +/* { dg-final { scan-tree-dump-not "builtin_unreachable" "vrp2" } } */
> +/* { dg-final { scan-tree-dump-times "fff8" 4 "vrp2" } } */
> </cut>