From: Joseph Myers <joseph@codesourcery.com>
To: Arthur Cohen <arthur.cohen@embecosm.com>
Cc: <gcc-patches@gcc.gnu.org>, <gcc-rust@gcc.gnu.org>,
Raiki Tamura <tamaron1203@gmail.com>
Subject: Re: [PATCH v3] libcpp: add function to check XID properties
Date: Mon, 18 Dec 2023 19:00:29 +0000 [thread overview]
Message-ID: <1f218960-1c67-31d1-5355-7d3c4f5639c6@codesourcery.com> (raw)
In-Reply-To: <20230908145908.915341-1-arthur.cohen@embecosm.com>
On Fri, 8 Sep 2023, Arthur Cohen wrote:
> + if (c < 0x80)
> + {
> + if (('A' <= c && c <= 'Z') || ('a' <= c && c <= 'z'))
> + return CPP_XID_START | CPP_XID_CONTINUE;
> + if (('0' <= c && c <= '9') || c == '_')
> + return CPP_XID_CONTINUE;
This may be an artifact of how the patch was mailed, but indentation seems
off here (should be six spaces for both return statements).
> + md = (mn + mx) / 2;
> + if (c <= ucnranges[md].end)
> + mx = md;
> + else
> + mn = md + 1;
And likewise here (should be a tab for both assignments).
OK with those indentation fixes.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2023-12-18 19:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 12:58 [PATCH] " Arthur Cohen
2023-09-08 13:09 ` Jakub Jelinek
2023-09-08 14:25 ` [PATCH v2] " Arthur Cohen
2023-09-08 14:59 ` [PATCH v3] " Arthur Cohen
2023-10-16 15:02 ` Arthur Cohen
2023-12-18 19:00 ` Joseph Myers [this message]
2024-01-04 15:22 ` Arthur Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f218960-1c67-31d1-5355-7d3c4f5639c6@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=arthur.cohen@embecosm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc-rust@gcc.gnu.org \
--cc=tamaron1203@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).