From: Thomas Schwinge <thomas@codesourcery.com>
To: Arthur Cohen <arthur.cohen@embecosm.com>,
Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
Cc: <gcc-patches@gcc.gnu.org>, <gcc-rust@gcc.gnu.org>
Subject: Re: GCC/Rust libgrust-v2/to-submit branch
Date: Tue, 12 Dec 2023 16:25:47 +0100 [thread overview]
Message-ID: <87a5qfa1dw.fsf@euler.schwinge.homeip.net> (raw)
In-Reply-To: <87cyvbaheh.fsf@euler.schwinge.homeip.net>
Hi Arthur, Pierre-Emmanuel!
On 2023-12-12T10:39:50+0100, I wrote:
> On 2023-11-27T16:46:08+0100, I wrote:
>> On 2023-11-21T16:20:22+0100, Arthur Cohen <arthur.cohen@embecosm.com> wrote:
>>> On 11/20/23 15:55, Thomas Schwinge wrote:
>>>> Arthur and Pierre-Emmanuel have prepared a GCC/Rust libgrust-v2/to-submit
>>>> branch: <https://github.com/Rust-GCC/gccrs/tree/libgrust-v2/to-submit>.
> Rebasing onto current master branch, there's a minor (textual) conflict
> in top-level 'configure.ac:host_libs': 'intl' replaced by 'gettext', and
> top-level 'configure' plus 'gcc/configure' have to be re-generated (the
> latter for some unrelated changes in line numbers). Otherwise, those
> initial libgrust changes are now in the form that I thought they should
> be in -- so I suggest you fix that up (I can quickly have a look again,
> if you like)
I've noticed that you've fix that up (looks good), but I also noticed one
additional small item: into "build: Add libgrust as compilation modules",
you'll have to add the effect of top-level 'autogen Makefile.def' (that
is, regenerate the top-level 'Makefile.in').
Grüße
Thomas
> and then you do the "scary" 'git push' ;-) -- and then:
>
>>> All the best, and thanks again for testing :)
>>
>> :-) So I hope I've not missed any major issues...
>
> ..., we wait and see. :-)
>
>
> Grüße
> Thomas
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
next prev parent reply other threads:[~2023-12-12 15:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 11:59 [PATCH 1/3] librust: Add libproc_macro and build system Arthur Cohen
2023-09-20 11:59 ` [PATCH 2/3] build: Add libgrust as compilation modules Arthur Cohen
2023-09-26 11:42 ` Richard Biener
2023-09-26 22:25 ` Thomas Schwinge
2023-10-27 20:41 ` Thomas Schwinge
2023-11-20 14:55 ` GCC/Rust libgrust-v2/to-submit branch (was: [PATCH 2/3] build: Add libgrust as compilation modules) Thomas Schwinge
2023-11-21 15:20 ` GCC/Rust libgrust-v2/to-submit branch Arthur Cohen
2023-11-27 15:46 ` Thomas Schwinge
2023-12-12 9:39 ` Thomas Schwinge
2023-12-12 15:25 ` Thomas Schwinge [this message]
2023-09-20 11:59 ` [PATCH 3/3] build: Regenerate build files Arthur Cohen
2023-09-26 11:40 ` [PATCH 1/3] librust: Add libproc_macro and build system Richard Biener
2023-09-26 22:42 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5qfa1dw.fsf@euler.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=arthur.cohen@embecosm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc-rust@gcc.gnu.org \
--cc=pierre-emmanuel.patry@embecosm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).