From: Thomas Schwinge <thomas@codesourcery.com>
To: "Paul E. Murphy" <murphyp@linux.ibm.com>
Cc: <gcc-patches@gcc.gnu.org>, <gcc-rust@gcc.gnu.org>
Subject: Re: [PATCH 2/2] rust: update usage of TARGET_AIX to TARGET_AIX_OS
Date: Mon, 19 Jun 2023 10:39:42 +0200 [thread overview]
Message-ID: <87a5wv3kxd.fsf@euler.schwinge.homeip.net> (raw)
In-Reply-To: <20230616160002.1854983-2-murphyp@linux.ibm.com>
Hi Paul!
On 2023-06-16T11:00:02-0500, "Paul E. Murphy via Gcc-patches" <gcc-patches@gcc.gnu.org> wrote:
> This was noticed when fixing the gccgo usage of the macro, the
> rust usage is very similar.
>
> TARGET_AIX is defined as a non-zero value on linux/powerpc64le
> which may cause unexpected behavior. TARGET_AIX_OS should be
> used to toggle AIX specific behavior.
>
> gcc/rust/ChangeLog:
>
> * rust-object-export.cc [TARGET_AIX]: Rename and update
> usage to TARGET_AIX_OS.
I don't have rights to formally approve this GCC/Rust change, but I'll
note that it follows "as obvious" (see
<https://gcc.gnu.org/gitwrite.html#policies>, "Obvious fixes") to the
corresponding GCC/Go change, which has been approved:
<https://inbox.sourceware.org/CAKOQZ8wDWc7G5_jBNK1jvgChhiURceeAmZb5Bqrx_VZjeJP2Vw@mail.gmail.com>,
and which is where this GCC/Rust code has been copied from, so I suggest
you push both patches at once.
Grüße
Thomas
> ---
> gcc/rust/rust-object-export.cc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/rust/rust-object-export.cc b/gcc/rust/rust-object-export.cc
> index 1143c767784..f9a395f6964 100644
> --- a/gcc/rust/rust-object-export.cc
> +++ b/gcc/rust/rust-object-export.cc
> @@ -46,8 +46,8 @@
> #define RUST_EXPORT_SECTION_NAME ".rust_export"
> #endif
>
> -#ifndef TARGET_AIX
> -#define TARGET_AIX 0
> +#ifndef TARGET_AIX_OS
> +#define TARGET_AIX_OS 0
> #endif
>
> /* Return whether or not GCC has reported any errors. */
> @@ -91,7 +91,7 @@ rust_write_export_data (const char *bytes, unsigned int size)
> {
> gcc_assert (targetm_common.have_named_sections);
> sec = get_section (RUST_EXPORT_SECTION_NAME,
> - TARGET_AIX ? SECTION_EXCLUDE : SECTION_DEBUG, NULL);
> + TARGET_AIX_OS ? SECTION_EXCLUDE : SECTION_DEBUG, NULL);
> }
>
> switch_to_section (sec);
> --
> 2.31.1
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
next parent reply other threads:[~2023-06-19 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230616160002.1854983-1-murphyp@linux.ibm.com>
[not found] ` <20230616160002.1854983-2-murphyp@linux.ibm.com>
2023-06-19 8:39 ` Thomas Schwinge [this message]
2023-06-21 16:20 ` Paul E Murphy
2023-06-22 23:38 ` Peter Bergner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5wv3kxd.fsf@euler.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc-rust@gcc.gnu.org \
--cc=murphyp@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).