From: Peter Bergner <bergner@linux.ibm.com>
To: Paul E Murphy <murphyp@linux.ibm.com>,
Thomas Schwinge <thomas@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org
Subject: Re: [PATCH 2/2] rust: update usage of TARGET_AIX to TARGET_AIX_OS
Date: Thu, 22 Jun 2023 18:38:36 -0500 [thread overview]
Message-ID: <92dc77af-6187-13d4-2d3b-25efb0c87084@linux.ibm.com> (raw)
In-Reply-To: <517783a6-4ce8-77af-6e16-bf49205eec02@linux.ibm.com>
On 6/21/23 11:20 AM, Paul E Murphy via Gcc-patches wrote:
>
>
> On 6/19/23 3:39 AM, Thomas Schwinge wrote:
>> Hi Paul!
>>
>> On 2023-06-16T11:00:02-0500, "Paul E. Murphy via Gcc-patches" <gcc-patches@gcc.gnu.org> wrote:
>>> This was noticed when fixing the gccgo usage of the macro, the
>>> rust usage is very similar.
>>>
>>> TARGET_AIX is defined as a non-zero value on linux/powerpc64le
>>> which may cause unexpected behavior. TARGET_AIX_OS should be
>>> used to toggle AIX specific behavior.
>>>
>>> gcc/rust/ChangeLog:
>>>
>>> * rust-object-export.cc [TARGET_AIX]: Rename and update
>>> usage to TARGET_AIX_OS.
>>
>> I don't have rights to formally approve this GCC/Rust change, but I'll
>> note that it follows "as obvious" (see
>> <https://gcc.gnu.org/gitwrite.html#policies>, "Obvious fixes") to the
>> corresponding GCC/Go change, which has been approved:
>> <https://inbox.sourceware.org/CAKOQZ8wDWc7G5_jBNK1jvgChhiURceeAmZb5Bqrx_VZjeJP2Vw@mail.gmail.com>,
>> and which is where this GCC/Rust code has been copied from, so I suggest
>> you push both patches at once.
>>
>>
>> Grüße
>> Thomas
>
> Hi Thomas,
>
> Thank you for reviewing. I do not have commit access, so I cannot push this myself. If this is OK, could one of the rust maintainers push this patch?
>
> Thanks,
> Paul
I pushed this to trunk for Paul.
Peter
prev parent reply other threads:[~2023-06-23 0:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230616160002.1854983-1-murphyp@linux.ibm.com>
[not found] ` <20230616160002.1854983-2-murphyp@linux.ibm.com>
2023-06-19 8:39 ` Thomas Schwinge
2023-06-21 16:20 ` Paul E Murphy
2023-06-22 23:38 ` Peter Bergner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92dc77af-6187-13d4-2d3b-25efb0c87084@linux.ibm.com \
--to=bergner@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc-rust@gcc.gnu.org \
--cc=murphyp@linux.ibm.com \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).