From: Marc <dkm@kataplop.net>
To: Mark Wielaard <mark@klomp.org>
Cc: gcc-rust@gcc.gnu.org, tom@tromey.com
Subject: Re: [PATCH] Fix inner attribute parsing
Date: Sun, 27 Jun 2021 21:17:04 +0200 [thread overview]
Message-ID: <87pmw73yof.fsf@arrakis.kataplop.net> (raw)
In-Reply-To: <20210627151202.238046-1-mark@klomp.org> (Mark Wielaard's message of "Sun, 27 Jun 2021 17:12:02 +0200")
Mark Wielaard <mark@klomp.org> writes:
> parse_inner_attribute tried to skip the right square token twice. This caused odd error
> messages in case there were multiple inner attributes. This bug masked another bug in
> parse_attr_input where when the (optional) attr input was an assignment to a literal
> the parser failed to skip the literal.
>
> The existing top_attr.rs testcase relied on the two bugs cancelling each other out.
> Add a new testcase inner_attributes.rs for the first bug.
>
> Resolves: https://github.com/Rust-GCC/gccrs/issues/510
Hi Mark,
Sent to GH: https://github.com/Rust-GCC/gccrs/pull/530
Thanks :)
Marc
prev parent reply other threads:[~2021-06-27 19:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-27 15:12 Mark Wielaard
2021-06-27 19:17 ` Marc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmw73yof.fsf@arrakis.kataplop.net \
--to=dkm@kataplop.net \
--cc=gcc-rust@gcc.gnu.org \
--cc=mark@klomp.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).