* [Bug rust/106072] [13 Regression] Bogus -Wnonnull warning breaks rust bootstrap
[not found] <bug-106072-35322@http.gcc.gnu.org/bugzilla/>
@ 2022-12-14 8:51 ` jakub at gcc dot gnu.org
2022-12-14 8:55 ` jakub at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-12-14 8:51 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106072
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|ipa |rust
CC| |dkm at gcc dot gnu.org,
| |gcc-rust at gcc dot gnu.org
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug rust/106072] [13 Regression] Bogus -Wnonnull warning breaks rust bootstrap
[not found] <bug-106072-35322@http.gcc.gnu.org/bugzilla/>
2022-12-14 8:51 ` [Bug rust/106072] [13 Regression] Bogus -Wnonnull warning breaks rust bootstrap jakub at gcc dot gnu.org
@ 2022-12-14 8:55 ` jakub at gcc dot gnu.org
2022-12-14 10:06 ` tschwinge at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-12-14 8:55 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106072
--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 54084
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54084&action=edit
gcc13-pr106072.patch
Untested fix.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug rust/106072] [13 Regression] Bogus -Wnonnull warning breaks rust bootstrap
[not found] <bug-106072-35322@http.gcc.gnu.org/bugzilla/>
2022-12-14 8:51 ` [Bug rust/106072] [13 Regression] Bogus -Wnonnull warning breaks rust bootstrap jakub at gcc dot gnu.org
2022-12-14 8:55 ` jakub at gcc dot gnu.org
@ 2022-12-14 10:06 ` tschwinge at gcc dot gnu.org
2022-12-14 10:17 ` [Bug rust/106072] [13 Regression] " tschwinge at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: tschwinge at gcc dot gnu.org @ 2022-12-14 10:06 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106072
Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also|https://gcc.gnu.org/bugzill |
|a/show_bug.cgi?id=108084 |
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug rust/106072] [13 Regression] -Wnonnull warning breaks rust bootstrap
[not found] <bug-106072-35322@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2022-12-14 10:06 ` tschwinge at gcc dot gnu.org
@ 2022-12-14 10:17 ` tschwinge at gcc dot gnu.org
2022-12-14 10:36 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: tschwinge at gcc dot gnu.org @ 2022-12-14 10:17 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106072
Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://github.com/Rust-GCC
| |/gccrs/pull/1619
CC| |tschwinge at gcc dot gnu.org
Blocks|95507 |
Summary|[13 Regression] Bogus |[13 Regression] -Wnonnull
|-Wnonnull warning breaks |warning breaks rust
|rust bootstrap |bootstrap
Keywords|diagnostic |
--- Comment #15 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Thanks, Jakub!
So, an actual GCC/Rust issue, not PR95507 "(Wnonnull) - [meta-bug]
bogus/missing -Wnonnull".
Referenced Bugs:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95507
[Bug 95507] [meta-bug] bogus/missing -Wnonnull
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug rust/106072] [13 Regression] -Wnonnull warning breaks rust bootstrap
[not found] <bug-106072-35322@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2022-12-14 10:17 ` [Bug rust/106072] [13 Regression] " tschwinge at gcc dot gnu.org
@ 2022-12-14 10:36 ` cvs-commit at gcc dot gnu.org
2022-12-20 14:05 ` rguenth at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-12-14 10:36 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106072
--- Comment #16 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:95dc11475dac06b5eecd904079de8aa94827a36a
commit r13-4697-g95dc11475dac06b5eecd904079de8aa94827a36a
Author: Jakub Jelinek <jakub@redhat.com>
Date: Wed Dec 14 11:35:22 2022 +0100
rust: Fix up aarch64-linux bootstrap [PR106072]
Bootstrap fails on aarch64-linux and some other arches with:
.../gcc/rust/parse/rust-parse-impl.h: In member function
âRust::AST::ClosureParam
Rust::Parser<ManagedTokenSource>::parse_closure_param() [with
ManagedTokenSource = Rust::Lexer]â:
.../gcc/rust/parse/rust-parse-impl.h:8916:49: error: âthisâ pointer is
null [-Werror=nonnull]
The problem is that while say on x86_64-linux the side-effects in the
arguments are evaluated from last argument to first, on aarch64-linux
it is the other way around, from first to last. The C++ I believe even
in C++17 makes the evaluation of those side-effects unordered
(indeterminately sequenced with no interleaving), so that is fine.
But, when the call in return statement is evaluated from first to
last, std::move (pattern) happens before pattern->get_locus () and
the former will make pattern (std::unique_ptr) a wrapper object around
nullptr, so dereferencing it later to call get_locus () on it is invalid.
2022-12-14 Jakub Jelinek <jakub@redhat.com>
PR rust/106072
* parse/rust-parse-impl.h (parse_closure_param): Store
pattern->get_locus () in a temporary before std::move (pattern) is
invoked.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug rust/106072] [13 Regression] -Wnonnull warning breaks rust bootstrap
[not found] <bug-106072-35322@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2022-12-14 10:36 ` cvs-commit at gcc dot gnu.org
@ 2022-12-20 14:05 ` rguenth at gcc dot gnu.org
2022-12-20 14:06 ` ktkachov at gcc dot gnu.org
2022-12-20 14:08 ` ro at CeBiTec dot Uni-Bielefeld.DE
7 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-12-20 14:05 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106072
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #17 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed(?)
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug rust/106072] [13 Regression] -Wnonnull warning breaks rust bootstrap
[not found] <bug-106072-35322@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2022-12-20 14:05 ` rguenth at gcc dot gnu.org
@ 2022-12-20 14:06 ` ktkachov at gcc dot gnu.org
2022-12-20 14:08 ` ro at CeBiTec dot Uni-Bielefeld.DE
7 siblings, 0 replies; 8+ messages in thread
From: ktkachov at gcc dot gnu.org @ 2022-12-20 14:06 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106072
--- Comment #18 from ktkachov at gcc dot gnu.org ---
(In reply to Richard Biener from comment #17)
> Fixed(?)
Yes on aarch64, thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug rust/106072] [13 Regression] -Wnonnull warning breaks rust bootstrap
[not found] <bug-106072-35322@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2022-12-20 14:06 ` ktkachov at gcc dot gnu.org
@ 2022-12-20 14:08 ` ro at CeBiTec dot Uni-Bielefeld.DE
7 siblings, 0 replies; 8+ messages in thread
From: ro at CeBiTec dot Uni-Bielefeld.DE @ 2022-12-20 14:08 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106072
--- Comment #19 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #18 from ktkachov at gcc dot gnu.org ---
> (In reply to Richard Biener from comment #17)
>> Fixed(?)
>
> Yes on aarch64, thanks!
Same on sparc.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread