* [Bug rust/108113] New: Rust and --enable-link-serialization=1
@ 2022-12-14 19:49 jakub at gcc dot gnu.org
2022-12-14 19:59 ` [Bug rust/108113] " dkm at gcc dot gnu.org
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-12-14 19:49 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108113
Bug ID: 108113
Summary: Rust and --enable-link-serialization=1
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: rust
Assignee: unassigned at gcc dot gnu.org
Reporter: jakub at gcc dot gnu.org
CC: dkm at gcc dot gnu.org, gcc-rust at gcc dot gnu.org
Target Milestone: ---
Seems rust/Make-lang.in doesn't have link serialization support, I bet that
must break
--enable-link-serialization=1 builds with rust enabled.
See
r11-5142-gd326ebc94f3b2b0d962fb9e253564b39106a10da
r11-5190-ga774a6a2fbeaf7cbcb7a7afe433418f2d740b45b
commits what has been changed for other FEs.
The first change introduced some stuff that the second one reverted, so what is
needed
in rust/Make-lang.in is basically
rust.serial = rust1$(exeext)
and making
rust1$(exeext) depend on
$(rust.prev)
The generic code will ensure to fill in rust.prev to some other *.serial and
set some other *.prev to rust.serial as needed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rust/108113] Rust and --enable-link-serialization=1
2022-12-14 19:49 [Bug rust/108113] New: Rust and --enable-link-serialization=1 jakub at gcc dot gnu.org
@ 2022-12-14 19:59 ` dkm at gcc dot gnu.org
2022-12-14 21:01 ` dkm at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: dkm at gcc dot gnu.org @ 2022-12-14 19:59 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108113
Marc Poulhiès <dkm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |dkm at gcc dot gnu.org
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2022-12-14
Ever confirmed|0 |1
--- Comment #1 from Marc Poulhiès <dkm at gcc dot gnu.org> ---
Thanks Jakub! I'll fix that, thanks for the detailed report
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rust/108113] Rust and --enable-link-serialization=1
2022-12-14 19:49 [Bug rust/108113] New: Rust and --enable-link-serialization=1 jakub at gcc dot gnu.org
2022-12-14 19:59 ` [Bug rust/108113] " dkm at gcc dot gnu.org
@ 2022-12-14 21:01 ` dkm at gcc dot gnu.org
2022-12-16 18:35 ` tschwinge at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: dkm at gcc dot gnu.org @ 2022-12-14 21:01 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108113
Marc Poulhiès <dkm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://github.com/Rust-GCC
| |/gccrs/pull/1704
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rust/108113] Rust and --enable-link-serialization=1
2022-12-14 19:49 [Bug rust/108113] New: Rust and --enable-link-serialization=1 jakub at gcc dot gnu.org
2022-12-14 19:59 ` [Bug rust/108113] " dkm at gcc dot gnu.org
2022-12-14 21:01 ` dkm at gcc dot gnu.org
@ 2022-12-16 18:35 ` tschwinge at gcc dot gnu.org
2022-12-19 8:54 ` dkm at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: tschwinge at gcc dot gnu.org @ 2022-12-16 18:35 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108113
Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tschwinge at gcc dot gnu.org
--- Comment #2 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Marc, given Jakub's approval in
<https://github.com/Rust-GCC/gccrs/pull/1704#issuecomment-1352174564>, are you
going to push "rust: fix link serialization [PR108113]" to GCC upstream master
branch, too?
---
There's no reason, in opinion, to block such ongoing development/fixes on the
GCC/Rust backlog upstreaming process.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rust/108113] Rust and --enable-link-serialization=1
2022-12-14 19:49 [Bug rust/108113] New: Rust and --enable-link-serialization=1 jakub at gcc dot gnu.org
` (2 preceding siblings ...)
2022-12-16 18:35 ` tschwinge at gcc dot gnu.org
@ 2022-12-19 8:54 ` dkm at gcc dot gnu.org
2022-12-19 11:42 ` tschwinge at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: dkm at gcc dot gnu.org @ 2022-12-19 8:54 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108113
--- Comment #3 from Marc Poulhiès <dkm at gcc dot gnu.org> ---
I can yes, but wasn't really sure and didn't want to interfere with Arthur
ongoing work at updating the gcc's master branch with all the pending changes
from github.
Should I submit the patch for formal approval on gcc-patches@ or can I go ahead
and apply it directly ?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rust/108113] Rust and --enable-link-serialization=1
2022-12-14 19:49 [Bug rust/108113] New: Rust and --enable-link-serialization=1 jakub at gcc dot gnu.org
` (3 preceding siblings ...)
2022-12-19 8:54 ` dkm at gcc dot gnu.org
@ 2022-12-19 11:42 ` tschwinge at gcc dot gnu.org
2022-12-19 11:49 ` jakub at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: tschwinge at gcc dot gnu.org @ 2022-12-19 11:42 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108113
Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
--- Comment #4 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
No need for even more formalism than we already have. ;-)
Thus: 'git push', and then email <gcc-patches@gcc.gnu.org>, referring to
Jakub's <https://github.com/Rust-GCC/gccrs/pull/1704#issuecomment-1352174564>
approval.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rust/108113] Rust and --enable-link-serialization=1
2022-12-14 19:49 [Bug rust/108113] New: Rust and --enable-link-serialization=1 jakub at gcc dot gnu.org
` (4 preceding siblings ...)
2022-12-19 11:42 ` tschwinge at gcc dot gnu.org
@ 2022-12-19 11:49 ` jakub at gcc dot gnu.org
2022-12-20 8:12 ` cvs-commit at gcc dot gnu.org
2022-12-20 8:32 ` dkm at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-12-19 11:49 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108113
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Yeah.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rust/108113] Rust and --enable-link-serialization=1
2022-12-14 19:49 [Bug rust/108113] New: Rust and --enable-link-serialization=1 jakub at gcc dot gnu.org
` (5 preceding siblings ...)
2022-12-19 11:49 ` jakub at gcc dot gnu.org
@ 2022-12-20 8:12 ` cvs-commit at gcc dot gnu.org
2022-12-20 8:32 ` dkm at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-12-20 8:12 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108113
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Marc Poulhi?s <dkm@gcc.gnu.org>:
https://gcc.gnu.org/g:02c031088ac0bbf716aec52e027d615b7a5a572b
commit r13-4804-g02c031088ac0bbf716aec52e027d615b7a5a572b
Author: Marc Poulhiès <dkm@kataplop.net>
Date: Wed Dec 14 21:29:13 2022 +0100
rust: fix link serialization [PR108113]
The Make-lang.in was missing the link serialization support.
PR rust/108113
gcc/rust
* Make-lang.in (rust.serial): New variable.
(rust1$(exeext)): Depend on $(rust.prev). Call LINK_PROGRESS.
Signed-off-by: Marc Poulhiès <dkm@kataplop.net>
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rust/108113] Rust and --enable-link-serialization=1
2022-12-14 19:49 [Bug rust/108113] New: Rust and --enable-link-serialization=1 jakub at gcc dot gnu.org
` (6 preceding siblings ...)
2022-12-20 8:12 ` cvs-commit at gcc dot gnu.org
@ 2022-12-20 8:32 ` dkm at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: dkm at gcc dot gnu.org @ 2022-12-20 8:32 UTC (permalink / raw)
To: gcc-rust
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108113
Marc Poulhiès <dkm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #7 from Marc Poulhiès <dkm at gcc dot gnu.org> ---
Fixed in master.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-12-20 8:32 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-14 19:49 [Bug rust/108113] New: Rust and --enable-link-serialization=1 jakub at gcc dot gnu.org
2022-12-14 19:59 ` [Bug rust/108113] " dkm at gcc dot gnu.org
2022-12-14 21:01 ` dkm at gcc dot gnu.org
2022-12-16 18:35 ` tschwinge at gcc dot gnu.org
2022-12-19 8:54 ` dkm at gcc dot gnu.org
2022-12-19 11:42 ` tschwinge at gcc dot gnu.org
2022-12-19 11:49 ` jakub at gcc dot gnu.org
2022-12-20 8:12 ` cvs-commit at gcc dot gnu.org
2022-12-20 8:32 ` dkm at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).