public inbox for gcc-rust@gcc.gnu.org
 help / color / mirror / Atom feed
* [Bug rust/109853] New: WIN64 is a predefined constant on GCC MinGW-w64
@ 2023-05-14 12:22 mehdi.chinoune at hotmail dot com
  2023-05-14 12:24 ` [Bug rust/109853] WIN64 is a predefined constant by GCC on MinGW-w64 mehdi.chinoune at hotmail dot com
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: mehdi.chinoune at hotmail dot com @ 2023-05-14 12:22 UTC (permalink / raw)
  To: gcc-rust

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109853

            Bug ID: 109853
           Summary: WIN64 is a predefined constant on GCC MinGW-w64
           Product: gcc
           Version: 13.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rust
          Assignee: unassigned at gcc dot gnu.org
          Reporter: mehdi.chinoune at hotmail dot com
                CC: dkm at gcc dot gnu.org, gcc-rust at gcc dot gnu.org
  Target Milestone: ---

Building rust on MinGW-w64 fails because rust uses WIN64 as member of ABI enum
in gcc/rust/util/rust-abi.h
```
...
enum ABI
{
  UNKNOWN,
  RUST,
  INTRINSIC,
  C,
  CDECL,
  STDCALL,
  FASTCALL,
  WIN64,
  SYSV64
};
...
```
WIN64 is a defined to 1 on MinGW-w64
```
$ echo | gcc -dM -E - | grep WIN64
#define _WIN64 1
#define __WIN64 1
#define __WIN64__ 1
#define WIN64 1
```
So, Please consider choosing a different name for Windows ABI.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug rust/109853] WIN64 is a predefined constant by GCC on MinGW-w64
  2023-05-14 12:22 [Bug rust/109853] New: WIN64 is a predefined constant on GCC MinGW-w64 mehdi.chinoune at hotmail dot com
@ 2023-05-14 12:24 ` mehdi.chinoune at hotmail dot com
  2023-05-15  6:58 ` rguenth at gcc dot gnu.org
  2023-12-11 11:37 ` mehdi.chinoune at hotmail dot com
  2 siblings, 0 replies; 4+ messages in thread
From: mehdi.chinoune at hotmail dot com @ 2023-05-14 12:24 UTC (permalink / raw)
  To: gcc-rust

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109853

Chinoune <mehdi.chinoune at hotmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|WIN64 is a predefined       |WIN64 is a predefined
                   |constant on GCC MinGW-w64   |constant by GCC on
                   |                            |MinGW-w64

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug rust/109853] WIN64 is a predefined constant by GCC on MinGW-w64
  2023-05-14 12:22 [Bug rust/109853] New: WIN64 is a predefined constant on GCC MinGW-w64 mehdi.chinoune at hotmail dot com
  2023-05-14 12:24 ` [Bug rust/109853] WIN64 is a predefined constant by GCC on MinGW-w64 mehdi.chinoune at hotmail dot com
@ 2023-05-15  6:58 ` rguenth at gcc dot gnu.org
  2023-12-11 11:37 ` mehdi.chinoune at hotmail dot com
  2 siblings, 0 replies; 4+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-05-15  6:58 UTC (permalink / raw)
  To: gcc-rust

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109853

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |mingw-w64

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Eh.  It's of course equally bad to have a predefined macro in the
non-implementation namespace (but possibly it's required for MSVC
compatibility).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug rust/109853] WIN64 is a predefined constant by GCC on MinGW-w64
  2023-05-14 12:22 [Bug rust/109853] New: WIN64 is a predefined constant on GCC MinGW-w64 mehdi.chinoune at hotmail dot com
  2023-05-14 12:24 ` [Bug rust/109853] WIN64 is a predefined constant by GCC on MinGW-w64 mehdi.chinoune at hotmail dot com
  2023-05-15  6:58 ` rguenth at gcc dot gnu.org
@ 2023-12-11 11:37 ` mehdi.chinoune at hotmail dot com
  2 siblings, 0 replies; 4+ messages in thread
From: mehdi.chinoune at hotmail dot com @ 2023-12-11 11:37 UTC (permalink / raw)
  To: gcc-rust

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109853

Chinoune <mehdi.chinoune at hotmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Chinoune <mehdi.chinoune at hotmail dot com> ---
Reported and Fixed on their gccrs fork.
https://github.com/Rust-GCC/gccrs/issues/2768
https://github.com/Rust-GCC/gccrs/commit/35893295

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-12-11 11:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-14 12:22 [Bug rust/109853] New: WIN64 is a predefined constant on GCC MinGW-w64 mehdi.chinoune at hotmail dot com
2023-05-14 12:24 ` [Bug rust/109853] WIN64 is a predefined constant by GCC on MinGW-w64 mehdi.chinoune at hotmail dot com
2023-05-15  6:58 ` rguenth at gcc dot gnu.org
2023-12-11 11:37 ` mehdi.chinoune at hotmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).