public inbox for gcc-rust@gcc.gnu.org
 help / color / mirror / Atom feed
From: Philip Herron <philip.herron@embecosm.com>
To: Mark Wielaard <mark@klomp.org>, gcc-rust@gcc.gnu.org
Subject: Re: tuple indexes
Date: Wed, 23 Jun 2021 17:26:15 +0100	[thread overview]
Message-ID: <f1a31c2f-7e4d-9452-9246-caaf6e577e7f@embecosm.com> (raw)
In-Reply-To: <fcc70f22cf4f37a150da061aa90219cd1d69a97c.camel@klomp.org>


[-- Attachment #1.1: Type: text/plain, Size: 848 bytes --]

On 23/06/2021 17:06, Mark Wielaard wrote:
> Hi Philip,
>
> On Wed, 2021-06-23 at 10:55 +0100, Philip Herron wrote:
>> Small update, I think part of this issue is that the support for
>> unit-structs is not there yet in the compiler, so if you remove the unit
>> tuple struct and move the other struct definitions outside of the block
>> the test case works: https://godbolt.org/z/nb84sEaE4
>>
>> It might be enough to help with testing your tuple index fixes.
> Very nice. That workaround helps me get unblocked, except for testing
> empty struct tuples (unit-structs). But I have a patch for that, and
> even included a testcase to proof the parser now handles them. See
> attached.
>
> Cheers,
>
> Mark

This was a good find. Your patch is now being merged:
https://github.com/Rust-GCC/gccrs/pull/521

Thanks

--Phil



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 665 bytes --]

  reply	other threads:[~2021-06-23 16:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 22:51 Mark Wielaard
2021-06-23  9:47 ` Philip Herron
2021-06-23  9:55   ` Philip Herron
2021-06-23 16:06     ` Mark Wielaard
2021-06-23 16:26       ` Philip Herron [this message]
2021-06-23 20:15 ` Mark Wielaard
2021-06-24 10:22   ` Philip Herron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1a31c2f-7e4d-9452-9246-caaf6e577e7f@embecosm.com \
    --to=philip.herron@embecosm.com \
    --cc=gcc-rust@gcc.gnu.org \
    --cc=mark@klomp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).