small patch for sparc-linux-gnulibc1

small patch for sparc-linux-gnulibc1

[David S. Miller]

I can't get a clean build without the following change.

I'm not certain this is the correct fix though.  gbl-ctors.h has this
bit in it:

#if defined (WINNT) || defined (NEED_ATEXIT)
extern int atexit (void (*) (void));
#else
extern void atexit (void (*) (void));
#endif

It seems to me if NEED_ATEXIT is not defined, this means a prototype
extern is not necessary.  Perhaps someone can help figure out what
really should be happening here.

Fri Oct 17 17:09:05 1997  David S. Miller  <davem@tanya.rutgers.edu>

	* config/sparc/linux.h (NEED_ATEXIT): Define.

--- config/sparc/linux.h.~1~	Wed Sep 24 20:33:46 1997
+++ config/sparc/linux.h	Fri Oct 17 17:07:43 1997
@@ -27,6 +27,9 @@
 #undef HAVE_ATEXIT
 #define HAVE_ATEXIT
 
+#undef NEED_ATEXIT
+#define NEED_ATEXIT
+
 /* Linux uses ctype from glibc.a. I am not sure how complete it is.
    For now, we play safe. It may change later. */
 

Re: small patch for sparc-linux-gnulibc1

[Jeffrey A Law]

  In message < 199710172212.SAA04011@jenolan.rutgers.edu >you write:
  > 
  > I can't get a clean build without the following change.
  > 
  > I'm not certain this is the correct fix though.  gbl-ctors.h has this
  > bit in it:
  > 
  > #if defined (WINNT) || defined (NEED_ATEXIT)
  > extern int atexit (void (*) (void));
  > #else
  > extern void atexit (void (*) (void));
  > #endif
  > 
  > It seems to me if NEED_ATEXIT is not defined, this means a prototype
  > extern is not necessary.  Perhaps someone can help figure out what
  > really should be happening here.
  > 
  > Fri Oct 17 17:09:05 1997  David S. Miller  <davem@tanya.rutgers.edu>
  > 
  > 	* config/sparc/linux.h (NEED_ATEXIT): Define.
Hmmm.  At first I was going to say use autoconf for this, but it
seems to me that this is really a target issue, so autoconf doesn't
help.

Similarly for my comment about the gbl-ctors.h change in my last message.

So I'm not sure what to do.

Jeff

Re: small patch for sparc-linux-gnulibc1

[David S. Miller]

   Date: Sat, 18 Oct 1997 00:21:34 -0600
   From: Jeffrey A Law <law@cygnus.com>

   Hmmm.  At first I was going to say use autoconf for this, but it
   seems to me that this is really a target issue, so autoconf doesn't
   help.

   Similarly for my comment about the gbl-ctors.h change in my last
   message.

   So I'm not sure what to do.

I think the second extern should be blown away.  If the defines say "I
HAVE_ATEXIT" and "I do not NEED_ATEXIT" the extern should not be
there.  Else the meaning of these macros should be clarified.

Later,
David "Sparc" Miller
davem@caip.rutgers.edu

Re: small patch for sparc-linux-gnulibc1

[Andreas Schwab]

David S Miller <davem@jenolan.rutgers.edu> writes:

|> I can't get a clean build without the following change.

|> I'm not certain this is the correct fix though.  gbl-ctors.h has this
|> bit in it:

|> #if defined (WINNT) || defined (NEED_ATEXIT)
|> extern int atexit (void (*) (void));
|> #else
|> extern void atexit (void (*) (void));
|> #endif

|> It seems to me if NEED_ATEXIT is not defined, this means a prototype
|> extern is not necessary.  Perhaps someone can help figure out what
|> really should be happening here.

Note that the second prototype is broken anyway.  atexit has always
returned int, not void.

-- 
Andreas Schwab                                      "And now for something
schwab@issan.informatik.uni-dortmund.de              completely different"
schwab@gnu.org

Re: small patch for sparc-linux-gnulibc1

[David S. Miller]

   From: Andreas Schwab <schwab@issan.informatik.uni-dortmund.de>
   Date: 20 Oct 1997 11:07:10 +0200

   |> #if defined (WINNT) || defined (NEED_ATEXIT)
   |> extern int atexit (void (*) (void));
   |> #else
   |> extern void atexit (void (*) (void));
   |> #endif

   Note that the second prototype is broken anyway.  atexit has always
   returned int, not void.

Broken or not, all the libc5 based systems I do work on have that
prototype in both the headers and the man pages.  So we have to handle
it.

Later,
David S. Miller
davem@caip.rutgers.edu