except.c and expr.c warning reductions

except.c and expr.c warning reductions

[Robert Lipe]

It doesn't get the count down to zero, but the ones that are left
may be "real".



Tue Feb 10 00:05:56 1998  Robert Lipe   <robertl@dgii.com>

	* except.c (start_dynamic_cleanup): Remove unused variable 'dhc'.
	(expand_eh_region_start_tree): Remove unused variable 'note'.
	(exception_optimize): Remove unused variable 'regions'.
	(expand_builtin_eh_stub):  Remove unused variable 'temp'.
	(copy_eh_entry): Deleted.   Dead function.

        * expr.c (move_block_to_reg) Bracket declaration of 'pat' and 
	'last' with same #if HAVE_load_multiple as use of it.
	(move_block_from_reg): Likewise.
	(emit_move_insn_1): Remove unused variable 'insns'.
	(store_constructor): Bracket declaration of startb, endb with 
	#if TARGET_MEMFUNCTIONS.  Remove unused variables 'set_word_size' 
	'target', and 'xtarget'.
	(expand_builtin_setjmp): Remove unused variables 'op0', 
	'next_arg_reg', 'old_inhibit_defer_pop'.
	(expand_builtin): Remove unused variable 'offset'. 
	(do_store_flag): Remove unused variables 'pattern', 'jump_pat'.
	(emit_queue): Add parens for assignment used as conditional.
	(expand_expr): case TARGET_EXPR: Remove unused variable 'temp'.

	
Index: except.c
===================================================================
RCS file: /egcs/carton/cvsfiles/egcs/gcc/except.c,v
retrieving revision 1.33
diff -u -p -r1.33 except.c
--- except.c	1998/02/07 22:54:17	1.33
+++ except.c	1998/02/10 06:05:05
@@ -551,20 +551,6 @@ top_label_entry (stack)
   return (*stack)->u.tlabel;
 }
 
-/* Make a copy of ENTRY using xmalloc to allocate the space.  */
-
-static struct eh_entry *
-copy_eh_entry (entry)
-     struct eh_entry *entry;
-{
-  struct eh_entry *newentry;
-
-  newentry = (struct eh_entry *) xmalloc (sizeof (struct eh_entry));
-  bcopy ((char *) entry, (char *) newentry, sizeof (struct eh_entry));
-
-  return newentry;
-}
-
 /* Push a new eh_node entry onto STACK.  */
 
 static void
@@ -855,7 +841,7 @@ start_dynamic_cleanup (func, arg)
      tree func;
      tree arg;
 {
-  rtx dhc, dcc;
+  rtx dcc;
   rtx new_func, new_arg;
   rtx x, buf;
   int size;
@@ -984,8 +970,6 @@ expand_eh_region_start_tree (decl, clean
      tree decl;
      tree cleanup;
 {
-  rtx note;
-
   /* This is the old code.  */
   if (! doing_eh (0))
     return 0;
@@ -2016,7 +2000,7 @@ scan_region (insn, n, delete_outer)
 void
 exception_optimize ()
 {
-  rtx insn, regions = NULL_RTX;
+  rtx insn;
   int n;
 
   /* Remove empty regions.  */
@@ -2160,7 +2144,7 @@ expand_builtin_eh_stub ()
 {
   rtx stub_start = gen_label_rtx ();
   rtx after_stub = gen_label_rtx ();
-  rtx handler, offset, temp;
+  rtx handler, offset ;
 
   emit_jump (after_stub);
   emit_label (stub_start);
Index: expr.c
===================================================================
RCS file: /egcs/carton/cvsfiles/egcs/gcc/expr.c,v
retrieving revision 1.36
diff -u -p -r1.36 expr.c
--- expr.c	1998/02/07 23:26:08	1.36
+++ expr.c	1998/02/10 06:05:24
@@ -499,7 +499,7 @@ void
 emit_queue ()
 {
   register rtx p;
-  while (p = pending_chain)
+  while ((p = pending_chain))
     {
       QUEUED_INSN (p) = emit_insn (QUEUED_BODY (p));
       pending_chain = QUEUED_NEXT (p);
@@ -1657,7 +1657,10 @@ move_block_to_reg (regno, x, nregs, mode
      enum machine_mode mode;
 {
   int i;
-  rtx pat, last;
+#ifdef HAVE_load_multiple
+  rtx pat; 
+  rtx last;
+#endif
 
   if (nregs == 0)
     return;
@@ -1700,7 +1703,10 @@ move_block_from_reg (regno, x, nregs, si
      int size;
 {
   int i;
-  rtx pat, last;
+#ifdef HAVE_store_multiple
+  rtx pat; 
+  rtx last;
+#endif
   enum machine_mode mode;
 
   /* If SIZE is that of a mode no bigger than a word, just use that
@@ -2221,7 +2227,6 @@ emit_move_insn_1 (x, y)
     {
       /* Don't split destination if it is a stack push.  */
       int stack = push_operand (x, GET_MODE (x));
-      rtx insns;
 
       /* If this is a stack, push the highpart first, so it
 	 will be in the argument order.
@@ -2265,7 +2270,6 @@ emit_move_insn_1 (x, y)
   else if (GET_MODE_SIZE (mode) > UNITS_PER_WORD)
     {
       rtx last_insn = 0;
-      rtx insns;
       
 #ifdef PUSH_ROUNDING
 
@@ -3883,8 +3887,6 @@ store_constructor (exp, target, cleared)
   else if (TREE_CODE (type) == SET_TYPE)
     {
       tree elt = CONSTRUCTOR_ELTS (exp);
-      rtx xtarget = XEXP (target, 0);
-      int set_word_size = TYPE_ALIGN (type);
       int nbytes = int_size_in_bytes (type), nbits;
       tree domain = TYPE_DOMAIN (type);
       tree domain_min, domain_max, bitlength;
@@ -3991,7 +3993,9 @@ store_constructor (exp, target, cleared)
 	  tree startbit = TREE_PURPOSE (elt);
 	  /* end of range of element, or element value */
 	  tree endbit   = TREE_VALUE (elt);
+#ifdef TARGET_MEM_FUNCTIONS
 	  HOST_WIDE_INT startb, endb;
+#endif
 	  rtx  bitlength_rtx, startbit_rtx, endbit_rtx, targetx;
 
 	  bitlength_rtx = expand_expr (bitlength,
@@ -6954,7 +6958,6 @@ expand_expr (exp, target, tmode, modifie
 	tree slot = TREE_OPERAND (exp, 0);
 	tree cleanups = NULL_TREE;
 	tree exp1;
-	rtx temp;
 
 	if (TREE_CODE (slot) != VAR_DECL)
 	  abort ();
@@ -7621,9 +7624,6 @@ expand_builtin_setjmp (buf_addr, target,
   rtx lab1 = gen_label_rtx ();
   enum machine_mode sa_mode = Pmode, value_mode;
   rtx stack_save;
-  int old_inhibit_defer_pop = inhibit_defer_pop;
-  rtx next_arg_reg;
-  rtx op0;
   int i;
 
   value_mode = TYPE_MODE (integer_type_node);
@@ -8098,9 +8098,12 @@ expand_builtin (exp, target, subtarget, 
     case BUILT_IN_ARGS_INFO:
       {
 	int nwords = sizeof (CUMULATIVE_ARGS) / sizeof (int);
-	int i;
 	int *word_ptr = (int *) &current_function_args_info;
+#if 0	
+	/* These are used by the code below that is if 0'ed away */
+	int i;
 	tree type, elts, result;
+#endif
 
 	if (sizeof (CUMULATIVE_ARGS) % sizeof (int) != 0)
 	  fatal ("CUMULATIVE_ARGS type defined badly; see %s, line %d",
@@ -8614,7 +8617,6 @@ expand_builtin (exp, target, subtarget, 
       {
 	tree arg1 = TREE_VALUE (arglist);
 	tree arg2 = TREE_VALUE (TREE_CHAIN (arglist));
-	tree offset;
 	tree len, len2;
 
 	len = c_strlen (arg1);
@@ -10464,7 +10466,7 @@ do_store_flag (exp, target, mode, only_c
   rtx op0, op1;
   enum insn_code icode;
   rtx subtarget = target;
-  rtx result, label, pattern, jump_pat;
+  rtx result, label;
 
   /* If this is a TRUTH_NOT_EXPR, set a flag indicating we must invert the
      result at the end.  We can't simply invert the test since it would

Re: except.c and expr.c warning reductions

[Jeffrey A Law]

  In message < 19980210001057.27203@dgii.com >you write:
  > It doesn't get the count down to zero, but the ones that are left
  > may be "real".
Yup -- and at least we can see those that may indicate real bugs
now!  Yippie!

  > Tue Feb 10 00:05:56 1998  Robert Lipe   <robertl@dgii.com>
  > 
  > 	* except.c (start_dynamic_cleanup): Remove unused variable 'dhc'.
  > 	(expand_eh_region_start_tree): Remove unused variable 'note'.
  > 	(exception_optimize): Remove unused variable 'regions'.
  > 	(expand_builtin_eh_stub):  Remove unused variable 'temp'.
  > 	(copy_eh_entry): Deleted.   Dead function.
  > 
  >         * expr.c (move_block_to_reg) Bracket declaration of 'pat' and 
  > 	'last' with same #if HAVE_load_multiple as use of it.
  > 	(move_block_from_reg): Likewise.
  > 	(emit_move_insn_1): Remove unused variable 'insns'.
  > 	(store_constructor): Bracket declaration of startb, endb with 
  > 	#if TARGET_MEMFUNCTIONS.  Remove unused variables 'set_word_size' 
  > 	'target', and 'xtarget'.
  > 	(expand_builtin_setjmp): Remove unused variables 'op0', 
  > 	'next_arg_reg', 'old_inhibit_defer_pop'.
  > 	(expand_builtin): Remove unused variable 'offset'. 
  > 	(do_store_flag): Remove unused variables 'pattern', 'jump_pat'.
  > 	(emit_queue): Add parens for assignment used as conditional.
  > 	(expand_expr): case TARGET_EXPR: Remove unused variable 'temp'.
Installed.  You introduced one spacing/formatting problem which I
fixed :-)

Thanks!
jeff