public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* i386 ffs patch
@ 1998-03-27  4:21 Richard Henderson
  1998-04-02  9:35 ` Jim Wilson
  1998-04-04 11:01 ` Ulrich Drepper
  0 siblings, 2 replies; 3+ messages in thread
From: Richard Henderson @ 1998-03-27  4:21 UTC (permalink / raw)
  To: drepper; +Cc: scox, egcs

Here's a better patch for the LFFSSI0 label bogosity you mentioned
to me earlier today.  Here we expand the entire pattern into rtl at
the beginning, which makes for happier code.


r~

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: i386 ffs patch
  1998-03-27  4:21 i386 ffs patch Richard Henderson
@ 1998-04-02  9:35 ` Jim Wilson
  1998-04-04 11:01 ` Ulrich Drepper
  1 sibling, 0 replies; 3+ messages in thread
From: Jim Wilson @ 1998-04-02  9:35 UTC (permalink / raw)
  To: Richard Henderson; +Cc: drepper, scox, egcs

The patch looks good to me.

Jim

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: i386 ffs patch
  1998-03-27  4:21 i386 ffs patch Richard Henderson
  1998-04-02  9:35 ` Jim Wilson
@ 1998-04-04 11:01 ` Ulrich Drepper
  1 sibling, 0 replies; 3+ messages in thread
From: Ulrich Drepper @ 1998-04-04 11:01 UTC (permalink / raw)
  To: Richard Henderson; +Cc: scox, egcs

Using this patch failed this in this part

> ! (define_insn "ffssi_1"
> !   [(set (match_operand:SI 0 "register_operand" "=r")
> ! 	(unspec:SI [(match_operand:SI 1 "nonimmediate_operand" "rm")] 5))]
>     ""
> !   "* return AS2 (bsf%L0,%1,%0);")
>   
> ! (define_expand "ffshi2"
> !   [(set (match_operand:SI 0 "general_operand" "") 
> ! 	(ffs:HI (match_operand:HI 1 "general_operand" "")))]
>     ""
> !   "
>   {
> !   rtx label = gen_label_rtx (), temp = gen_reg_rtx (HImode);
>   
> !   emit_insn (gen_ffshi_1 (temp, operands[1]));

there is no function gen_ffshi_1 found.  Could it be that the last
line must be

	emit_insn (gen_ffssi_1 (temp, operands[1]));

??

-- Uli
---------------.      drepper at gnu.org  ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Cygnus Solutions `--' drepper at cygnus.com   `------------------------

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~1998-04-04 11:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1998-03-27  4:21 i386 ffs patch Richard Henderson
1998-04-02  9:35 ` Jim Wilson
1998-04-04 11:01 ` Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).