* "make check" is broken in binutils
@ 2003-05-20 16:15 H. J. Lu
2003-05-20 16:29 ` PATCH: " H. J. Lu
0 siblings, 1 reply; 3+ messages in thread
From: H. J. Lu @ 2003-05-20 16:15 UTC (permalink / raw)
To: neroden; +Cc: gcc, binutils
This patch:
2003-05-19 Nathanael Nerode <neroden@gcc.gnu.org>
* configure.in: Switch more things to use maybe dependencies.
* Makefile.tpl: Switch more things to use maybe dependencies.
Factor out common code from autogen IF statements.
* configure: Regenerate.
* Makefile.in: Regenerate.
breaks "make check" in binutils. I got
make[3]: *** No rule to make target `maybe-check-gcc', needed by `do-che
ck'.
Could you please fix it?
Thanks.
H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread
* PATCH: "make check" is broken in binutils
2003-05-20 16:15 "make check" is broken in binutils H. J. Lu
@ 2003-05-20 16:29 ` H. J. Lu
2003-05-20 16:47 ` DJ Delorie
0 siblings, 1 reply; 3+ messages in thread
From: H. J. Lu @ 2003-05-20 16:29 UTC (permalink / raw)
To: neroden, gcc-patches; +Cc: gcc, binutils
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Tue, May 20, 2003 at 08:53:40AM -0700, H. J. Lu wrote:
> This patch:
>
> 2003-05-19 Nathanael Nerode <neroden@gcc.gnu.org>
>
> * configure.in: Switch more things to use maybe dependencies.
> * Makefile.tpl: Switch more things to use maybe dependencies.
> Factor out common code from autogen IF statements.
> * configure: Regenerate.
> * Makefile.in: Regenerate.
>
> breaks "make check" in binutils. I got
>
> make[3]: *** No rule to make target `maybe-check-gcc', needed by `do-che
> ck'.
>
> Could you please fix it?
>
> Thanks.
I am testing this patch.
H.J.
[-- Attachment #2: top-check.patch --]
[-- Type: text/plain, Size: 1304 bytes --]
2003-05-20 H.J. Lu <hongjiu.lu@intel.com>
* Makefile.tpl (do-check): Change maybe-check-gcc to
@maybe_check_gcc@.
* Makefile.in: Regenerated.
* configure.in (maybe_check_gcc): New and substitute. Defined
as maybe-check-gcc for gcc.
* configure: Regenerated.
--- binutils/Makefile.tpl.check 2003-05-20 08:38:03.000000000 -0700
+++ binutils/Makefile.tpl 2003-05-20 09:11:47.000000000 -0700
@@ -743,7 +743,7 @@ check:
$(MAKE) do-check NOTPARALLEL=parallel-ok
# Only include modules actually being configured and built.
-do-check: maybe-check-gcc [+
+do-check: @maybe_check_gcc@ [+
FOR host_modules +] \
maybe-check-[+module+][+
ENDFOR host_modules +][+
--- binutils/configure.in.check 2003-05-20 08:38:03.000000000 -0700
+++ binutils/configure.in 2003-05-20 09:11:27.000000000 -0700
@@ -100,6 +100,9 @@ else
esac
fi
fi
+if test x${gcc_version_trigger} != x; then
+ maybe_check_gcc="maybe-check-gcc"
+fi
### To add a new directory to the tree, first choose whether it is a target
### or a host dependent tool. Then put it into the appropriate list
@@ -1974,6 +1977,7 @@ AC_SUBST(BUILD_PREFIX)
AC_SUBST(BUILD_PREFIX_1)
AC_SUBST(configlinks)
AC_SUBST(gcc_version_trigger)
+AC_SUBST(maybe_check_gcc)
AC_SUBST(gcc_version)
AC_SUBST(tooldir)
AC_SUBST(build_tooldir)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: "make check" is broken in binutils
2003-05-20 16:29 ` PATCH: " H. J. Lu
@ 2003-05-20 16:47 ` DJ Delorie
0 siblings, 0 replies; 3+ messages in thread
From: DJ Delorie @ 2003-05-20 16:47 UTC (permalink / raw)
To: hjl; +Cc: neroden, gcc-patches, gcc, binutils
> I am testing this patch.
Don't bother, it's wrong. The whole point of the maybe-targets is
that you can always depend on them, and they'll decide if they need to
actually do something or not. So the problem is that maybe-check-gcc
isn't always there, not that you have to assume it's not always there.
> -do-check: maybe-check-gcc [+
> +do-check: @maybe_check_gcc@ [+
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-05-20 16:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-20 16:15 "make check" is broken in binutils H. J. Lu
2003-05-20 16:29 ` PATCH: " H. J. Lu
2003-05-20 16:47 ` DJ Delorie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).