The newly built libgcc_s.so.1 is never used for "make check"

The newly built libgcc_s.so.1 is never used for "make check"

[H. J. Lu]

The newly built libgcc_s.so.1 may not be used for "make check". It
leads to 2 problems:

1. The newly built libgcc_s.so.1 may be fully tested by "make check".
2. Those tests which won't work with old libgcc_s.so.1 may fail.

This patch

http://gcc.gnu.org/ml/gcc-patches/2004-07/msg01881.html

tries to fix PR 16633. There is another bug

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17311

Could someone please review my patch?

Thanks.


H.J.

Re: The newly built libgcc_s.so.1 is never used for "make check"

[H. J. Lu]

On Fri, Sep 03, 2004 at 01:51:34PM -0700, H. J. Lu wrote:
> The newly built libgcc_s.so.1 may not be used for "make check". It
> leads to 2 problems:
> 
> 1. The newly built libgcc_s.so.1 may be fully tested by "make check".
> 2. Those tests which won't work with old libgcc_s.so.1 may fail.
> 
> This patch
> 
> http://gcc.gnu.org/ml/gcc-patches/2004-07/msg01881.html
> 
> tries to fix PR 16633. There is another bug
> 
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17311
> 
> Could someone please review my patch?

PR 17311 has something do to with libtool which can't handle mixed
shared libraries built with and without libtool. In this case, the
shared libgcj is built with libtool and libgcc_s.so.1 isn't. gij is
linked with both libgcj and libgcc_s.so.1. When gij is run during
"make check", the build directory of libgcj is put into DT_RPATH
of lt-gij before the install directory while the build directory of
libgcc_s.so.1 isn't. As the result, if there is an installed
libgcc_s.so.1, it will be used by lt-gij. Setting LD_LIBRARY_PATH won't
change it.

There is a libtool bug. I don't see why libtool should leave the
install directory in DT_RPATH for lt-xxx at all. It works if all
shared libraries are built with libtool. But it isn't the case
for gcc.


H.J.