Re: Using gcc/ChangeLog instead of gcc/testsuite/ChangeLog?

[Segher Boessenkool <segher@kernel.crashing.org>]

Hi!

On Sat, Aug 10, 2019 at 12:12:46PM +0200, Jakub Jelinek wrote:
> On Sat, Aug 10, 2019 at 08:53:45AM +0200, Hans-Peter Nilsson wrote:
> > Has there been a change of policy so it's a valid option to use
> > gcc/ChangeLog for testsuite changes?  I was about to move a
> > semi-randomly spotted misplaced entry, and when checking if
> > there were others, I noticed that there's like tens of them, so
> > I thought better ask.
> 
> Nothing in the policy changed.  While we have mklog that helps with the job,
> it is still mostly hand written stuff and people make occassionally
> mistakes, that can happen to anyone.  Admittedly some people repeat those
> mistakes often.

It's why I started doing those
gcc/testsuite/
things in the changelogs in the patches I send, to remind me what file
to apply what to.  It helps :-)

> I ran the gcc/ subdirectory ChangeLogs through following script that doesn't
> seem to have false positives ATM and highlights some common mistakes people
> make and fixed them, see patch below.

Cool, thank you!

> Another common mistake is more than 2 newline characters in sequence.

Git goes as far as not allowing it in a log message (with standard
configurations, with the standard frontend tools).  Drives me nuts, I
use it for formatting all the time.


Segher