public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Jan-Benedict Glaw <jbglaw@lug-owl.de>
Cc: Aldy Hernandez <aldyh@redhat.com>,
	David Edelsohn <dje.gcc@gmail.com>, Kewen Lin <linkw@gcc.gnu.org>,
	gcc@gcc.gnu.org
Subject: Re: --target=powerpc64-linux_altivec: Use rs6000_linux64_override_options()?
Date: Fri, 28 Oct 2022 16:13:04 -0500	[thread overview]
Message-ID: <20221028211304.GF25951@gate.crashing.org> (raw)
In-Reply-To: <20221028200741.dau6ut2edeq5cusw@lug-owl.de>

On Fri, Oct 28, 2022 at 10:07:41PM +0200, Jan-Benedict Glaw wrote:
> On Fri, 2022-10-28 14:19:10 -0500, Segher Boessenkool <segher@kernel.crashing.org> wrote:
> > Why do you use powerpc64-linux_altivec?  This things (normally spelled
> > with a dash, not and underscore, btw) was made for 32-bit targets.  It
> > never has done anything useful for 64-bit targets, afaik?
> 
> Because it's listed in ./contrib/config-list.mk:
> 
> /var/cache/git/gcc [master] # make -f contrib/config-list.mk show | tr ' ' $'\n' | grep altivec
> powerpc-eabisimaltivec
> powerpc-eabialtivec
> powerpc64-linux_altivec

Huh.  Okay, that is a bug.  Has that target ever worked (or
alternatively, has it ever existed at all, other than it is recognised
by config.gcc by not very tight REs)?

> It seems to be on the target list since the very beginning, when
> config-list.mk was created by Joern Rennecke. So somebody cared about
> this configuration I guess?

No idea.  rs6000_altivec_abi is always forced on on any linux
configuration that has VMX or VSX or 64 bit enabled:
===
  /* The AltiVec ABI is the default for PowerPC-64 GNU/Linux.  For
     PowerPC-32 GNU/Linux, -maltivec implies the AltiVec ABI.  It can
     be explicitly overridden in either case.  */
  if (TARGET_ELF)
    {
      if (!OPTION_SET_P (rs6000_altivec_abi)
          && (TARGET_64BIT || TARGET_ALTIVEC || TARGET_VSX))
        {
          if (main_target_opt != NULL &&
              !main_target_opt->x_rs6000_altivec_abi)
            error ("target attribute or pragma changes AltiVec ABI");
          else
            rs6000_altivec_abi = 1;
        }
    }
===

>   If this configuration isn't ment to be used, we'd just drop it from
> the list I guess.

Yeah, the config makes no sense.

Thanks,


Segher

      reply	other threads:[~2022-10-28 21:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-28 17:34 Jan-Benedict Glaw
2022-10-28 19:19 ` Segher Boessenkool
2022-10-28 20:07   ` Jan-Benedict Glaw
2022-10-28 21:13     ` Segher Boessenkool [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221028211304.GF25951@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=aldyh@redhat.com \
    --cc=dje.gcc@gmail.com \
    --cc=gcc@gcc.gnu.org \
    --cc=jbglaw@lug-owl.de \
    --cc=linkw@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).