From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Aldy Hernandez <aldyh@redhat.com>,
David Edelsohn <dje.gcc@gmail.com>, Kewen Lin <linkw@gcc.gnu.org>,
gcc@gcc.gnu.org
Subject: Re: --target=powerpc64-linux_altivec: Use rs6000_linux64_override_options()?
Date: Fri, 28 Oct 2022 22:07:41 +0200 [thread overview]
Message-ID: <20221028200741.dau6ut2edeq5cusw@lug-owl.de> (raw)
In-Reply-To: <20221028191910.GE25951@gate.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 1791 bytes --]
Hi!
On Fri, 2022-10-28 14:19:10 -0500, Segher Boessenkool <segher@kernel.crashing.org> wrote:
> On Fri, Oct 28, 2022 at 07:34:24PM +0200, Jan-Benedict Glaw wrote:
> > While checking my bot build logs, I noticed that GCC configured for
> > --target=powerpc64-linux_altivec will pull in linux64.h and
> > linuxaltivec.h .
> >
> > linux64.h
> > * Will "#define TARGET_USES_LINUX64_OPT 1" (to make static void
> > rs6000_linux64_override_options() available in rs6000.cc).
> > * Will "#define SUBSUBTARGET_OVERRIDE_OPTIONS" to use
> > rs6000_linux64_override_options().
> >
> > linuxaltivec.h OTOH
> > * Will undef / "#define SUBSUBTARGET_OVERRIDE_OPTIONS rs6000_altivec_abi = 1"
> > and thus no longer use rs6000_linux64_override_options()
> > * That triggers a warning (unused-function).
> >
> > To silence that warning, should linuxaltivec.h undefine
> > TARGET_USES_LINUX64_OPT? Or set rs6000_altivec_abi=1 and call
> > rs6000_linux64_override_options()?
>
> Why do you use powerpc64-linux_altivec? This things (normally spelled
> with a dash, not and underscore, btw) was made for 32-bit targets. It
> never has done anything useful for 64-bit targets, afaik?
Because it's listed in ./contrib/config-list.mk:
/var/cache/git/gcc [master] # make -f contrib/config-list.mk show | tr ' ' $'\n' | grep altivec
powerpc-eabisimaltivec
powerpc-eabialtivec
powerpc64-linux_altivec
> (And not for 32-bit targets either really, but that is another issue.)
It seems to be on the target list since the very beginning, when
config-list.mk was created by Joern Rennecke. So somebody cared about
this configuration I guess?
If this configuration isn't ment to be used, we'd just drop it from
the list I guess.
MfG, JBG
--
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2022-10-28 20:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 17:34 Jan-Benedict Glaw
2022-10-28 19:19 ` Segher Boessenkool
2022-10-28 20:07 ` Jan-Benedict Glaw [this message]
2022-10-28 21:13 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221028200741.dau6ut2edeq5cusw@lug-owl.de \
--to=jbglaw@lug-owl.de \
--cc=aldyh@redhat.com \
--cc=dje.gcc@gmail.com \
--cc=gcc@gcc.gnu.org \
--cc=linkw@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).