From: Ben Boeckel <ben.boeckel@kitware.com>
To: Damien Guibouret <damien.guibouret@partition-saving.com>
Cc: Jason Merrill <jason@redhat.com>, gcc@gcc.gnu.org
Subject: Re: [PATCH v6 1/4] libcpp: reject codepoints above 0x10FFFF
Date: Tue, 20 Jun 2023 15:49:46 -0400 [thread overview]
Message-ID: <20230620194946.GB186848@farprobe> (raw)
In-Reply-To: <dbd0a992-26f5-ea97-546d-4846d708535f@partition-saving.com>
On Tue, Jun 20, 2023 at 21:16:40 +0200, Damien Guibouret wrote:
> I think the comparison should be ">" instead of ">=" as 0x10ffff seems a
> valid value (Unicode says value above 0x10ffff is invalid).
> Other tests around same value in this file are using ">".
Ah, good catch. I'll make a separate patch submission for that.
--Ben
next prev parent reply other threads:[~2023-06-20 19:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 20:50 [PATCH v6 0/4] P1689R5 support Ben Boeckel
2023-06-06 20:50 ` [PATCH v6 1/4] libcpp: reject codepoints above 0x10FFFF Ben Boeckel
2023-06-19 21:34 ` Jason Merrill
2023-06-20 19:16 ` Damien Guibouret
2023-06-20 19:49 ` Ben Boeckel [this message]
2023-06-06 20:50 ` [PATCH v6 2/4] p1689r5: initial support Ben Boeckel
2023-06-06 20:50 ` [PATCH v6 3/4] c++modules: report imported CMI files as dependencies Ben Boeckel
2023-06-06 20:50 ` [PATCH v6 4/4] c++modules: report module mapper files as a dependency Ben Boeckel
2023-06-08 17:59 ` [PATCH v6 0/4] P1689R5 support Maxim Kuvyrkov
2023-06-16 19:48 ` Ben Boeckel
2023-06-16 23:15 ` Ben Boeckel
2023-06-17 3:55 ` Jason Merrill
2023-06-17 14:43 ` Ben Boeckel
2023-06-20 0:54 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230620194946.GB186848@farprobe \
--to=ben.boeckel@kitware.com \
--cc=damien.guibouret@partition-saving.com \
--cc=gcc@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).