public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Eric Batchelor <eric@bookmanager.com>
To: gcc@gcc.gnu.org
Subject: Expected warning maybe-uninitialized does not appear using g++13.2.0?
Date: Wed, 20 Dec 2023 11:16:47 -0800	[thread overview]
Message-ID: <31bdc2a5-3556-4ccb-8a91-723ccd71652c@bookmanager.com> (raw)

Hello, I unintentionally stumbled upon some strange behaviour that 
occurred due to a typo.
I reproduced the behaviour where an object (std::string in my case) can 
be passed to a function by reference, uninitialized, WITHOUT a compiler 
warning.
Changing the code to pass the object by value DOES emit the warning.
I don't think the compiled code is incorrect, it segfaults presumably 
due to uninitialized members.
I understand there may seldom be a reason to use uninitialized objects, 
so "don't do that," but as I said this was unintentional and it seems 
that it should have generated a warning, which have saved some 
head-scratching.

Code to reproduce:

#include <string>
std::string f(std::string &s) {
   s.append("x");
   return s;
}
int main() {
   std::string a = f(a);
}

Compile and run (no warning):

$ g++ -o uninit_obj uninit_obj.cpp -std=c++23 -Wall -Wpedantic -Wextra 
&& ./uninit_obj
Segmentation fault (core dumped)

No difference whether using -O0 (or 1 2 3)

If I change the function to pass by value, std::string f(std::string s), 
and rerun, I get the expected compiler warning:

$ g++ -o uninit_obj uninit_obj.cpp -std=c++23 -Wall -Wpedantic -Wextra 
&& ./uninit_obj
uninit_obj.cpp: In function 'int main()':
uninit_obj.cpp:7:22: warning: 'a' may be used uninitialized 
[-Wmaybe-uninitialized]
     7 |   std::string a = f(a);
[...]
terminate called after throwing an instance of 'std::bad_alloc'
   what():  std::bad_alloc
Aborted (core dumped)

Output from g++ -v:

Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/local/gcc13/libexec/gcc/x86_64-pc-linux-gnu/13.2.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: ../gcc-13.2.0/configure --disable-multilib 
--enable-languages=c,c++ --prefix=/usr/local/gcc13 --program-suffix=-13 
--enable-libstdcxx-backtrace=yes
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 13.2.0 (GCC)

Thanks

             reply	other threads:[~2023-12-20 19:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-20 19:16 Eric Batchelor [this message]
2023-12-22  3:43 ` David Malcolm
2023-12-22  4:45   ` Marc Glisse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31bdc2a5-3556-4ccb-8a91-723ccd71652c@bookmanager.com \
    --to=eric@bookmanager.com \
    --cc=gcc@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).