Non-portable test?

Non-portable test?

[Yuri Gribov]

Hi all,

This is my first post to the list so do not be too harsh)

I have expected all c-torture tests to be highly portable but I have
recently ran into test which relies on int being 32-bit
(execute/980526-2.c).

The test runs to_kdev_t(0x12345678) (see below) and verifies that
result equals 0x15800078. But this is true only with 32-bit ints. With
64-bits we have 0x48d15800078.

static inline kdev_t to_kdev_t(int dev)
{
   int major, minor;

   if (sizeof(kdev_t) == 16)
       return (kdev_t)dev;
   major = (dev >> 8);
   minor = (dev & 0xff);
   return ((( major ) << 22 ) | (  minor )) ;
}

Shouldn't we modify a precondition in main:
   if (sizeof (int) < 4)
     exit (0);
to be
   if (sizeof (int) != 4)
     exit (0);
or better
   if( sizeof(int)*CHAR_BIT != 32 )
     exit(0)
?

Best regards,
Yuri

Re: Non-portable test?

[Paolo Bonzini]

On 09/23/2009 10:44 AM, Yuri Gribov wrote:
> Hi all,
>
> This is my first post to the list so do not be too harsh)
>
> I have expected all c-torture tests to be highly portable but I have
> recently ran into test which relies on int being 32-bit
> (execute/980526-2.c).

Yes, it's possible that 64-bit ints are not supported by the testsuite. 
  Changes to fix that are welcome.

Paolo

Re: Non-portable test?

[Yuri Gribov]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

> Yes, it's possible that 64-bit ints are not supported by the testsuite.
>  Changes to fix that are welcome.

I am not a gcc developer. Could someone verify and commit this patch
for testsuite/gcc.c-torture/execute/980526-2.c?

Best regards,
Yuri

[-- Attachment #2: 980526-2.patch --]
[-- Type: application/octet-stream, Size: 411 bytes --]

--- ../Download/trunk/gcc/testsuite/gcc.c-torture/execute/980526-2.c	2009-09-23 12:07:09.000000000 +0400
+++ 980526-2.c	2009-09-23 12:10:32.000000000 +0400
@@ -1,3 +1,5 @@
+#include <limits.h>
+
 typedef unsigned int dev_t;
 typedef unsigned int kdev_t;
 
@@ -50,7 +52,7 @@
 
 int main(void)
 {
-	if (sizeof (int) < 4)
+	if (sizeof (int)*CHAR_BIT != 32)
 	  exit (0);
 
 	return sys_mknod("test",1,0x12345678);

Re: Non-portable test?

[Yuri Gribov]

> Done.  But if you have more cases, please report them.
Not yet. Thx!

-- 
Best regards,
Yuri