FW: Build failed in Jenkins: BuildThunderX_native_gcc_upstream #1267

FW: Build failed in Jenkins: BuildThunderX_native_gcc_upstream #1267

[Pinski, Andrew]

One of the following revision caused a bootstrap comparison failure on aarch64-linux-gnu:
r246225 
r246226
r246227

Thanks,
Andrew Pinski

Ignore the URLs in the log file below, this is a Jenkins to Cavium.

-----Original Message-----
From: jenkins@cavium.com [mailto:jenkins@cavium.com] 
Sent: Friday, March 17, 2017 11:00 AM
To: Pinski, Andrew <Andrew.Pinski@cavium.com>
Subject: Build failed in Jenkins: BuildThunderX_native_gcc_upstream #1267

------------------------------------------
rm -f stage_current
make[3]: Leaving directory '<http://toolchain-releases.caveonetworks.com:8080/job/BuildThunderX_native_gcc_upstream/ws/objdir'>
Comparing stages 2 and 3
Bootstrap comparison failure!
gcc/lto/lto.o differs
libcpp/line-map.o differs
Makefile:24072: recipe for target 'compare' failed
make[2]: *** [compare] Error 1
make[2]: Leaving directory '<http://toolchain-releases.caveonetworks.com:8080/job/BuildThunderX_native_gcc_upstream/ws/objdir'>
Makefile:24051: recipe for target 'stage3-bubble' failed
make[1]: *** [stage3-bubble] Error 2
make[1]: Leaving directory '<http://toolchain-releases.caveonetworks.com:8080/job/BuildThunderX_native_gcc_upstream/ws/objdir'>
Makefile:931: recipe for target 'all' failed
make: *** [all] Error 2
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts

Re: FW: Build failed in Jenkins: BuildThunderX_native_gcc_upstream #1267

[Bernd Schmidt]

On 03/17/2017 07:38 PM, Pinski, Andrew wrote:
> One of the following revision caused a bootstrap comparison failure on aarch64-linux-gnu:
> r246225
> r246226
> r246227

Can you help narrow that down?


Bernd

Re: FW: Build failed in Jenkins: BuildThunderX_native_gcc_upstream #1267

[Jeff Law]

On 03/17/2017 12:47 PM, Bernd Schmidt wrote:
> On 03/17/2017 07:38 PM, Pinski, Andrew wrote:
>> One of the following revision caused a bootstrap comparison failure on
>> aarch64-linux-gnu:
>> r246225
>> r246226
>> r246227
>
> Can you help narrow that down?
I'm provisioning an aarch64 system now.

jeff

Re: FW: Build failed in Jenkins: BuildThunderX_native_gcc_upstream #1267

[Andrew Pinski]

On Fri, Mar 17, 2017 at 11:47 AM, Bernd Schmidt <bschmidt@redhat.com> wrote:
> On 03/17/2017 07:38 PM, Pinski, Andrew wrote:
>>
>> One of the following revision caused a bootstrap comparison failure on
>> aarch64-linux-gnu:
>> r246225
>> r246226
>> r246227
>
>
> Can you help narrow that down?

I can though I don't want to duplicate work since Jeff was going to
provision an aarch64 system.  My automated testing is approximately
every hour or so; these commits were within an hour window even.
I did not look into the revisions when I write the email but I suspect
r246227 did NOT cause it since aarch64 does not use reload anymore.

Thanks,
Andrew

>
>
> Bernd
>

Re: FW: Build failed in Jenkins: BuildThunderX_native_gcc_upstream #1267

[Jeff Law]

On 03/17/2017 03:31 PM, Andrew Pinski wrote:
> On Fri, Mar 17, 2017 at 11:47 AM, Bernd Schmidt <bschmidt@redhat.com> wrote:
>> On 03/17/2017 07:38 PM, Pinski, Andrew wrote:
>>>
>>> One of the following revision caused a bootstrap comparison failure on
>>> aarch64-linux-gnu:
>>> r246225
>>> r246226
>>> r246227
>>
>>
>> Can you help narrow that down?
>
> I can though I don't want to duplicate work since Jeff was going to
> provision an aarch64 system.  My automated testing is approximately
> every hour or so; these commits were within an hour window even.
> I did not look into the revisions when I write the email but I suspect
> r246227 did NOT cause it since aarch64 does not use reload anymore.
My the box I got isn't terribly fast, but regardless I'll be walking 
through each commit to see if I can trigger the failure.

246224 tested OK (as it should).

246225 is in progress.

jeff
>

Re: FW: Build failed in Jenkins: BuildThunderX_native_gcc_upstream #1267

[Jim Wilson]

On 03/17/2017 03:28 PM, Jeff Law wrote:
> On 03/17/2017 03:31 PM, Andrew Pinski wrote:
>> On Fri, Mar 17, 2017 at 11:47 AM, Bernd Schmidt <bschmidt@redhat.com>
>> wrote:
>>> On 03/17/2017 07:38 PM, Pinski, Andrew wrote:
>>>>
>>>> One of the following revision caused a bootstrap comparison failure on
>>>> aarch64-linux-gnu:
>>>> r246225
>>>> r246226
>>>> r246227
>>>
>>>
>>> Can you help narrow that down?
>>
>> I can though I don't want to duplicate work since Jeff was going to
>> provision an aarch64 system.  My automated testing is approximately
>> every hour or so; these commits were within an hour window even.
>> I did not look into the revisions when I write the email but I suspect
>> r246227 did NOT cause it since aarch64 does not use reload anymore.
> My the box I got isn't terribly fast, but regardless I'll be walking
> through each commit to see if I can trigger the failure.
>
> 246224 tested OK (as it should).
>
> 246225 is in progress.

I have access to a fast box that isn't otherwise in use at the moment so 
I'm taking a look.  r246225 builds OK.  r246226 does not.  So it is 
Bernd's combine patch.  A little experimenting shows that the compare 
difference is triggered by the use of -gtoggle in stage2, which is not 
used in stage3.  Otherwise stage2 and stage3 generate identical code. 
The bug is apparently due to a problem with handling debug insns in the 
combine patch.

Jim

Re: FW: Build failed in Jenkins: BuildThunderX_native_gcc_upstream #1267

[Jim Wilson]

On 03/17/2017 04:12 PM, Jim Wilson wrote:
> I have access to a fast box that isn't otherwise in use at the moment so
> I'm taking a look.  r246225 builds OK.  r246226 does not.  So it is
> Bernd's combine patch.  A little experimenting shows that the compare
> difference is triggered by the use of -gtoggle in stage2, which is not
> used in stage3.  Otherwise stage2 and stage3 generate identical code.
> The bug is apparently due to a problem with handling debug insns in the
> combine patch.

Changing a new prev_nonnote_insn call to a prev_nonnote_nondebug_insn 
call appears to solve the problem.  I will have to do a bootstrap and 
make check from scratch to verify.  I also noticed that there is a 
redundant i1 check in the patch which should be fixed also.

Jim

Re: FW: Build failed in Jenkins: BuildThunderX_native_gcc_upstream #1267

[Jeff Law]

On 03/17/2017 05:51 PM, Jim Wilson wrote:
> On 03/17/2017 04:12 PM, Jim Wilson wrote:
>> I have access to a fast box that isn't otherwise in use at the moment so
>> I'm taking a look.  r246225 builds OK.  r246226 does not.  So it is
>> Bernd's combine patch.  A little experimenting shows that the compare
>> difference is triggered by the use of -gtoggle in stage2, which is not
>> used in stage3.  Otherwise stage2 and stage3 generate identical code.
>> The bug is apparently due to a problem with handling debug insns in the
>> combine patch.
>
> Changing a new prev_nonnote_insn call to a prev_nonnote_nondebug_insn
> call appears to solve the problem.  I will have to do a bootstrap and
> make check from scratch to verify.  I also noticed that there is a
> redundant i1 check in the patch which should be fixed also.
Thanks Jim.  My 246226 was just spinning up.

Consider your fixes pre-approved.

jeff