* Wrong documentation of TARGET_ADDR_SPACE_SUBSET_P
@ 2011-09-23 16:42 Bingfeng Mei
2011-09-24 11:22 ` Richard Guenther
0 siblings, 1 reply; 2+ messages in thread
From: Bingfeng Mei @ 2011-09-23 16:42 UTC (permalink / raw)
To: gcc
Hi,
I notice the following description is different from how spu & m32c use it.
In internal manual:
bool TARGET_ADDR_SPACE_SUBSET_P (addr space t superset, [Target Hook]
addr space t subset)
Define this to return whether the subset named address space is contained within the
superset named address space. Pointers to a named address space that is a subset
of another named address space will be converted automatically without a cast if
used together in arithmetic operations. Pointers to a superset address space can be
converted to pointers to a subset address space via explicit casts.
In spu & m32c ports:
m32c_addr_space_subset_p (addr_space_t subset, addr_space_t superset)
spu_addr_space_subset_p (addr_space_t subset, addr_space_t superset)
I believe the document is wrong. The first argument is subset and the second
one is superset. Should I submit a patch?
Cheers,
Bingfeng Mei
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Wrong documentation of TARGET_ADDR_SPACE_SUBSET_P
2011-09-23 16:42 Wrong documentation of TARGET_ADDR_SPACE_SUBSET_P Bingfeng Mei
@ 2011-09-24 11:22 ` Richard Guenther
0 siblings, 0 replies; 2+ messages in thread
From: Richard Guenther @ 2011-09-24 11:22 UTC (permalink / raw)
To: Bingfeng Mei; +Cc: gcc
On Fri, Sep 23, 2011 at 6:42 PM, Bingfeng Mei <bmei@broadcom.com> wrote:
> Hi,
> I notice the following description is different from how spu & m32c use it.
>
> In internal manual:
>
> bool TARGET_ADDR_SPACE_SUBSET_P (addr space t superset, [Target Hook]
> addr space t subset)
> Define this to return whether the subset named address space is contained within the
> superset named address space. Pointers to a named address space that is a subset
> of another named address space will be converted automatically without a cast if
> used together in arithmetic operations. Pointers to a superset address space can be
> converted to pointers to a subset address space via explicit casts.
>
> In spu & m32c ports:
> m32c_addr_space_subset_p (addr_space_t subset, addr_space_t superset)
> spu_addr_space_subset_p (addr_space_t subset, addr_space_t superset)
>
> I believe the document is wrong. The first argument is subset and the second
> one is superset. Should I submit a patch?
Sure.
> Cheers,
> Bingfeng Mei
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-24 11:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-23 16:42 Wrong documentation of TARGET_ADDR_SPACE_SUBSET_P Bingfeng Mei
2011-09-24 11:22 ` Richard Guenther
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).