From: Florian Weimer <fweimer@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc@gcc.gnu.org
Subject: Re: C89isms in the test suite
Date: Fri, 21 Oct 2022 12:01:34 +0200 [thread overview]
Message-ID: <87k04tbim9.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <Y1JoGfxJa5lAkx2g@tucnak> (Jakub Jelinek's message of "Fri, 21 Oct 2022 11:36:25 +0200")
* Jakub Jelinek:
> On Fri, Oct 21, 2022 at 11:17:40AM +0200, Florian Weimer wrote:
>> So we would patch the tests?
>
> Depends on how large the patch is, but I'd say so.
>
>> I guess we can make sure we use “int main
>> (void)” etc. at the same time.
>
> Why? Isn't int main () {} in C2X the same thing as int main (void) {} ?
> int main () {...} is in 3500+ C tests and every day a few are added...
Is this really possible? For function pointers, it's an ABI change.
int (*) () and int (*) (void) have different calling conventions on some
ABIs (e.g., powerpc64le-linux-gnu). The ABI difference goes away once
the callees are rebuilt, and I think such rebuilt callees are compatible
with either calling convention.
But still, if C2X forces such a silent ABI change, that's kind of
troublesome. On the other hand, it addresses a potential
interoperability trap with C++ code.
Thanks,
Florian
next prev parent reply other threads:[~2022-10-21 10:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 8:40 Florian Weimer
2022-10-21 8:57 ` Jakub Jelinek
2022-10-21 9:17 ` Florian Weimer
2022-10-21 9:36 ` Jakub Jelinek
2022-10-21 10:01 ` Florian Weimer [this message]
2022-10-21 10:57 ` Florian Weimer
2022-10-21 21:00 ` Joseph Myers
2022-10-21 21:52 ` Florian Weimer
2022-10-21 20:57 ` Joseph Myers
2022-10-21 20:54 ` Joseph Myers
2022-10-21 21:46 ` Florian Weimer
2022-11-14 4:36 ` Sam James
2022-11-14 8:19 ` Florian Weimer
2022-11-15 5:05 ` Sam James
2022-11-21 11:12 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k04tbim9.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=gcc@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).