public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: gcc@gcc.gnu.org
Subject: C89isms in the test suite
Date: Fri, 21 Oct 2022 10:40:16 +0200	[thread overview]
Message-ID: <87wn8tbmdr.fsf@oldenburg.str.redhat.com> (raw)

What should we do about these when they are not relevant to what's being
tested?  For example, gcc/testsuite/gcc.c-torture/execute/ieee/mzero6.c
has this:

  int main ()
  {
    if (__builtin_copysign (1.0, func (0.0 / -5.0, 10)) != -1.0)
      abort ();
    exit (0);
  }

but no include files, so abort and exit are implicitly declared.

Should we inject a header with -include with the most common
declarations (which includes at least abort and exit)?  Or add the
missing #include directives?  But the latter might not work for
freestanding targets.

Implicit ints and function declarations without prototypes are also
common (not just for main).

Other tests look like they might be intended to be built in C89 mode,
e.g.  gcc/testsuite/gcc.c-torture/compile/386.c, although it's not
immediately obvious to me what they test.

Thanks,
Florian


             reply	other threads:[~2022-10-21  8:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21  8:40 Florian Weimer [this message]
2022-10-21  8:57 ` Jakub Jelinek
2022-10-21  9:17   ` Florian Weimer
2022-10-21  9:36     ` Jakub Jelinek
2022-10-21 10:01       ` Florian Weimer
2022-10-21 10:57         ` Florian Weimer
2022-10-21 21:00         ` Joseph Myers
2022-10-21 21:52           ` Florian Weimer
2022-10-21 20:57     ` Joseph Myers
2022-10-21 20:54 ` Joseph Myers
2022-10-21 21:46   ` Florian Weimer
2022-11-14  4:36 ` Sam James
2022-11-14  8:19   ` Florian Weimer
2022-11-15  5:05     ` Sam James
2022-11-21 11:12     ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn8tbmdr.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=gcc@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).