Regarding bypass-asm patch and help in an error during bootstrapped build

Regarding bypass-asm patch and help in an error during bootstrapped build

[Rishi Raj]

[-- Attachment #1: Type: text/plain, Size: 1677 bytes --]

Hi,

I have added the patch (
https://gcc.gnu.org/pipermail/gcc-patches/2023-July/623379.html ) on the
devel/bypass-asm branch.
Although I am able to build using the --disable-bootstrap option but while
doing a bootstrapped build, I am getting these errors ( as warnings while
doing the non-bootstrapped build.)

In file included from ../../gcc/gcc/lto-object.cc:23:0:
../../gcc/gcc/is-a.h:196:22: error: inline function ‘static bool
is_a_helper<T>::test(U*) [with U = symtab_node; T = cgraph_node*]’ used but
never defined [enabled by default]
   static inline bool test (U *p);

                      ^
../../gcc/gcc/is-a.h:196:22: error: inline function ‘static bool
is_a_helper<T>::test(U*) [with U = symtab_node; T = varpool_node*]’ used
but never defined [enabled by default]


In file included from ../../gcc/gcc/coretypes.h:489:0,
                 from ../../gcc/gcc/lto/lto-lang.cc:23:
../../gcc/gcc/is-a.h:196:22: error inline function ‘static bool
is_a_helper<T>::test(U*) [with U = symtab_node; T = cgraph_node*]’ used but
never defined [enabled by default]
   static inline bool test (U *p);
                      ^
../../gcc/gcc/is-a.h:196:22: error inline function ‘static bool
is_a_helper<T>::test(U*) [with U = symtab_node; T = varpool_node*]’ used
but never defined [enabled by default]

I have tested the .symtab and dummy symbols addition on the
non-bootstrapped build, and they are working fine. I also ran the lto test
suite, and it passed as expected. I am looking into the error produced
during bootstrapped build currently. I would appreciate any help/guidance
regarding this.

--
Regards
Rishi

Re: Regarding bypass-asm patch and help in an error during bootstrapped build

[Jan Hubicka]

> Hi,
> 
> I have added the patch (
> https://gcc.gnu.org/pipermail/gcc-patches/2023-July/623379.html ) on the
> devel/bypass-asm branch.
> Although I am able to build using the --disable-bootstrap option but while
> doing a bootstrapped build, I am getting these errors ( as warnings while
> doing the non-bootstrapped build.)
> 
> In file included from ../../gcc/gcc/lto-object.cc:23:0:
> ../../gcc/gcc/is-a.h:196:22: error: inline function ‘static bool
> is_a_helper<T>::test(U*) [with U = symtab_node; T = cgraph_node*]’ used but
> never defined [enabled by default]
>    static inline bool test (U *p);
> 
>                       ^
> ../../gcc/gcc/is-a.h:196:22: error: inline function ‘static bool
> is_a_helper<T>::test(U*) [with U = symtab_node; T = varpool_node*]’ used
> but never defined [enabled by default]
> 
> 
> In file included from ../../gcc/gcc/coretypes.h:489:0,
>                  from ../../gcc/gcc/lto/lto-lang.cc:23:
> ../../gcc/gcc/is-a.h:196:22: error inline function ‘static bool
> is_a_helper<T>::test(U*) [with U = symtab_node; T = cgraph_node*]’ used but
> never defined [enabled by default]
>    static inline bool test (U *p);
>                       ^
> ../../gcc/gcc/is-a.h:196:22: error inline function ‘static bool
> is_a_helper<T>::test(U*) [with U = symtab_node; T = varpool_node*]’ used
> but never defined [enabled by default]
> 
> I have tested the .symtab and dummy symbols addition on the
> non-bootstrapped build, and they are working fine. I also ran the lto test
> suite, and it passed as expected. I am looking into the error produced
> during bootstrapped build currently. I would appreciate any help/guidance
> regarding this.
This is because you miss some #inline or you do these in wrong order
(at some point it was decided to drop most #inlines inside header files,
so one needs to always do the transitive closure by  hand which is quite
anoying).

This is a conversion helper from cgraph_node to symtab_node, so pehraps
you need to include cgraph.h?

Honza
> 
> --
> Regards
> Rishi

Re: Regarding bypass-asm patch and help in an error during bootstrapped build

[Rishi Raj]

[-- Attachment #1: Type: text/plain, Size: 2590 bytes --]

Yup,  I somehow missed it. Thanks, it is fixed now. Now we can test the
addition of.symtab and symbols in both builds.
Now I am moving toward the second part of the project, adding debugging
information. Right now, I am going through the documentation.
Will you recommend any other resources?

--
Rishi

On Thu, 6 Jul 2023 at 20:40, Jan Hubicka <hubicka@ucw.cz> wrote:

> > Hi,
> >
> > I have added the patch (
> > https://gcc.gnu.org/pipermail/gcc-patches/2023-July/623379.html ) on the
> > devel/bypass-asm branch.
> > Although I am able to build using the --disable-bootstrap option but
> while
> > doing a bootstrapped build, I am getting these errors ( as warnings while
> > doing the non-bootstrapped build.)
> >
> > In file included from ../../gcc/gcc/lto-object.cc:23:0:
> > ../../gcc/gcc/is-a.h:196:22: error: inline function ‘static bool
> > is_a_helper<T>::test(U*) [with U = symtab_node; T = cgraph_node*]’ used
> but
> > never defined [enabled by default]
> >    static inline bool test (U *p);
> >
> >                       ^
> > ../../gcc/gcc/is-a.h:196:22: error: inline function ‘static bool
> > is_a_helper<T>::test(U*) [with U = symtab_node; T = varpool_node*]’ used
> > but never defined [enabled by default]
> >
> >
> > In file included from ../../gcc/gcc/coretypes.h:489:0,
> >                  from ../../gcc/gcc/lto/lto-lang.cc:23:
> > ../../gcc/gcc/is-a.h:196:22: error inline function ‘static bool
> > is_a_helper<T>::test(U*) [with U = symtab_node; T = cgraph_node*]’ used
> but
> > never defined [enabled by default]
> >    static inline bool test (U *p);
> >                       ^
> > ../../gcc/gcc/is-a.h:196:22: error inline function ‘static bool
> > is_a_helper<T>::test(U*) [with U = symtab_node; T = varpool_node*]’ used
> > but never defined [enabled by default]
> >
> > I have tested the .symtab and dummy symbols addition on the
> > non-bootstrapped build, and they are working fine. I also ran the lto
> test
> > suite, and it passed as expected. I am looking into the error produced
> > during bootstrapped build currently. I would appreciate any help/guidance
> > regarding this.
> This is because you miss some #inline or you do these in wrong order
> (at some point it was decided to drop most #inlines inside header files,
> so one needs to always do the transitive closure by  hand which is quite
> anoying).
>
> This is a conversion helper from cgraph_node to symtab_node, so pehraps
> you need to include cgraph.h?
>
> Honza
> >
> > --
> > Regards
> > Rishi
>