* vect_recog_mixed_size_cond_pattern dead code now
@ 2023-08-30 5:45 Andrew Pinski
2023-08-30 7:26 ` Richard Biener
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Pinski @ 2023-08-30 5:45 UTC (permalink / raw)
To: GCC Mailing List, Richard Guenther
Hi,
I was reading some code in tree-vect-patterns.cc and I came across
vect_recog_mixed_size_cond_pattern . The code tries to handle
comparisons from COND_EXPR but that cannot happen any more (after
r13-707-g68e0063397ba82).
Should this code be removed now?
Thanks,
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: vect_recog_mixed_size_cond_pattern dead code now
2023-08-30 5:45 vect_recog_mixed_size_cond_pattern dead code now Andrew Pinski
@ 2023-08-30 7:26 ` Richard Biener
2023-08-30 7:32 ` Andrew Pinski
0 siblings, 1 reply; 3+ messages in thread
From: Richard Biener @ 2023-08-30 7:26 UTC (permalink / raw)
To: Andrew Pinski; +Cc: GCC Mailing List
On Tue, 29 Aug 2023, Andrew Pinski wrote:
> Hi,
> I was reading some code in tree-vect-patterns.cc and I came across
> vect_recog_mixed_size_cond_pattern . The code tries to handle
> comparisons from COND_EXPR but that cannot happen any more (after
> r13-707-g68e0063397ba82).
> Should this code be removed now?
tree-vect-patterns.cc still builds COND_EXPRs with embedded comparisons,
so this might be still used by means of pattern recognition of patterns.
Richard.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: vect_recog_mixed_size_cond_pattern dead code now
2023-08-30 7:26 ` Richard Biener
@ 2023-08-30 7:32 ` Andrew Pinski
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Pinski @ 2023-08-30 7:32 UTC (permalink / raw)
To: Richard Biener; +Cc: GCC Mailing List
On Wed, Aug 30, 2023 at 12:26 AM Richard Biener <rguenther@suse.de> wrote:
>
> On Tue, 29 Aug 2023, Andrew Pinski wrote:
>
> > Hi,
> > I was reading some code in tree-vect-patterns.cc and I came across
> > vect_recog_mixed_size_cond_pattern . The code tries to handle
> > comparisons from COND_EXPR but that cannot happen any more (after
> > r13-707-g68e0063397ba82).
> > Should this code be removed now?
>
> tree-vect-patterns.cc still builds COND_EXPRs with embedded comparisons,
> so this might be still used by means of pattern recognition of patterns.
Oh I see and I also seem to have missed the comment at towards the
beginning of the file too:
/* TODO: Note the vectorizer still builds COND_EXPRs with GENERIC compares
in the first operand. Disentangling this is future work, the
IL is properly transfered to VEC_COND_EXPRs with separate compares. */
Thanks,
Andrew
>
> Richard.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-30 7:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-30 5:45 vect_recog_mixed_size_cond_pattern dead code now Andrew Pinski
2023-08-30 7:26 ` Richard Biener
2023-08-30 7:32 ` Andrew Pinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).