From: Jonathan Wakely <jwakely@redhat.com>
To: Ken Matsui <kmatsui@cs.washington.edu>
Cc: "François Dumont" <frs.dumont@gmail.com>,
libstdc++@gcc.gnu.org, gcc@gcc.gnu.org
Subject: Re: [GSoC] Conflicted Built-in Trait Name
Date: Thu, 30 Mar 2023 13:23:37 +0100 [thread overview]
Message-ID: <CACb0b4n7tW5Bk2fru+CpiLbmGeKWOM8nKb4Zw7ookiyFriRe0w@mail.gmail.com> (raw)
In-Reply-To: <CAML+3pXWM6HVd3B7AyZNb=Y89zn2Eg8CNwDDrd4CHsbu=_mfaw@mail.gmail.com>
On Thu, 30 Mar 2023 at 09:33, Ken Matsui wrote:
>
> Hi François,
>
> On Wed, Mar 29, 2023 at 10:11 PM François Dumont <frs.dumont@gmail.com> wrote:
> >
> > Hi
> >
> > Do not hesitate to dig into library doc. Especially this page:
> >
> > https://gcc.gnu.org/onlinedocs/gcc-8.1.0/libstdc++/manual/manual/test.html
> >
> > You can also find it in your git clone in <gcc-repo>/libstdc++-v3/doc/html.
> >
> > You'll see also how to run test in different std modes like --std=c++98
> > to catch the kind of issue reported by Jonathan.
>
> This is what I wanted to know! Thank you so much!
>
> > Regarding your patches I wonder if it's not too splitted. 1 patch per
> > builtin would sound more logical, at least for an easy one like __is_void.
>
> I see. I will squash is_void-related commits into the commit of
> __is_void implementation. Thank you for pointing it out!
Yes, good point, François. These kind of changes for the front-end and
library should be in one patch. Otherwise, if they were committed
separately then you would create a revision where bootstrap fails. If
the front-end change is committed without the library change, then you
can't build the library because it still uses __is_void which is now a
keyword. If the library change is committed first then you don't break
bootstrap, but you're adding support to the library for a new built-in
which doesn't actually exist (yet). They should be a single revision,
so that the tree can always be built.
next prev parent reply other threads:[~2023-03-30 12:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 7:53 Ken Matsui
2023-03-25 12:23 ` Roy Jacobson
2023-03-27 21:58 ` Jonathan Wakely
2023-03-27 22:48 ` Ken Matsui
2023-03-25 12:38 ` Marc Glisse
2023-03-26 2:01 ` Ken Matsui
2023-03-27 17:33 ` François Dumont
2023-03-27 20:16 ` Ken Matsui
2023-03-27 21:43 ` Jonathan Wakely
2023-03-27 21:49 ` Jonathan Wakely
2023-03-27 21:55 ` Ken Matsui
2023-03-28 21:29 ` Ken Matsui
2023-03-28 23:24 ` Jonathan Wakely
2023-03-28 23:33 ` Ken Matsui
2023-03-30 5:11 ` François Dumont
2023-03-30 8:33 ` Ken Matsui
2023-03-30 12:23 ` Jonathan Wakely [this message]
2023-03-30 18:44 ` Ken Matsui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4n7tW5Bk2fru+CpiLbmGeKWOM8nKb4Zw7ookiyFriRe0w@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=frs.dumont@gmail.com \
--cc=gcc@gcc.gnu.org \
--cc=kmatsui@cs.washington.edu \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).