From: Joel Sherrill <joel@rtems.org>
To: Vincent Fazio <vfazio@gmail.com>
Cc: gcc@gcc.gnu.org, eager@eagercon.com
Subject: Re: MicroBlaze symver attribute support
Date: Mon, 20 Feb 2023 08:54:00 -0600 [thread overview]
Message-ID: <CAF9ehCWEFeWhXrQjdEJNdFZ2rGQOhMN-n4FXmTd7vEf_Y0v0Nw@mail.gmail.com> (raw)
In-Reply-To: <CAOrEah4Qg754RvUTKtP2LVdDHwJB5bMWMnBEP33sq=FxGkjXag@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]
On Mon, Feb 20, 2023 at 7:56 AM Vincent Fazio via Gcc <gcc@gcc.gnu.org>
wrote:
> Michael, all,
>
> Regarding:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101766
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102110
>
> If I understand correctly, since the GCC MicroBlaze targets generate ELF
> images, it would seem there's no technical reason why `__attribute__
> ((symver ...))` cannot be supported?
>
> The issue seems to be that the MicroBlaze targets in config.gcc do not
> include elfos.h
> https://github.com/gcc-mirror/gcc/blob/master/gcc/config.gcc#L2369
>
> Which defines `ASM_OUTPUT_SYMVER_DIRECTIVE`
> https://github.com/gcc-mirror/gcc/blob/master/gcc/config/elfos.h#L259
>
> Which is necessary for
> https://github.com/gcc-mirror/gcc/blob/master/gcc/varasm.cc#L6260
>
> Changing the targets to include elfos.h leads to a number of conflicts with
> the target specific header (config/microblaze/microblaze.h).
>
> Should `ASM_OUTPUT_SYMVER_DIRECTIVE` be copied into
> config/microblaze/microblaze.h or should the MicroBlaze targets and header
> be reworked to support elfos.h?
>
IMO reworked to include elfos.h. During the RTEMS port, we noticed that
some quirks on the microblaze gcc because it isn't using elfos.h. This
likely
will mean it will be updated as a side-effect of normal GCC maintenance
instead of being an odd singleton which doesn't share.
>
> I'm asking because I've seen a number of projects run into this issue (xz,
> elfutils, libfuse, libkcapi, cryptsetup).
>
And RTEMS.
--joel
>
> Thanks,
> -Vincent
>
next prev parent reply other threads:[~2023-02-20 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 13:55 Vincent Fazio
2023-02-20 14:54 ` Joel Sherrill [this message]
2023-02-21 1:35 ` Michael Eager
2023-03-03 19:35 ` Vincent Fazio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF9ehCWEFeWhXrQjdEJNdFZ2rGQOhMN-n4FXmTd7vEf_Y0v0Nw@mail.gmail.com \
--to=joel@rtems.org \
--cc=eager@eagercon.com \
--cc=gcc@gcc.gnu.org \
--cc=vfazio@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).