public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* GCC PowerPC bootstrap and irange
@ 2020-10-01 19:15 David Edelsohn
  0 siblings, 0 replies; only message in thread
From: David Edelsohn @ 2020-10-01 19:15 UTC (permalink / raw)
  To: Aldy Hernandez, Andrew MacLeod; +Cc: GCC Development

The latest irange patch has broken bootstrap for PowerPC

In file included from /nasfarm/edelsohn/src/src/gcc/tree-ssa-propagate.h:25:0,
                 from
/nasfarm/edelsohn/src/src/gcc/config/rs6000/rs6000-call.c:67:
/nasfarm/edelsohn/src/src/gcc/value-query.h:90:31: error: 'irange' has
not been  declared
   virtual bool range_of_expr (irange &r, tree name, gimple * = NULL) = 0;
                               ^~~~~~
/nasfarm/edelsohn/src/src/gcc/value-query.h:91:31: error: 'irange' has not been
declared
   virtual bool range_on_edge (irange &r, edge, tree name);
                               ^~~~~~
/nasfarm/edelsohn/src/src/gcc/value-query.h:92:31: error: 'irange' has not been
declared
   virtual bool range_of_stmt (irange &r, gimple *, tree name = NULL);
                               ^~~~~~
make[3]: *** [/nasfarm/edelsohn/src/src/gcc/config/rs6000/t-rs6000:47:
rs6000-call.o] Error 1

tree-ssa-propagate.h was (incorrectly?) changed to include
value-query.h, which breaks the flat header model of GCC, but
value-query.h depends upon value-range.h.

rs6000.c includes tree-ssa-propagate.h, but not value-range.h.

GCC sources can't be half pregnant about this.  Either
tree-ssa-propagate.h includes all of the dependent headers or none.  I
thought that the GCC policy was C files including the headers that
they needed, not headers sneaking into other headers.

Thanks, David

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-10-01 19:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 19:15 GCC PowerPC bootstrap and irange David Edelsohn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).