public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Edelsohn <dje.gcc@gmail.com>
To: Umesh Kalappa <umesh.kalappa0@gmail.com>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
	Andrew Pinski <pinskia@gmail.com>,
	 Nicholas Piggin <npiggin@gmail.com>,
	linuxppc-dev@lists.ozlabs.org, gcc@gcc.gnu.org,
	 libc-alpha@sourceware.org, Michael Ellerman <mpe@ellerman.id.au>,
	 Paul E Murphy <murphyp@linux.ibm.com>
Subject: Re: Passing the complex args in the GPR's
Date: Tue, 6 Jun 2023 13:33:30 -0400	[thread overview]
Message-ID: <CAGWvnymQGdjBgmsSnLYZaoapPeO8HTM5xe6bPZCqT03hmgaJ6w@mail.gmail.com> (raw)
In-Reply-To: <CAGfacvQ7qE4S-U=XLVRdZmitWJiCcppWH+VscpKz4piDYWwp=w@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2417 bytes --]

On Tue, Jun 6, 2023 at 1:08 PM Umesh Kalappa via Gcc <gcc@gcc.gnu.org>
wrote:

> Hi Segher ,
>
> >>What did you expect, what happened instead?
> For example the complex args are passed in GPR's for  cexp in the case
> GCC and Clang uses  caller memory .
>
> for reference : https://godbolt.org/z/MfMz3cTe7
>
> We have cross tools  like some of libraries built  using  the GCC and
> some use Clang .
>
> We approached Clang developers on this behaviour (Why stack , not the
> FPR's registers like PPC64)  and they are not going to change this
> behaviour, and asked us to refer back to GCC ,hence this email thread.
>
> Question is : Why does GCC choose to use GPR's here and have any
> reference to support this decision  ?
>

The use of GPRs to pass complex floating point arguments was an early
implementation mistake -- the parameter passing code missed the
enumeration of a type.  The behavior cannot be changed and corrected
without breaking the ABI.

I don't know what you mean by "support this decision".  It was not
intentionally chosen through careful performance analysis or type system
design as the preferred method to pass complex floating point values.  The
initial implementation was wrong and not discovered until it was too late.
The reference to support this is that one cannot break the ABI without
causing chaos in the ecosystem.

Thanks, David


>
> Thank you
> ~Umesh
>
>
>
> On Tue, Jun 6, 2023 at 10:16 PM Segher Boessenkool
> <segher@kernel.crashing.org> wrote:
> >
> > Hi!
> >
> > On Tue, Jun 06, 2023 at 08:35:22PM +0530, Umesh Kalappa wrote:
> > > Hi Adnrew,
> > > Thank you for the quick response and for PPC64 too ,we do have
> > > mismatches in ABI b/w complex operations like
> > > https://godbolt.org/z/bjsYovx4c .
> > >
> > > Any reason why GCC chose to use GPR 's here ?
> >
> > What did you expect, what happened instead?  Why did you expect that,
> > and why then is it an error what did happen?
> >
> > You used -O0.  As long as the code works, all is fine.  But unoptimised
> > code frequently is hard to read, please use -O2 instead?
> >
> > As Andrew says, why did you use -m32 for GCC but -m64 for LLVM?  It is
> > hard to compare those at all!  32-bit PowerPC Linux ABI (based on 32-bit
> > PowerPC ELF ABI from 1995, BE version) vs. 64-bit ELFv2 ABI from 2015
> > (LE version).
> >
> >
> > Segher
>

  reply	other threads:[~2023-06-06 17:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-24  9:38 [PATCH Linux] powerpc: add documentation for HWCAPs Nicholas Piggin
2022-05-24  9:52 ` Florian Weimer
2022-05-24 18:32   ` Segher Boessenkool
2022-07-15  1:17     ` Nicholas Piggin
2022-07-15 14:35       ` Segher Boessenkool
2022-05-24 17:38 ` Segher Boessenkool
2022-07-15  1:00   ` Nicholas Piggin
2023-06-06 14:49 ` Passing the complex args in the GPR's Umesh Kalappa
2023-06-06 14:58   ` Andrew Pinski
2023-06-06 15:05     ` Umesh Kalappa
2023-06-06 15:16       ` Andrew Pinski
2023-06-06 16:42       ` Segher Boessenkool
2023-06-06 17:07         ` Umesh Kalappa
2023-06-06 17:33           ` David Edelsohn [this message]
2023-06-07 13:17           ` Michael Matz
2023-06-06 17:18     ` Joseph Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGWvnymQGdjBgmsSnLYZaoapPeO8HTM5xe6bPZCqT03hmgaJ6w@mail.gmail.com \
    --to=dje.gcc@gmail.com \
    --cc=gcc@gcc.gnu.org \
    --cc=libc-alpha@sourceware.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=murphyp@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=pinskia@gmail.com \
    --cc=segher@kernel.crashing.org \
    --cc=umesh.kalappa0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).