From: Christophe Lyon <christophe.lyon@linaro.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
Thiago Bauermann <thiago.bauermann@linaro.org>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
binutils@sourceware.org, GCC Mailing List <gcc@gcc.gnu.org>,
gdb@sourceware.org, Nick Clifton <nickc@redhat.com>,
Richard Biener <rguenther@suse.de>,
Jakub Jelinek <jakub@redhat.com>,
Joel Brobecker <brobecker@adacore.com>,
"Carlos O'Donell" <carlos@redhat.com>
Subject: Re: Patches submission policy change
Date: Fri, 5 Apr 2024 09:22:28 +0200 [thread overview]
Message-ID: <CAPS5khZQreELQt9wmScKFopAPSgBcpVgcYn8BN1jWu79vxZPRw@mail.gmail.com> (raw)
In-Reply-To: <0d343d67-33e0-4f63-b385-8ae360bc68dc@suse.com>
On Thu, 4 Apr 2024 at 10:12, Jan Beulich <jbeulich@suse.com> wrote:
>
> On 03.04.2024 15:11, Christophe Lyon wrote:
> > On Wed, 3 Apr 2024 at 10:30, Jan Beulich <jbeulich@suse.com> wrote:
> >>
> >> On 03.04.2024 10:22, Christophe Lyon wrote:
> >>> Dear release managers and developers,
> >>>
> >>> TL;DR: For the sake of improving precommit CI coverage and simplifying
> >>> workflows, I’d like to request a patch submission policy change, so
> >>> that we now include regenerated files. This was discussed during the
> >>> last GNU toolchain office hours meeting [1] (2024-03-28).
> >>>
> >>> Benefits or this change include:
> >>> - Increased compatibility with precommit CI
> >>> - No need to manually edit patches before submitting, thus the “git
> >>> send-email” workflow is simplified
> >>> - Patch reviewers can be confident that the committed patch will be
> >>> exactly what they approved
> >>> - Precommit CI can test exactly what has been submitted
> >>>
> >>> Any concerns/objections?
> >>
> >> Yes: Patch size. And no, not sending patches inline is bad practice.
> > Not sure what you mean? Do you mean sending patches as attachments is
> > bad practice?
>
> Yes. It makes it difficult to reply to them (with proper reply context).
Agreed.
>
> >> Even assuming sending patches bi-modal (inline and as attachment) works
> >> (please indicate whether that's the case), it would mean extra work on
> >> the sending side.
> >>
> > For the CI perspective, we use what patchwork is able to detect as patches.
> > Looking at recent patches submissions, it seems patchwork is able to
> > cope with the output of git format-patch/git send-email, as well as
> > attachments.
> > There are cases where patchwork is not able to detect the patch, but I
> > don't know patchwork's exact specifications.
>
> Question was though: If a patch was sent inline plus attachment, what
> would CI use as the patch to apply? IOW would it be an option to
> attach the un-stripped patch, while inlining the stripped one?
>
Sorry, I don't know how patchwork would handle such a case.
Thanks,
Christophe
> Jan
>
next prev parent reply other threads:[~2024-04-05 7:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 8:22 Christophe Lyon
2024-04-03 8:30 ` Jan Beulich
2024-04-03 13:11 ` Christophe Lyon
2024-04-04 8:12 ` Jan Beulich
2024-04-05 7:22 ` Christophe Lyon [this message]
2024-04-03 8:45 ` Jakub Jelinek
2024-04-03 8:49 ` Jan Beulich
2024-04-03 8:57 ` Richard Biener
2024-04-03 10:21 ` Jan Beulich
2024-04-03 12:58 ` Joel Sherrill
2024-04-03 13:23 ` Christophe Lyon
2024-04-08 15:37 ` Richard Earnshaw (lists)
2024-04-03 12:59 ` Jason Merrill
2024-04-03 13:19 ` Christophe Lyon
2024-04-03 9:50 ` Jonathan Wakely
2024-04-03 15:03 ` Simon Marchi
2024-04-04 21:35 ` Mark Wielaard
2024-04-04 21:51 ` Simon Marchi
2024-04-05 6:44 ` Marc
2024-04-05 7:17 ` Christophe Lyon
2024-04-06 16:29 ` Mark Wielaard
2024-04-07 12:32 ` Jonathan Wakely
2024-04-07 14:02 ` Mark Wielaard
2024-04-07 14:20 ` Jonathan Wakely
2024-04-07 22:00 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPS5khZQreELQt9wmScKFopAPSgBcpVgcYn8BN1jWu79vxZPRw@mail.gmail.com \
--to=christophe.lyon@linaro.org \
--cc=adhemerval.zanella@linaro.org \
--cc=binutils@sourceware.org \
--cc=brobecker@adacore.com \
--cc=carlos@redhat.com \
--cc=gcc@gcc.gnu.org \
--cc=gdb@sourceware.org \
--cc=jakub@redhat.com \
--cc=jbeulich@suse.com \
--cc=maxim.kuvyrkov@linaro.org \
--cc=nickc@redhat.com \
--cc=rguenther@suse.de \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).