From: Christophe Lyon <christophe.lyon@linaro.org>
To: Tom Tromey <tom@tromey.com>
Cc: Eric Gallager <egall@gwmail.gwu.edu>,
Simon Marchi <simark@simark.ca>,
binutils@sourceware.org, gdb@sourceware.org, gcc@gcc.gnu.org
Subject: Re: [RFC] add regenerate Makefile target
Date: Mon, 18 Mar 2024 18:28:16 +0100 [thread overview]
Message-ID: <CAPS5khbEF3E4j8JqHdPVYBAu7B3em4sujS3ZuFXXKNuWAF9jWA@mail.gmail.com> (raw)
In-Reply-To: <87edcbk1x3.fsf@tromey.com>
On Fri, 15 Mar 2024 at 15:25, Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Eric" == Eric Gallager <egall@gwmail.gwu.edu> writes:
>
> Eric> Also there are the files generated by cgen, too, which no one seems to
> Eric> know how to regenerate, either.
>
> I thought I sent out some info on this a while ago.
>
> Anyway what I do is make a symlink to the cgen source tree in the
> binutils-gdb source tree, then configure with --enable-cgen-maint.
> Then I make sure to build with 'make GUILE=guile3.0'.
>
> It could be better but that would require someone to actually work on
> cgen.
>
> Eric> And then in bfd there's that chew
> Eric> program in the doc subdir. And then in the binutils subdirectory
> Eric> proper there's that sysinfo tool for generating sysroff.[ch].
>
> gdb used to use a mish-mash of different approaches, some quite strange,
> but over the last few years we standardized on Python scripts that
> generate files. They're written to be seamless -- just invoke in the
> source dir; the output is then just part of your patch. No special
> configure options are needed. On the whole this has been a big
> improvement.
>
Good to know that this is perceived as a big improvement, that's a
strong argument for moving to a script.
I'm not up-to-date with gdb's policy about patches: are they supposed
to be posted with or without the regenerated parts included?
IIUC they are not included in patch submissions for binutils and gcc,
which makes the pre-commit CI miss some patches.
Thanks,
Christophe
> Tom
next prev parent reply other threads:[~2024-03-18 17:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 8:02 Christophe Lyon
2024-03-14 18:10 ` Simon Marchi
2024-03-15 8:50 ` Christophe Lyon
2024-03-15 14:13 ` Eric Gallager
2024-03-15 14:25 ` Tom Tromey
2024-03-16 17:30 ` Simon Marchi
2024-03-18 17:28 ` Christophe Lyon [this message]
2024-03-20 15:11 ` Simon Marchi
2024-03-18 16:13 ` Christophe Lyon
2024-03-16 17:16 ` Simon Marchi
2024-03-18 17:25 ` Christophe Lyon
2024-03-19 17:11 ` Christophe Lyon
2024-03-19 18:03 ` Tom Tromey
2024-03-20 12:05 ` Eric Gallager
2024-03-20 15:34 ` Simon Marchi
2024-03-21 14:32 ` Christophe Lyon
2024-03-25 14:19 ` Christophe Lyon
2024-03-27 18:22 ` Christophe Lyon
2024-04-08 9:22 ` Christophe Lyon
[not found] ` <78f1d113-f8ac-4a76-8dea-9f92519c1a89@linux.ibm.com>
2024-03-27 18:14 ` Christophe Lyon
2024-03-28 8:55 ` Jens Remus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPS5khbEF3E4j8JqHdPVYBAu7B3em4sujS3ZuFXXKNuWAF9jWA@mail.gmail.com \
--to=christophe.lyon@linaro.org \
--cc=binutils@sourceware.org \
--cc=egall@gwmail.gwu.edu \
--cc=gcc@gcc.gnu.org \
--cc=gdb@sourceware.org \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).