public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ben Boeckel <ben.boeckel@kitware.com>
To: gcc-patches@gcc.gnu.org
Cc: jason@redhat.com, nathan@acm.org, fortran@gcc.gnu.org,
	gcc@gcc.gnu.org, brad.king@kitware.com, dmalcolm@redhat.com,
	mliska@suse.cz, anlauf@gmx.de
Subject: Re: [PATCH v2 3/3] p1689r5: initial support
Date: Fri, 28 Oct 2022 13:15:54 -0400	[thread overview]
Message-ID: <Y1wOSt2ncvLa9Q1P@megas.dev.benboeckel.internal> (raw)
In-Reply-To: <20221027231645.67623-4-ben.boeckel@kitware.com>

On Thu, Oct 27, 2022 at 19:16:44 -0400, Ben Boeckel wrote:
> diff --git a/gcc/testsuite/g++.dg/modules/modules.exp b/gcc/testsuite/g++.dg/modules/modules.exp
> index afb323d0efd..7fe8825144f 100644
> --- a/gcc/testsuite/g++.dg/modules/modules.exp
> +++ b/gcc/testsuite/g++.dg/modules/modules.exp
> @@ -28,6 +28,7 @@
>  # { dg-module-do [link|run] [xfail] [options] } # link [and run]
>  
>  load_lib g++-dg.exp
> +load_lib modules.exp
>  
>  # If a testcase doesn't have special options, use these.
>  global DEFAULT_CXXFLAGS
> @@ -237,6 +238,13 @@ proc cleanup_module_files { files } {
>      }
>  }
>  
> +# delete the specified set of dep files
> +proc cleanup_dep_files { files } {
> +    foreach file $files {
> +	file_on_host delete $file
> +    }
> +}
> +
>  global testdir
>  set testdir $srcdir/$subdir
>  proc srcdir {} {
> @@ -310,6 +318,7 @@ foreach src [lsort [find $srcdir/$subdir {*_a.[CHX}]] {
>  	set std_list [module-init $src]
>  	foreach std $std_list {
>  	    set mod_files {}
> +	    set dep_files {}
>  	    global module_do
>  	    set module_do {"compile" "P"}
>  	    set asm_list {}
> @@ -346,6 +355,8 @@ foreach src [lsort [find $srcdir/$subdir {*_a.[CHX}]] {
>  		set mod_files [find $DEFAULT_REPO *.gcm]
>  	    }
>  	    cleanup_module_files $mod_files
> +
> +	    cleanup_dep_files $dep_files
>  	}
>      }
>  }

These `cleanup_dep_files` hunks are leftovers from my attempts at
getting the P1689 and flags tests working; they'll be gone in v3.

--Ben

  reply	other threads:[~2022-10-28 17:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27 23:16 [PATCH v2 0/1] RFC: P1689R5 support Ben Boeckel
2022-10-27 23:16 ` [PATCH v2 1/3] libcpp: reject codepoints above 0x10FFFF Ben Boeckel
2022-10-28 12:54   ` David Malcolm
2022-11-07 23:04   ` Jason Merrill
2022-10-27 23:16 ` [PATCH v2 2/3] libcpp: add a function to determine UTF-8 validity of a C string Ben Boeckel
2022-10-28 12:59   ` David Malcolm
2022-10-28 17:14     ` Ben Boeckel
2022-11-07 23:47   ` Jason Merrill
2022-10-27 23:16 ` [PATCH v2 3/3] p1689r5: initial support Ben Boeckel
2022-10-28 17:15   ` Ben Boeckel [this message]
2022-11-01 14:57   ` Tom Tromey
2022-11-01 16:22     ` Ben Boeckel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1wOSt2ncvLa9Q1P@megas.dev.benboeckel.internal \
    --to=ben.boeckel@kitware.com \
    --cc=anlauf@gmx.de \
    --cc=brad.king@kitware.com \
    --cc=dmalcolm@redhat.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gcc@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=mliska@suse.cz \
    --cc=nathan@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).