From: Ben Boeckel <ben.boeckel@kitware.com>
To: Tom Tromey <tom@tromey.com>
Cc: Ben Boeckel via Gcc-patches <gcc-patches@gcc.gnu.org>,
gcc@gcc.gnu.org, brad.king@kitware.com, fortran@gcc.gnu.org,
anlauf@gmx.de, nathan@acm.org
Subject: Re: [PATCH v2 3/3] p1689r5: initial support
Date: Tue, 1 Nov 2022 12:22:42 -0400 [thread overview]
Message-ID: <Y2FH0rmk4Y5ECqwV@megas.dev.benboeckel.internal> (raw)
In-Reply-To: <87sfj290ym.fsf@tromey.com>
On Tue, Nov 01, 2022 at 08:57:37 -0600, Tom Tromey wrote:
> >>>>> "Ben" == Ben Boeckel via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
>
> Ben> - `-fdeps-file=` specifies the path to the file to write the format to.
>
> I don't know how this output is intended to be used, but one mistake
> made with the other dependency-tracking options was that the output file
> isn't created atomically. As a consequence, Makefiles normally have to
> work around this to be robust. If that's a possible issue here then it
> would be best to handle it in this patch.
I don't think there'll be any race here because it's the "output" of the
rule as far as the build graph is concerned. It's also JSON, so anything
reading it "early" will get a partial object and easily detect
"something went wrong". And for clarity, the `-o` flag used in CMake
with this is just a side effect of the `-E` mechanism used and is
completely ignored in the CMake usage of this.
--Ben
prev parent reply other threads:[~2022-11-01 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 23:16 [PATCH v2 0/1] RFC: P1689R5 support Ben Boeckel
2022-10-27 23:16 ` [PATCH v2 1/3] libcpp: reject codepoints above 0x10FFFF Ben Boeckel
2022-10-28 12:54 ` David Malcolm
2022-11-07 23:04 ` Jason Merrill
2022-10-27 23:16 ` [PATCH v2 2/3] libcpp: add a function to determine UTF-8 validity of a C string Ben Boeckel
2022-10-28 12:59 ` David Malcolm
2022-10-28 17:14 ` Ben Boeckel
2022-11-07 23:47 ` Jason Merrill
2022-10-27 23:16 ` [PATCH v2 3/3] p1689r5: initial support Ben Boeckel
2022-10-28 17:15 ` Ben Boeckel
2022-11-01 14:57 ` Tom Tromey
2022-11-01 16:22 ` Ben Boeckel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2FH0rmk4Y5ECqwV@megas.dev.benboeckel.internal \
--to=ben.boeckel@kitware.com \
--cc=anlauf@gmx.de \
--cc=brad.king@kitware.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=nathan@acm.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).