From: Jeff Law <jeffreyalaw@gmail.com>
To: "Nick Clifton" <nickc@redhat.com>,
"Martin Liška" <mliska@suse.cz>,
gcc@gcc.gnu.org, binutils@sourceware.org
Subject: Re: [committed] exec-stack warning for test which wants executable stacks
Date: Mon, 25 Apr 2022 08:59:20 -0600 [thread overview]
Message-ID: <eec935c1-b81c-1383-c9d0-571273256363@gmail.com> (raw)
In-Reply-To: <f0915a33-63fd-97f1-9f5f-325bbe1a7d82@redhat.com>
On 4/25/2022 8:42 AM, Nick Clifton wrote:
> Hi Jeff,
>
>>>> I used -z execstack rather than --no-warn-execstack as the former
>>>> is recognized by older versions of ld, but the latter is a new option.
>>> Thanks for it.
>> Unfortunately, I should have looked at the other failures that have
>> popped up over the last week. Essentially all the nested function
>> tests are failing on some targets due to the same linker warning.
>>
>> Either pruning or adding the option to all those tests is going to
>> be necessary ;(
>
> Sorry for causing you so much hassle.
No worries. It's a very reasonable warning. And it's only if you're
testing with the latest binutils that it causes problems -- which is one
of the goals of the tester -- to find this stuff when it happens, not
6-12 months later.
> If it helps, Alan has already added
> some pruning code to binutils/testsuite/lib/binutils-common.exp in the
> prune_extra_warnings proc...
Yea. I saw that. I ultimately decided against pruning as it would be
useful to know if a test suddenly needs execstack. That would
generally be a sign of something gone horribly wrong. I just (locally)
added the magic to the rest of the affected tests and I'm testing it now.
jeff
next prev parent reply other threads:[~2022-04-25 14:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-24 17:42 Jeff Law
2022-04-25 12:56 ` Martin Liška
2022-04-25 14:37 ` Jeff Law
2022-04-25 14:42 ` Nick Clifton
2022-04-25 14:59 ` Jeff Law [this message]
2022-04-25 15:26 ` Nick Clifton
2022-04-25 15:30 ` Jeff Law
2022-05-26 1:17 ` Hans-Peter Nilsson
2022-05-26 23:17 ` Hans-Peter Nilsson
2022-04-26 13:54 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eec935c1-b81c-1383-c9d0-571273256363@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=binutils@sourceware.org \
--cc=gcc@gcc.gnu.org \
--cc=mliska@suse.cz \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).