[committed] exec-stack warning for test which wants executable stacks

[Jeff Law <jeffreyalaw@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1942 bytes --]

About a week ago many targets started failing pr94157_0.c test like this 
(bfin-elf, but many other targets are also affected):

> spawn -ignore SIGHUP /home/jlaw/test/obj/bfin-elf/obj/gcc/gcc/xgcc 
> -B/home/jlaw/test/obj/bfin-elf/obj/gcc/gcc/ c_lto_pr94157_0.o 
> -fdiagnostics-plain-output -dumpbase  -O0 -fipa-vrp -flto 
> -Wa,--noexecstack -Wa,--noexecstack -Wa,--execstack -Wa,--execstack 
> -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack 
> -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack 
> -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -msim 
> -Wl,-wrap,exit -Wl,-wrap,_exit -Wl,-wrap,main -Wl,-wrap,abort 
> -Wl,gcc_tg.o -o gcc-dg-lto-pr94157-01.exe^M
> /home/jlaw/test/obj/bfin-elf/installed/bfin-elf/bin/ld: warning: 
> /tmp/ccfJUEvZ.ltrans0.ltrans.o: requires executable stack (because the 
> .note.GNU-stack section is executable)^M
> FAIL: gcc.dg/lto/pr94157 c_lto_pr94157_0.o-c_lto_pr94157_0.o link,  
> -O0 -fipa-vrp -flto -Wa,--noexecstack -Wa,--noexecstack 
> -Wa,--execstack  -Wa,--execstack -Wa,--execstack -Wa,--execstack 
> -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack 
> -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack 
> -Wa,--execstack -Wa,--execstack

This is due to a new binutils warning.  This patch just suppresses the 
warning for the one test where we explicitly wanted an executable stack.

I'm guessing the repeated -Wa,--noexecstack options in this test are 
supposed to trigger a  buffer overflow or something similar, so I left 
those alone and just appended to the argument list.

I used -z execstack rather than --no-warn-execstack as the former is 
recognized by older versions of ld, but the latter is a new option.

The other approach would have been to prune the warning, but this seemed 
better since we'd like most tests to fail if somehow their stacks were 
executable.


Committed to the trunk.

Jeff


[-- Attachment #2: P --]
[-- Type: text/plain, Size: 1286 bytes --]

commit 6b7441a46c771aa6ecdc0c8ed96197417d036b9a
Author: Jeff Law <jeffreyalaw@gmail.com>
Date:   Sun Apr 24 13:38:14 2022 -0400

    [committed] exec-stack warning for test which wants executable stacks
    
    gcc/testsuite
            * gcc.dg/lto/pr94157_0.c: Also request executable stack from
            the linker.

diff --git a/gcc/testsuite/gcc.dg/lto/pr94157_0.c b/gcc/testsuite/gcc.dg/lto/pr94157_0.c
index a6e308b855b..a76141b1809 100644
--- a/gcc/testsuite/gcc.dg/lto/pr94157_0.c
+++ b/gcc/testsuite/gcc.dg/lto/pr94157_0.c
@@ -1,6 +1,6 @@
 /* { dg-lto-do link } */
 /* { dg-require-effective-target gas } */
-/* { dg-lto-options { { -O0 -fipa-vrp -flto -Wa,--noexecstack -Wa,--noexecstack -Wa,--execstack  -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack } } } */
+/* { dg-lto-options { { -O0 -fipa-vrp -flto -Wa,--noexecstack -Wa,--noexecstack -Wa,--execstack  -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wl,-z,execstack} } } */
 
 int main() {